Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread Ben Bolker
On Wed, May 14, 2025 at 12:46 PM Dirk Eddelbuettel wrote: > > > [ If you could, please set your email software up such that posts to a > mailing lists are not signed, it makes reading them more cumbersome. It > also means I can't reply (easily) inline now. ] > > In most cases environment varia

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread smallepsilon
user with default values. Therefore, there is another function, convenient_modify_matrix(): convenient_modify_matrix(mat) <- function(mat) modify_matrix(mat, other_args = default). To help verify that the code is correct, I want to check the result from identical() below: set.seed(20250514

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread smallepsilon
On Wednesday, May 14th, 2025 at 10:51 AM, Tim Taylor wrote: > I'd just use all.equal but I think you could just check the call is > constructed correctly, e.g. > > convenient_modify_matrix <- function(mat) modify_matrix(mat, other_args = > default) > > identical( > body(convenient_modify_mat

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread smallepsilon
On Wednesday, May 14th, 2025 at 10:33 AM, Dirk Eddelbuettel wrote: > > > Section 'A.3.1.3 Intel MKL' of the R Installation and Administration manual > covers that for the MKL case (and general OpenMP cases) > > The default number of threads will be chosen by the OpenMP software, but > c

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread Dirk Eddelbuettel
[ If you could, please set your email software up such that posts to a mailing lists are not signed, it makes reading them more cumbersome. It also means I can't reply (easily) inline now. ] In most cases environment variables need to be set before the process starts. Setting them inside the

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread Tim Taylor
On Wed, 14 May 2025, at 4:18 PM, smallepsilon wrote: > No need to apologize. I hope the following example helps clarify what I > mean. Suppose that modify_matrix(mat, other_args) is a function that, > among other things, applies eigen() to mat. For good reasons, > other_args has no default valu

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread Dirk Eddelbuettel
eck the result from identical() below: | | set.seed(20250514) | A <- modify_matrix(mat, other_args = default) | set.seed(20250514) | B <- convenient_modify_matrix(mat) | identical(A, B) | | In an ideal world, the result would be TRUE. The results can differ, though, because of multi

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread smallepsilon
On Wednesday, May 14th, 2025 at 12:59 PM, Ben Bolker wrote: > > > On Wed, May 14, 2025 at 12:46 PM Dirk Eddelbuettel e...@debian.org wrote: > > > [ If you could, please set your email software up such that posts to a > > mailing lists are not signed, it makes reading them more cumbersome. It >

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread smallepsilon
On Wednesday, May 14th, 2025 at 2:51 PM, Ivan Krylov wrote: > > My submission was rejected, not because of test failures, but because > > I had "removed the failing tests which is not the idea of tests." No > > errors/warnings/notes were reported to me. > > > Try measuring the test coverage of

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread Ivan Krylov via R-package-devel
В Tue, 13 May 2025 17:05:14 + smallepsilon пишет: > In many package tests, I want to verify that two ways of specifying > something lead to the execution of exactly the same calculations. Would you like to try tracing the linear algebra calculations themselves (together with their arguments)

Re: [R-pkg-devel] Advice for addressing CRAN rejection

2025-05-14 Thread Tim Taylor
> On 14 May 2025, at 02:21, Dirk Eddelbuettel wrote: > … > There is a higher-level README linked from CRAN package pages but I can't > find it now :-/ https://cran.r-project.org/web/checks/check_issue_kinds.html I believe Tim [[alternative HTML version deleted]] ___