Re: [R-pkg-devel] S3 generic/method consistency NOTE

2025-02-06 Thread Zhian Kamvar
This was the correct answer, thank you! On Thu, Feb 6, 2025 at 00:10 Ivan Krylov wrote: > В Wed, 5 Feb 2025 19:52:57 -0800 > Zhian Kamvar пишет: > > > Mismatches for methods registered for non-generic: > > is: > > function(object, class2) > > is.genind: > > function(x) > > > > i

Re: [R-pkg-devel] S3 generic/method consistency NOTE

2025-02-06 Thread Ivan Krylov via R-package-devel
В Wed, 5 Feb 2025 19:52:57 -0800 Zhian Kamvar пишет: > Mismatches for methods registered for non-generic: > is: > function(object, class2) > is.genind: > function(x) > > is: > function(object, class2) > is.genpop: > function(x) > > sample: > function(x, size, rep

[R-pkg-devel] S3 generic/method consistency NOTE

2025-02-05 Thread Zhian Kamvar
I'm getting this warning in an old package and im not quite sure how to fix it. I've always understood the is.thing sort of functions as always taking a single argument, which is usually "x" Do I have to update the is.genind etc signature to take two arguments? Note below Check: S3 generic/metho