Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-19 Thread Bryan Hanson
tions, which are then included in my own package. > > Best, > Aixiang > > > From: Ivan Krylov > Sent: Tuesday, December 17, 2024 2:15 AM > To: Aixiang Jiang > Cc: r-package-devel@r-project.org > Subject: Re: [R-pkg-devel] [CRAN-pr

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Aixiang Jiang
From: Ivan Krylov Sent: Tuesday, December 17, 2024 2:15 AM To: Aixiang Jiang Cc: r-package-devel@r-project.org Subject: Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6 CAUTION: EXTERNAL EMAIL. Verify both the sender's email and name.

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Aixiang Jiang
Revilla Sent: Tuesday, December 17, 2024 2:43 AM To: Ivan Krylov Cc: Aixiang Jiang ; r-package-devel@r-project.org Subject: Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6 CAUTION: EXTERNAL EMAIL. Verify both the sender's email and name. Avoid links/attach

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Aixiang Jiang
-project.org Subject: Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6 CAUTION: EXTERNAL EMAIL. Verify both the sender's email and name. Avoid links/attachments unless expected. Report any suspicious message by forwarding it as an attachment to spamm...@bccrc.ca

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Duncan Murdoch
Nice spotting! Just for fun, I just asked chatgpt if there were any other problems in that code. It spotted 3, but not the one you found. Two of them were definitely bogus, but this one might not be: On line 471 kmax is used, but it may not be initialized. Duncan Murdoch On 2024-12-17 5:1

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Lluís Revilla
Dear Aixiang, Thanks for using a Bioconductor package as your dependency. Please use the maintainer preference to report bugs, as set on the DESCRIPTION file: Bug Reports http://github.com/zeehio/MassSpecWavelet/issues The support site (support.bioconductor.org) is generally set up to help users

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Ivan Krylov via R-package-devel
Dear Aixiang, Welcome to R-package-devel! В Tue, 17 Dec 2024 09:47:26 + Aixiang Jiang пишет: > I am really confused by the error, which did not happen in the > previous versions. > > Since I have not changed my code at all, the possible reason is that > the external function is changed. T

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Duncan Murdoch
On 2024-12-17 4:47 a.m., Aixiang Jiang wrote: Hi, team, I am really confused by the error, which did not happen in the previous versions. Since I have not changed my code at all, the possible reason is that the external function is changed. However, there is no error at all and all of my cod

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Aixiang Jiang
Hi, team, I am really confused by the error, which did not happen in the previous versions. Since I have not changed my code at all, the possible reason is that the external function is changed. However, there is no error at all and all of my code runs successfully in my local machine. So, ho