Re: [R-pkg-devel] Non-reproducible ASAN flagged issue

2024-12-18 Thread David Cortes
Thank you, that was very helpful indeed! I've filed a bug report with GCC just in case: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118113 Best regads, David Cortes On Wed, 2024-12-18 at 17:34 +0300, Ivan Krylov wrote: > В Tue, 17 Dec 2024 20:26:01 +0100 > David Cortes пишет:

[R-pkg-devel] Non-reproducible ASAN flagged issue

2024-12-17 Thread David Cortes
which happens in the contents of a string literal that's used as constructor for 'std::regex': https://github.com/david-cortes/isotree/blob/1f84128a03bb6fc5eecd1de7aebf4b745b54fa1e/src/formatted_exporters.cpp#L332C13-L332C31 std::regex_replace(s, std::regex("\""), "\\

Re: [R-pkg-devel] Altrep header, MSVC, and STRUCT_SUBTYPES macro

2024-05-16 Thread David Cortes
#x27;R_UnwindProtect', C++ 'catch' that involves destructing variables before 'R_ContinueUnwind', and then 'Rf_error'. On Thu, 2024-05-16 at 16:25 +0300, Ivan Krylov wrote: > В Wed, 15 May 2024 18:54:37 +0200 > David Cortes пишет: > > > The code

[R-pkg-devel] Altrep header, MSVC, and STRUCT_SUBTYPES macro

2024-05-15 Thread David Cortes
I'm seeing some issues using R Altrep classes when compiling a package with the MSVC compiler on windows. While CRAN doesn't build windows binaries with this compiler, some packages such as Arrow and LightGBM have had some success in building their R packages with MSVC outside of CRAN, in order to

Re: [R-pkg-devel] Package not building for i386 after adding configure.win

2021-05-16 Thread David Cortes
That solves it, thank you! Best regards, David Cortes On Sun, 2021-05-16 at 16:47 -0700, Kevin Ushey wrote: > Based on this output: > > ** libs > Warning: this package has a non-empty 'configure.win' file, > so building only the main architecture > > Does addi

[R-pkg-devel] Package not building for i386 after adding configure.win

2021-05-16 Thread David Cortes
I recently tried adding a configure.win file to a package (https://github.com/david-cortes/MatrixExtra/blob/master/configure.win) . This file calls the Rscript executable in order to extract information about the R build and prepare a Makevars.win file: -- HAS_LD=`${R_HOME}/bin${R_ARCH_BIN

[R-pkg-devel] Using RC_fopen in a CRAN package

2021-04-02 Thread David Cortes
I’d like to ask for clarification about CRAN policies regarding usage of functions that start with "RC_*", such as "RC_fopen". I'm trying to upload a package which is meant for reading and writing data from text files in a certain format, for which I want to use a C file pointer which I obtain thr

[R-pkg-devel] Conditional linking in Makevars

2020-08-11 Thread David Cortes
oes on Linux and probably on FreeBSD).” I am wondering if it is somehow possible to add conditional link arguments in a Makevars file depending on the user’s operating system, or if not possible, whether it would somehow hurt in windows/mac installations to add a raw -latomic in there. B

Re: [R-pkg-devel] Error in CHECK caused by dev.off()

2020-07-23 Thread David Cortes
on in the location pointed to by TMPDIR: and such usage should be cleaned up)." And I think the policy was different at some point in the past. Anyway, it's a good policy - just get a temporary folder and your desired file name - e.g.: file.path(tempdir(), "your_file.png") Best

Re: [R-pkg-devel] Valgrind warning on saveRDS, about object in external pointer

2020-07-15 Thread David Cortes
. Thanks again for your help! Best regards, David Cortes On Wed, 2020-07-15 at 16:51 +0300, Ivan Krylov wrote: > On Wed, 08 Jul 2020 22:43:13 +0300 > David Cortes wrote: > > > About the source code: it actually complains about line > > fit_model.cpp:751 : > > hplane_root-&

Re: [R-pkg-devel] Valgrind warning on saveRDS, about object in external pointer

2020-07-08 Thread David Cortes
it could have uninitialized elements with no complaints from asan or valgrind when creating the S3 object that goes to ‘saveRDS’. Best regards, David Cortes On Wed, 2020-07-08 at 20:59 +0300, Ivan Krylov wrote: > On Wed, 08 Jul 2020 19:23:41 +0300 > David Cortes wrote: > > > - The w

[R-pkg-devel] Valgrind warning on saveRDS, about object in external pointer

2020-07-08 Thread David Cortes
the new copied bytes are accessed. Any help is appreciated. Sincerely, David Cortes __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel