Re: [R-pkg-devel] SystemRequirements & configure check for FFTW with single precision support

2025-01-17 Thread Lukas Schneiderbauer
Hi Simon, Thank you for your detailed feedback! I rebuilt the configure script to use pkg-config, removed the extra brew-check, fixed the CPPFLAGS issue you mentioned, and included "fftw-s" in SystemRequirements. The package is building fine again on all platforms (using rhub tests and the `devtoo

Re: [R-pkg-devel] SystemRequirements & configure check for FFTW with single precision support

2025-01-17 Thread Lukas Schneiderbauer
Thanks for the feedback and advice! I removed the omp.h test, I guess using AC_OPENMP should do the trick anyways. I will also try your suggestion regarding the SystemRequirements. Let's see if it will be accepted this time. I'm sorry for asking this admittedly thick question, but are you sure >

Re: [R-pkg-devel] Best practices for built version checking in packages LinkingTo others?

2025-01-17 Thread Ben Bolker
I wouldn't guarantee that it's best practices, but for reference this is what glmmTMB does about checking the Matrix and TMB versions (Matrix has a formal ABI version distinct from its package version; TMB doesn't) https://github.com/glmmTMB/glmmTMB/blob/b7936f4cbe9f26e3d8d5eae727afd83f6ec2b

Re: [R-pkg-devel] Best practices for built version checking in packages LinkingTo others?

2025-01-17 Thread Ivan Krylov via R-package-devel
В Fri, 17 Jan 2025 10:21:27 + Pavel Krivitsky via R-package-devel пишет: >1. What is the best way to save this information? I have a > rudimentary implementation [1] For now, this is the best way we have. Export the ABI version as an include-time constant and as a registered callab

[R-pkg-devel] Best practices for built version checking in packages LinkingTo others?

2025-01-17 Thread Pavel Krivitsky via R-package-devel
Dear All, I maintain a package ('ergm') that exports a C API via /inst/include/ that includes header files with data structures, macros, and inline functions, as well as a number of functions exported in a stubs file (that use R_FindSymbol() and/or R_GetCCallable() to locate the functions in 'ergm

Re: [R-pkg-devel] Help with clang-san warnings for package "tidyfit"

2025-01-17 Thread Johann Pfitzinger
Hi Ivan, thanks for your helpful response and for the background info! Much appreciated! I'll reply-all as you suggested. Best regards, Johann On 16.01.25 21:30, Ivan Krylov wrote: В Wed, 15 Jan 2025 22:13:36 +0100 Johann Pfitzinger пишет: I have, so far, failed to reproduce this or to f