[R-pkg-devel] Non-reproducible ASAN flagged issue

2024-12-17 Thread David Cortes
I am seeing a curious error in an ASAN package check which is not reproducible in the r-debug containers (https://github.com/wch/r-debug), and which I'm suspecting might be a compiler bug. Wanted to ask for a second opinion on whether this could actually be a compiler bug or a real bug in the pack

Re: [R-pkg-devel] Changes in function call with respect to the current published version

2024-12-17 Thread Georgi Boshnakov
> myfun(y = birthweight, x = cotinine, z = age, data = mydata, ...) > and new usage would be > myfun(formula = birthweight ~ cotinine + age, data = mydata, ...) The NEWS file should state this incompatible change, loudly. If you don't want to break user code, you could make the new signature of

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Aixiang Jiang
Thank you so much for pointing out the detailed info - Ivan! Since the time for me to revise my own package is limited (otherwise my package will be withdrawn), I ended up revising the C functions and converting into R functions, which are then included in my own package. Best, Aixiang ___

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Aixiang Jiang
Thank you - Llu��s! Since the time for me to revise my own package is limited (otherwise my package will be withdrawn), I ended up revising the C functions and converting into R functions, which are then included in my own package. Best, Aixiang From: Llu��s Re

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Aixiang Jiang
Thank you - Duncan! I ended up revising the C functions and converted into R functions, which are then included in my own package. Best, Aixiang From: Duncan Murdoch Sent: Tuesday, December 17, 2024 6:05 AM To: Ivan Krylov ; Aixiang Jiang Cc: r-package-devel@r-

[R-pkg-devel] Changes in function call with respect to the current published version

2024-12-17 Thread Jose Barrera-Gómez
Dear List, I have a package that works in the context of regression models. The main function has arguments (y, x, z, data, ...), where y is the response variable, x is the explanatory variable and z can be other covariates. Due to some bugs, I am interested in changing the call from (y, x, z, da

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Duncan Murdoch
Nice spotting! Just for fun, I just asked chatgpt if there were any other problems in that code. It spotted 3, but not the one you found. Two of them were definitely bogus, but this one might not be: On line 471 kmax is used, but it may not be initialized. Duncan Murdoch On 2024-12-17 5:1

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Lluís Revilla
Dear Aixiang, Thanks for using a Bioconductor package as your dependency. Please use the maintainer preference to report bugs, as set on the DESCRIPTION file: Bug Reports http://github.com/zeehio/MassSpecWavelet/issues The support site (support.bioconductor.org) is generally set up to help users

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Ivan Krylov via R-package-devel
Dear Aixiang, Welcome to R-package-devel! В Tue, 17 Dec 2024 09:47:26 + Aixiang Jiang пишет: > I am really confused by the error, which did not happen in the > previous versions. > > Since I have not changed my code at all, the possible reason is that > the external function is changed. T

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Duncan Murdoch
On 2024-12-17 4:47 a.m., Aixiang Jiang wrote: Hi, team, I am really confused by the error, which did not happen in the previous versions. Since I have not changed my code at all, the possible reason is that the external function is changed. However, there is no error at all and all of my cod

Re: [R-pkg-devel] [CRAN-pretest-archived] CRAN Submission NMRphasing 1.0.6

2024-12-17 Thread Aixiang Jiang
Hi, team, I am really confused by the error, which did not happen in the previous versions. Since I have not changed my code at all, the possible reason is that the external function is changed. However, there is no error at all and all of my code runs successfully in my local machine. So, ho