[R-pkg-devel] Three-argument S3method declaration does not seem to affect dispatching from inside the package.

2019-05-13 Thread Pavel Krivitsky
Dear All, I've run into this while updating a package with unfortunately named legacy functions. It seems like something that might be worth changing in R, and I want to get a sense of whether this is a problem before submitting a report to the Bugzilla. It appears that the 3-argument form of S3m

Re: [R-pkg-devel] "unable to verify current time" in R CMD check

2019-05-13 Thread Juhee Lee
Sorry for late to reply. I didn't try it on win-builder and r-hub neither. This NOTE came out on my personal computer. I'll try it on them. Thank you for your help. On Fri, 10 May 2019 at 23:52, IƱaki Ucar wrote: > On Fri, 10 May 2019 at 13:22, Juhee Lee wrote: > > > > Hi, I'm checking my p

Re: [R-pkg-devel] Registered S3 methods from standard package

2019-05-13 Thread Colin Gillespie
Dr Colin Gillespie > > Or more simply: call the method prettyBplot. Rightly (but perhaps wrongly) I was trying for a simple method where the plots just change. If prettyB loaded, the plots just look a little nicer. If prettyB isn't available, then the plot function works as normal. So two possi

Re: [R-pkg-devel] Registered S3 methods from standard package

2019-05-13 Thread Duncan Murdoch
On 13/05/2019 4:56 a.m., Sebastian Meyer wrote: I think your package can be useful. However, I'm with CRAN here in that I would not want my standard graphics output to be changed just because some package ("prettyB") gets loaded, which could happen *unintentionally* as a dependency (or a dependen

Re: [R-pkg-devel] Registered S3 methods from standard package

2019-05-13 Thread Sebastian Meyer
I think your package can be useful. However, I'm with CRAN here in that I would not want my standard graphics output to be changed just because some package ("prettyB") gets loaded, which could happen *unintentionally* as a dependency (or a dependency of a dependency, ...) of another package. What

Re: [R-pkg-devel] Registered S3 methods from standard package

2019-05-13 Thread Colin Gillespie
> Have you checked that this actually works? Many base R functions do some > preparation and call directly plot.default(), so they both bypass the method > and see graphics::plot.default, not yours, see e.g. plot.ts(). It doesn't work for all plot.XXX for the reasons you describe. But my use cas

Re: [R-pkg-devel] Registered S3 methods from standard package

2019-05-13 Thread Georgi Boshnakov
> The general idea is to replace plot.default() with an alternative (matching all arguments) and export. This would allow users to simply load the package and use base graphics functions as normal, but get a pretty graph. Have you checked that this actually works? Many base R functions do some pr

[R-pkg-devel] Registered S3 methods from standard package

2019-05-13 Thread Colin Gillespie
Dear All, I'm developing a small package to make plotting methods a little bit nicer looking: https://github.com/jumpingrivers/prettyB/ The general idea is to replace plot.default() with an alternative (matching all arguments) and export. This would allow users to simply load the package and use