Re: [R-pkg-devel] Package builds, installs, and runs but does not pass devtools::check()

2018-07-17 Thread Michael Hannon
Thanks, Mark. Your points are well-taken, but I wouldn't refer to this as a "small side-track". You don't say so, but this could be interpreted as a recommendation to avoid some or all of the "tidyverse" in developing packages. I'm actually quite comfortable doing the base-R-style programming yo

Re: [R-pkg-devel] More on explosive dependencies

2018-07-17 Thread Lenth, Russell V
For the methods registered by the code I show, those do NOT go in the NAMESPACE file, and there are no roxygen2 @export tags for those methods. Russ On Jul 17, 2018, at 12:41 AM, David Hugh-Jones mailto:davidhughjo...@gmail.com>> wrote: Hi Russell, That's v helpful and I am going to try it m

Re: [R-pkg-devel] Package builds, installs, and runs but does not pass devtools::check()

2018-07-17 Thread Mark van der Loo
Michael, Just a small side-track here. I would avoid using the not-a-pipe operator within functions or packages in general. It is great for interactive use, but it does make debugging and hence long-term maintenance of functions harder. There are two reasons for this. First, it hides intermediate

Re: [R-pkg-devel] Package builds, installs, and runs but does not pass devtools::check()

2018-07-17 Thread Michael Hannon
Thanks to John and Zhian for their recent and informative comments. Regarding check() and NSE: the moral seems to be that a little learning is a dangerous thing. I'm off to try to bring quosure to this issue. -- Mike On Mon, Jul 16, 2018 at 2:38 PM, Zhian Kamvar wrote: > Using dplyr like that