[Rd] stats/ar.R issue - else branch never used

2025-01-03 Thread Norbert Kuder
ifelse(xaic == maic, 0, Inf), 0L:order.max) Because maic is always 0 or 1, is.finite(maic) is always T, so the else branch (ifelse(xaic == maic, 0, Inf)) never executes. Please check if my finding is valid. Best regards, Norbert Kuder [[alternative HTML version d

[Rd] stats/HoltWinters.R inverted logic in seasonal in R and C

2025-01-03 Thread Norbert Kuder
1), 0)), as.integer(start.time), as.integer(seasonalChoice), as.integer(f), as.integer(!is.logical(beta) || beta), as.integer(!is.logical(gamma) || gamma), ... ) } Please check the proposed solution. Regards, Norbert Kuder

Re: [Rd] Possible issue in stats/arima.R package

2025-01-03 Thread Norbert Kuder
Martin, thank you solving this issue. Anyway there is the same bug in arima0.R: https://github.com/wch/r-source/blob/4a1ed749271c52e60a85e794e6f34b0831efb1ae/src/library/stats/R/arma0.R#L79 Best regards, Norbert Kuder czw., 2 sty 2025, 21:53 użytkownik Martin Maechler < ma

[Rd] Possible issue in stats/arima.R package

2025-01-02 Thread Norbert Kuder
;- makeARIMA(trarma[[1]], trarma[[2]], Delta, kappa, SSinit) I am trying to confirm whether this is intended behavior or possibly an overlooked detail. Could someone please clarify if the current logic is correct? Thank you. Best regards, Norbert Kuder [[alternative HTML version deleted]