Re: [Rd] custom allocators, Valgrind and uninitialized memory

2021-03-30 Thread Tomas Kalibera
On 3/29/21 10:18 PM, Andreas Kersting wrote: Hi Tomas, Thanks for sharing your view on this! I understand your point, but still I think that the current situation is somewhat unfortunate: I would argue that mmap() is a natural candidate to be used together with allocVector3(); it is even ment

Re: [Rd] nchar(x, type = "bytes") seems slower than it could be

2021-03-30 Thread Tomas Kalibera
Thanks for the report, you are probably running into the overhead of the eager creation of the error message. On my system, with your micro-benchmark, it is about 10x. I've tested simply by uncommenting it and re-running the benchmark. I'll fix (this is not a good task for a contributed patch).

Re: [Rd] custom allocators, Valgrind and uninitialized memory

2021-03-30 Thread Kasper Daniel Hansen
On Tue, Mar 30, 2021 at 9:39 AM Tomas Kalibera wrote: > appropriate to tell valgrind about it. As this is becoming rather too > technical and specific to the internals, feel free to take this offline > with Simon and me. > Respectfully, this seems to me to be exactly the kind of exchange R-dev

Re: [Rd] custom allocators, Valgrind and uninitialized memory

2021-03-30 Thread Andreas Kersting
Hi Simon, hi Tomas, Let me try to wrap up this discussion: - "What does any of this to do with CRAN?" Not much, I agree. It is just that this whole issue arose because the CRAN team asked me to fix the use of uninitialized memory as reported by Valgrind. Sorry for mixing things up here. - "I d