Re: [Rd] Garbage collection of seemingly PROTECTed pairlist

2020-09-12 Thread peter dalgaard
Hm, I'm getting rusty on my C skills, but you repeatedly use a pattern like > while (row_num <= nr) { >Rprintf("row_num: %i\n", row_num); >SEXP row = PROTECT(C_int_mat_nth_row_nrnc(int_mat_int, nr, 2, row_num)); I wonder if there is a subtle difference between assignments and initialized

Re: [Rd] Including full text of open source licenses in a package

2020-09-12 Thread Abby Spurdle
> > Including a copy of the license with the work is vital Hmmm... Agree. Just for context: CRAN has a history of being exceptionally useful and efficient. In general, I don't support suggestions to change their submission policies. __ R-devel@r-projec

Re: [Rd] Including full text of open source licenses in a package

2020-09-12 Thread Hugh Parsonage
Perhaps I have misread that excerpt from WRE, but my read is that package authors should not duplicate GNU COPYING, since it is present in all R distributions already when using GPL-2 and friends. It doesn't apply to packages distributed with other licenses. It should be noted that in GPL FAQ jus

Re: [Rd] Garbage collection of seemingly PROTECTed pairlist

2020-09-12 Thread Iñaki Ucar
Hi, In line 5, you are allocating a vector of length nc. Then, in line 12, you are using nr as a limit, so if nr goes beyond nc, which is happening in line 39, you are in trouble. Iñaki On Sat, 12 Sep 2020 at 03:30, Rory Nolan wrote: > I want to write an R function using R's C interface that t

Re: [Rd] Including full text of open source licenses in a package

2020-09-12 Thread Hadley Wickham
On Saturday, September 12, 2020, Hugh Parsonage wrote: > Perhaps I have misread that excerpt from WRE, but my read is that > package authors should not duplicate GNU COPYING, since it is present > in all R distributions already when using GPL-2 and friends. It > doesn't apply to packages distrib

Re: [Rd] Garbage collection of seemingly PROTECTed pairlist

2020-09-12 Thread Rory Nolan
Iñaki is right. This solves it. Kudos to Martin Morgan too for paring down my reprex; I wasn’t aware of the method with R CMD SHLIB that he kindly described. Thanks also to Peter Dalgaard for having a crack at it. Very grateful to you all. > On 12 Sep 2020, at 04:16, Iñaki Ucar wrote: > > Hi