Martin, also from me a heartfelt thank you for taking care of this. Some
thoughts on Henrik's response:
On Mon, May 7, 2018 at 2:28 AM, Henrik Bengtsson wrote:
>
> I still argue that the current behavior cause more harm than it helps.
>
I agree with your analysis of the problems this legacy beh
Hi Tomas,
The crash is no longer happening on Windows 10 16299 (R-devel 74699). I have
seen your fix in trunk@74693, which replaced ReadConsoleInputA with the -W
alternative. Then I tested the A version on Win10 16299 and Win7 7600 with this
code [ https://paste.ubuntu.com/p/Ggm6867yFC/ ]. The
I'd add my support for mode = "wb" to (eventually) become the default,
though I respect Tomas's comments about backwards-compatibility.
Instead of making the argument mandatory (which would immediately
break scripts -- even ones that won't be helped by changing to mode =
'wb') or otherwise changin
Hey all,
I don't have a strong opinion about whether the default should ultimately
eventually change or not. Many people who use windows (a set which does not
include me) seem to think it would be better.
I will say that like Hugh, I'm strongly against making the argument
mandatory as an interim
I would have expected coercion to an integer vector or at least a complaint
that the user did not provide a valid matrix dimension.
> .col(c(1,1))
Error in .col(c(1, 1)) :
a matrix-like object is required as argument to 'col'
> .col(c(1L,1L))
[,1]
[1,]1
> sessionInfo()
R version 3.5.0
Hugh,
(Note I speak for myself only and not for R-core) Thanks for looking into
this. I think it's great to have community members that are interested in
contributing to R and helping it continue to get better.
And I think, and my local experiments bear out, that using anyNA as a
fastpass conditi
Thanks Gabe, and yes happy for you to submit the patch.
Some thoughts I've had in the interim:
1. Matt Dowle encouraged me to submit a patch as it could improve the
CRAN check farm timings since `ifelse` is presumably used a lot. I
thought the biggest benefit might come by improving the speed whe
