Re: [Rd] [PATCH] fix CHECK_this_length in sprintf.c

2016-04-08 Thread Matthew Fowles Kulukundis
Martin~ Sorry about the bad patch. I work on C++ at Google. We built a check for clang-tidy that identifies errors of this form and discovered the error here as part of our search. I am just trying to be a good citizen and upstream a fix, but I must have gotten sloppy as I was doing a bunch of th

Re: [Rd] (no) circular dependency

2016-04-08 Thread Adrian Dușa
Hi Mark, Uhm... sometimes this is not always possible. For example I have a package QCA which produces truth tables (all combinations of presence / absence of causal conditions), and it uses the venn package to draw a Venn diagram. It is debatable if one should assimilate the "venn" package into t

Re: [Rd] (no) circular dependency

2016-04-08 Thread Mark van der Loo
Well, I'm not saying that Dmitri _should_ do it. I merely mention it as an option that I think is worth thinking about -- it is easy to overlook the obvious :-). Since we have no further info on the package's structure we can't be sure.. Op vr 8 apr. 2016 om 13:59 schreef Adrian Dușa : > Hi Ma

Re: [Rd] (no) circular dependency

2016-04-08 Thread Dmitri Popavenko
Thanks all, I don't know either (for the moment). It's all in the design phase still. Generally, I would also like to keep specific functions in specific packages, if at all possible. On Fri, Apr 8, 2016 at 3:03 PM, Mark van der Loo wrote: > Well, I'm not saying that Dmitri _should_ do it. I mer

Re: [Rd] (no) circular dependency

2016-04-08 Thread Gabriel Becker
Another, perhaps slightly off the wall reframing of the 3-package possibility: Have packages B, a, and UserFacingA, as follows *a* contains all the functionality in your A package that *does not depend on B* *B* *imports from* *a* and is essentially unchanged *UserFacingA* *Depends* on *a* and *i

[Rd] PR# for match.arg(arg)

2016-04-08 Thread Suharto Anggono Suharto Anggono via R-devel
In "R News", in "Changes in R 3.3.0", in "New Features", a news item is match.arg(arg) (the one-argument case) is faster; so is sort.int(). (PR#16640) While it was motivated by speeding up tapply, it is in a separate bug number: 16652 (https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=16652).

Re: [Rd] (no) circular dependency

2016-04-08 Thread Gregory Warnes
A third possibility, which I use in my gtools and gdata packages, is to use soft-links to create a copy of the relevant functions from one package in the other. I make sure these functions are *not* exported, so no conflicts are created, and the use of soft-links mean the code never gets out of

Re: [Rd] Under Windows, Rgui and Rterm crash if one tries to close the graphic device while identify or locator are running

2016-04-08 Thread Duncan Murdoch
On 05/04/2016 3:35 PM, Duncan Murdoch wrote: On 05/04/2016 11:56 AM, Henrik Bengtsson wrote: > If of any help, > > I can reproduce this (on Windows 7) back to at least R 3.0.3 but it's > not there in R 3.0.0. (I have *not* checked with R 3.0.1 and 3.0.2 > which I don't have installed). That doe

Re: [Rd] (no) circular dependency

2016-04-08 Thread Adrian Dușa
Hi Greg, That's interesting but I assume those are self-contained functions. In my case, the truthTable() function from package QCA depends on numerous other functions in the QCA package so I'm not sure how feasible it is to copy everything from each package to every other package. Best, Adrian

Re: [Rd] (no) circular dependency

2016-04-08 Thread Hadley Wickham
In that scenario, I would expect that QCA would suggest Venn and Venn would suggest QCA. Then there's no circular dependency problem. Hadley On Fri, Apr 8, 2016 at 6:59 AM, Adrian Dușa wrote: > Hi Mark, > > Uhm... sometimes this is not always possible. > For example I have a package QCA which pr