Re: [Rd] new behavior in model.response -- Solved

2018-06-28 Thread Therneau, Terry M., Ph.D. via R-devel
Thanks to multiple readers for comments and patience as I sorted this out.  I now have working length and names methods for Surv objects, which do not seem to break anything.   I just ran the test suites for 471 packages that depend on survival, but I don't test against bioconductor so cannot

Re: [Rd] new behavior in model.response

2018-06-27 Thread Berry, Charles
> On Jun 27, 2018, at 3:58 PM, Achim Zeileis wrote: > > On Thu, 28 Jun 2018, Therneau, Terry M., Ph.D. via R-devel wrote: > >> I now understand the issue, which leads to a different and deeper issue >> which is "how to assign a proper length to Surv objects". >> >> > Surv(c(1,2,3), c(1,0,1)

Re: [Rd] new behavior in model.response

2018-06-27 Thread Achim Zeileis
On Thu, 28 Jun 2018, Therneau, Terry M., Ph.D. via R-devel wrote: I now understand the issue, which leads to a different and deeper issue which is "how to assign a proper length to Surv objects". > Surv(c(1,2,3), c(1,0,1)) [1] 1  2+ 3 The above prints as 3 elements and is conceptually 3 eleme

Re: [Rd] new behavior in model.response

2018-06-27 Thread Therneau, Terry M., Ph.D. via R-devel
I now understand the issue, which leads to a different and deeper issue which is "how to assign a proper length to Surv objects". > Surv(c(1,2,3), c(1,0,1)) [1] 1  2+ 3 The above prints as 3 elements and is conceptually 3 elements. But if I give it length method to return a 3 then I need a n