Re: [Rd] Segfault with match()

2015-03-30 Thread luke-tierney
The segfault was occurring in Rf_asCharacterFactor, which was using the levels attribute without sanity checks. Sanity checks are now added (r68119 in trunk and r68120. in R-3-2-branch), which now gives data(housing, package ="MASS") x <- housing$Type + housing$Sat Warning message: Incompatible

Re: [Rd] Segfault with match()

2015-03-30 Thread Hadley Wickham
I left out the warning - it's still there. The output object is malformed but either +.factor should prevent this or match() should check. Hadley On Mon, Mar 30, 2015 at 3:50 PM, William Dunlap wrote: > Did you leave out the warning from "+", which should be an error, > as it produces an illegal

Re: [Rd] Segfault with match()

2015-03-30 Thread William Dunlap
For consistency with factor+factor and factor+numeric, factor+ordered should produce a logical vector filled with NAs, not throw an error. Bill Dunlap TIBCO Software wdunlap tibco.com On Mon, Mar 30, 2015 at 1:50 PM, William Dunlap wrote: > Did you leave out the warning from "+", which should b

Re: [Rd] Segfault with match()

2015-03-30 Thread William Dunlap
Did you leave out the warning from "+", which should be an error, as it produces an illegal ordered factor in this case and factor+factor is nonsensical? Or is the warning missing in the current development version of R? > x <- factor("A", ordered=FALSE) + factor(c("B","C"), ordered=TRUE) Warning