Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Duncan Murdoch
On 24/05/2017 9:59 AM, Hiroyuki Kawakatsu wrote: On 2017-05-24, Duncan Murdoch wrote: [...] Okay, how about if we weaken the test? [...] try stopifnot(path.expand(paste0("~/", filename)) == paste0(path.expand("~/"), filename)) Nope: ## path.expand shouldn't translat

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Hiroyuki Kawakatsu
On 2017-05-24, Duncan Murdoch wrote: [...] > Okay, how about if we weaken the test? [...] > try > > stopifnot(path.expand(paste0("~/", filename)) == > paste0(path.expand("~/"), filename)) > Nope: > ## path.expand shouldn't translate to local encoding PR#17120 > filenam

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Duncan Murdoch
On 24/05/2017 7:59 AM, Hiroyuki Kawakatsu wrote: On 2017-05-24, Duncan Murdoch wrote: I think the test is wrong because in the first case you are working in a locale where that character is representable. In my locale it is not, so x1 is converted to UTF-8, and everything compares equal. An e

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Hiroyuki Kawakatsu
On 2017-05-24, Duncan Murdoch wrote: > > I think the test is wrong because in the first case you are working in a > locale where that character is representable. In my locale it is not, so x1 > is converted to UTF-8, and everything compares equal. > > An explicit conversion of x1 to UTF-8 should

Re: [Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Duncan Murdoch
On 24/05/2017 5:47 AM, Hiroyuki Kawakatsu wrote: Hi, I am failing make check in r72721 at the end of reg-tests-1d.R. The relevant block of code is ## path.expand shouldn't translate to local encoding PR#17120 filename <- "\U9b3c.R" print(Encoding(filename)) x1 <- path.expand(paste0("~/", filena

[Rd] reg-tests-1d.R fails in r72721

2017-05-24 Thread Hiroyuki Kawakatsu
Hi, I am failing make check in r72721 at the end of reg-tests-1d.R. The relevant block of code is ## path.expand shouldn't translate to local encoding PR#17120 filename <- "\U9b3c.R" print(Encoding(filename)) x1 <- path.expand(paste0("~/", filename)) print(Encoding(x1)) x2 <- paste0(path.expand("