Re: [Rd] issue with model.frame()

2018-05-01 Thread Therneau, Terry M., Ph.D. via R-devel
I want to add that the priority for this is rather low, since we have a couple of work arounds for the user/data set in question. I have some ideas about changing the way in which ridge() works, which might make the problem moot. The important short-term result was finding that it wasn't an er

Re: [Rd] issue with model.frame()

2018-05-01 Thread Berry, Charles
> On May 1, 2018, at 1:15 PM, Martin Maechler > wrote: > > What version of R is that ? Sorry. It was 3.4.2. But it doesn't matter, because my diagnosis was wrong even there. I think (based on my reading of my outdated version) the problem is a bit upstream in terms() as I noted in a follow

Re: [Rd] issue with model.frame()

2018-05-01 Thread Martin Maechler
> Berry, Charles > on Tue, 1 May 2018 16:43:18 + writes: >> On May 1, 2018, at 6:11 AM, Therneau, Terry M., Ph.D. via R-devel wrote: >> >> A user sent me an example where coxph fails, and the root of the failure is a case where names(mf) is not equal to the term.la

Re: [Rd] issue with model.frame()

2018-05-01 Thread William Dunlap via R-devel
You run into the same problem when using 'non-syntactical' names: > mfB <- model.frame(y ~ `Temp(C)` + `Pres(mb)`, data=data.frame(check.names=FALSE, y=1:10, `Temp(C)`=21:30, `Pres(mb)`=991:1000)) > match(attr(terms(mfB), "term.labels"), names(mfB)) # gives NA's [1] NA NA > attr(terms(mfB), "ter

Re: [Rd] issue with model.frame()

2018-05-01 Thread Berry, Charles
> On May 1, 2018, at 6:11 AM, Therneau, Terry M., Ph.D. via R-devel > wrote: > > A user sent me an example where coxph fails, and the root of the failure is a > case where names(mf) is not equal to the term.labels attribute of the formula > -- the latter has an extraneous newline. Here is an

[Rd] issue with model.frame()

2018-05-01 Thread Therneau, Terry M., Ph.D. via R-devel
A user sent me an example where coxph fails, and the root of the failure is a case where names(mf) is not equal to the term.labels attribute of the formula -- the latter has an extraneous newline. Here is an example that does not use the survival library. # first create a data set with many lon