Re: [Rd] all.equal failure and [.terms

2019-04-05 Thread Therneau, Terry M., Ph.D. via R-devel
The all.equal was a side issue for me; I don't have strong opinions one way or the other.  You are welcome to leave me out of the loop on that.  (Or leave me on the cc, whatever is easiest).  I will update the survival package once the [.terms issues are addressed.  One debatable issues is

Re: [Rd] all.equal failure

2019-04-05 Thread Duncan Murdoch
On 05/04/2019 9:03 a.m., Therneau, Terry M., Ph.D. via R-devel wrote: This arose in testing [.terms and has me confused. data(esoph)   # use a standard data set t0x <- terms(model.frame( ~ tobgp, data=esoph)) t1 <-  terms(model.frame(ncases ~ agegp + tobgp, data=esoph)) t1x <- (delete.response(

[Rd] all.equal failure

2019-04-05 Thread Therneau, Terry M., Ph.D. via R-devel
This arose in testing [.terms and has me confused. data(esoph)   # use a standard data set t0x <- terms(model.frame( ~ tobgp, data=esoph)) t1 <-  terms(model.frame(ncases ~ agegp + tobgp, data=esoph)) t1x <- (delete.response(t1))[-1] > all.equal(t0x, t1x) [1] TRUE # the above is wrong, because