Re: [Rd] all.equal() improvements (PR#8191)

2006-01-02 Thread Martin Maechler
> "BDR" == Prof Brian Ripley <[EMAIL PROTECTED]> > on Mon, 2 Jan 2006 20:39:18 + (GMT) writes: BDR> Martin, BDR> I have some tests running over CRAN now (RUnit has also failed), thank you, Brian, for the feedback BDR> but have already noticed things like >> swi

Re: [Rd] all.equal() improvements (PR#8191)

2006-01-02 Thread Prof Brian Ripley
Martin, I have some tests running over CRAN now (RUnit has also failed), but have already noticed things like > swiss[, 1] -> x > names(x) <- rownames(swiss) > all.equal(x, x[1:10]) [1] "Names: Lengths (47, 10) differ (string compare on first 10)" [2] "Numeric: lengths (47, 10) differ" which is

Re: [Rd] all.equal() improvements (PR#8191)

2006-01-02 Thread maechler
I'm "happy" to have found the first problem myself: 'Matrix' doesn't pass R CMD check anymore with the change I had committed: Basically because of this: > all.equal(cbind(1:5), matrix(1:5, 5,1, dimnames=list(NULL,NULL))) [1] "Attributes: < Names: Lengths (1, 2) differ (string compare on fi

Re: [Rd] all.equal() improvements (PR#8191)

2006-01-02 Thread maechler
I've now finally finalized my work on a subset of Andy's propositions, and committed it to R-devel. The current change doesn't show in our own checks and examples, but may well in other people's package checks. For this reason, I've also added a line to the 'USER-VISIBLE CHANGES' part of the NEWS

[Rd] all.equal() improvements (PR#8191)

2005-10-09 Thread atp
--k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The attached patch against R 2.2.0 makes the following improvements to the all.equal() function: 1. Check names! Stock R all.equal() (unlike S-Plus) ignores names completely on some objects. I consider