Re: [Rd] Suggestion to emphasize Rboolean is unrelated to LGLSXP in R-exts

2025-02-05 Thread Tomas Kalibera
On 1/30/25 22:07, Michael Chirico wrote: Hello all, The recent change (r87656) to make Rboolean map to type 'bool', not 'int', broke some tests & made me realize I've had totally the wrong impression about what Rboolean actually is, and I suspect I'm not alone. Till now, I've assumed that lik

Re: [Rd] Suggestion to emphasize Rboolean is unrelated to LGLSXP in R-exts

2025-02-04 Thread Tomas Kalibera
On 2/1/25 10:39, Ivan Krylov via R-devel wrote: On Thu, 30 Jan 2025 13:07:31 -0800 Michael Chirico wrote: There are at least dozens of other cases on CRAN [2],[3]. Some of these involve casting an int to Rboolean. Best case, the int is compared against NA_LOGICAL beforehand, avoiding any mi

Re: [Rd] Suggestion to emphasize Rboolean is unrelated to LGLSXP in R-exts

2025-02-03 Thread Prof Brian Ripley via R-devel
On 02/02/2025 15:50, Ivan Krylov via R-devel wrote: The good news is that without a C23-enabled compiler, the problem will only happen to source files that #include . The bad news is that such a source file will technically disagree with the rest of R about the type of Rboolean, including the pro

Re: [Rd] Suggestion to emphasize Rboolean is unrelated to LGLSXP in R-exts

2025-02-02 Thread Ivan Krylov via R-devel
The good news is that without a C23-enabled compiler, the problem will only happen to source files that #include . The bad news is that such a source file will technically disagree with the rest of R about the type of Rboolean, including the prototypes of the API functions that accept Rboolean: #i

[Rd] Suggestion to emphasize Rboolean is unrelated to LGLSXP in R-exts

2025-01-30 Thread Michael Chirico
Hello all, The recent change (r87656) to make Rboolean map to type 'bool', not 'int', broke some tests & made me realize I've had totally the wrong impression about what Rboolean actually is, and I suspect I'm not alone. Till now, I've assumed that like Rbyte --> RAWSXP, Rboolean is the _correct_