Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Paul Gilbert
(Please correct me if I'm wrong. I thought I mostly understood this, finally, but I've made the mistake of thinking I understood something too many times before.) On 08/28/2014 10:39 AM, Simon Urbanek wrote: On Aug 27, 2014, at 6:01 PM, Gavin Simpson wrote: On 27 August 2014 15:24, Hadley

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Gabor Grothendieck
Yes, Depends certainly has a role. The ability of one package to automatically provide all the facilities of another package to the user is important. There are many situations where the functionality you want to provide to the user is split among multiple packages. For example, 1. xts uses zoo a

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Gabriel Becker
Gavin, I don't claim to be the arbiter of good package design. The following are my opinions, along with the reasons I hold them. If you are also importing vegan, which I think everyone agreed needs to happen, the only thing putting vegan in Depends does is attach the package. This is something u

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Gavin Simpson
Gabriel, That is not my understanding of this at all. I could hide the fact that I was using vegan under the hood, supplying methods for its generics and by exporting the generic I imported from vegan, etc. But you are missing the point that I see users of my package, because I envisioned close in

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Gabriel Becker
Gavin, I admit to not knowing the details of your package, but do users commonly need to use symbols from other package *in calls to functions exported by your package*? If so, you're in the situation Martin (Morgan) described, which is one I think everyone agrees Depends is appropriate for. If t

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Gavin Simpson
I fully agree. This is how I have come to understand Depends vs Imports and why I currently will not be removing vegan from Depends for my analogue package. This is also why I was pushing back against the notion that was voiced early in this thread that *nothing* should be in Depends. Cheers G

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Henrik Bengtsson
>From a developers point of view, these days a less ambiguous name for 'Depends' would be 'Attaches'. ...or maybe even 'ImportsAndAttaches' with 'ImportsOnly' (for 'Imports'). I think Simon phrased it very well, and as others already pointed out, having one package attaching additional ones certa

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Ravi Varadhan
nefit immensely. Thank you, Ravi -Original Message- From: r-devel-boun...@r-project.org [mailto:r-devel-boun...@r-project.org] On Behalf Of Bert Gunter Sent: Thursday, August 28, 2014 10:47 AM To: Simon Urbanek Cc: r-devel@r-project.org Subject: Re: [Rd] Re R CMD check checking in developme

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Bert Gunter
This is a nice explanation of the Imports/Depends distinction. It ought to go into the Extensions ref manual imho. Cheers, Bert Bert Gunter Genentech Nonclinical Biostatistics (650) 467-7374 "Data is not information. Information is not knowledge. And knowledge is certainly not wisdom." Clifford

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Simon Urbanek
On Aug 27, 2014, at 6:01 PM, Gavin Simpson wrote: > On 27 August 2014 15:24, Hadley Wickham wrote: > >>> Is that the cause of these NOTEs? Is the expectation that if I am using a >>> function from a package, even a package that I have in Depends:, that I >>> have to explicitly declare these im

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Martin Morgan
On 08/28/2014 05:52 AM, Hadley Wickham wrote: I'd say: Depends is a historical artefact from ye old days before package namespaces. Apart from depending on a specific version of R, you should basically never use depends. (The one exception is, as mentioned in R-exts, if you're writing something

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Hadley Wickham
>>> I'd say: Depends is a historical artefact from ye old days before >>> package namespaces. Apart from depending on a specific version of R, >>> you should basically never use depends. (The one exception is, as >>> mentioned in R-exts, if you're writing something like latticeExtras >>> that does

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Martin Morgan
On 08/27/2014 08:33 PM, Gavin Simpson wrote: On Aug 27, 2014 5:24 PM, "Hadley Wickham" I'd say: Depends is a historical artefact from ye old days before package namespaces. Apart from depending on a specific version of R, you should basically never use depends. (The one exception is, as mentio

Re: [Rd] Re R CMD check checking in development version of R

2014-08-28 Thread Barry Rowlingson
And if, like me, you always forget which of Depends and Imports is the one you are supposed to be using, the mnemonic device is "DEPends is DEPrecated[1], IMPorts is IMPortant." Barry [1] kinda. On Thu, Aug 28, 2014 at 4:33 AM, Gavin Simpson wrote: > On Aug 27, 2014 5:24 PM, "Hadley Wickham"

Re: [Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Gavin Simpson
On Aug 27, 2014 5:24 PM, "Hadley Wickham" > I'd say: Depends is a historical artefact from ye old days before > package namespaces. Apart from depending on a specific version of R, > you should basically never use depends. (The one exception is, as > mentioned in R-exts, if you're writing somethi

Re: [Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Hadley Wickham
On Wed, Aug 27, 2014 at 5:01 PM, Gavin Simpson wrote: > > On 27 August 2014 15:24, Hadley Wickham wrote: >> >> > Is that the cause of these NOTEs? Is the expectation that if I am using >> > a >> > function from a package, even a package that I have in Depends:, that I >> > have to explicitly decl

Re: [Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Gavin Simpson
On 27 August 2014 16:25, Uwe Ligges wrote: > Again, I am happy to be re-educated on this though :-) >> > > If you like, you can fill the search path with lots of packages (and make > masking of functions more likely), but you shoudl really import into your > namesoace so that unanticipated order

Re: [Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Uwe Ligges
On 28.08.2014 00:19, Gavin Simpson wrote: On 27 August 2014 16:09, Dan Tenenbaum wrote: - Original Message - From: "Gavin Simpson" To: "Hadley Wickham" Cc: r-devel@r-project.org Sent: Wednesday, August 27, 2014 3:01:53 PM Subject: Re: [Rd] Re R CMD check che

Re: [Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Gavin Simpson
On 27 August 2014 16:09, Dan Tenenbaum wrote: > - Original Message - > > From: "Gavin Simpson" > > To: "Hadley Wickham" > > Cc: r-devel@r-project.org > > Sent: Wednesday, August 27, 2014 3:01:53 PM > > Subject: Re: [Rd] Re R CMD che

Re: [Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Dan Tenenbaum
- Original Message - > From: "Gavin Simpson" > To: "Hadley Wickham" > Cc: r-devel@r-project.org > Sent: Wednesday, August 27, 2014 3:01:53 PM > Subject: Re: [Rd] Re R CMD check checking in development version of R > > On 27 August 2014 15:24

Re: [Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Gavin Simpson
On 27 August 2014 15:24, Hadley Wickham wrote: > > Is that the cause of these NOTEs? Is the expectation that if I am using a > > function from a package, even a package that I have in Depends:, that I > > have to explicitly declare these imports in NAMESPACE? > > Yes. > > (Otherwise your package

Re: [Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Hadley Wickham
> Is that the cause of these NOTEs? Is the expectation that if I am using a > function from a package, even a package that I have in Depends:, that I > have to explicitly declare these imports in NAMESPACE? Yes. (Otherwise your package won't work if it's only attached and not loaded. i.e. if some

[Rd] Re R CMD check checking in development version of R

2014-08-27 Thread Gavin Simpson
Dear list, This is related to the change discussed in the thread "no visible binding for global variables for data sets in a package". I went to look at the Check results for one of my packages (analogue) on CRAN: http://cran.r-project.org/web/checks/check_results_analogue.html Under the r-devel