Re: [Rd] [patch] add sanity checks to quantile()

2020-01-04 Thread Scott Kostyshak
On Sat, Jan 04, 2020 at 06:32:15PM -0500, Duncan Murdoch wrote: > > On 04/01/2020 4:35 p.m., Scott Kostyshak wrote: > > On Fri, May 31, 2019 at 01:28:55AM -0400, Scott Kostyshak wrote: > > > The attached patch adds some sanity checks to the "type" argument of > ... > > Bump. For this type of patch

Re: [Rd] [patch] add sanity checks to quantile()

2020-01-04 Thread Duncan Murdoch
On 04/01/2020 4:35 p.m., Scott Kostyshak wrote: On Fri, May 31, 2019 at 01:28:55AM -0400, Scott Kostyshak wrote: The attached patch adds some sanity checks to the "type" argument of ... Bump. For this type of patch proposal, is it better to use the bug tracker? For almost any patch proposal

Re: [Rd] [patch] add sanity checks to quantile()

2020-01-04 Thread Scott Kostyshak
On Fri, May 31, 2019 at 01:28:55AM -0400, Scott Kostyshak wrote: > The attached patch adds some sanity checks to the "type" argument of > quantile(). Output from the following commands show the change of > behavior with the current patch: > > vec <- 1:10 > quantile(vec, type = c(1, 2)) > qua

[Rd] [patch] add sanity checks to quantile()

2019-05-30 Thread Scott Kostyshak
The attached patch adds some sanity checks to the "type" argument of quantile(). Output from the following commands show the change of behavior with the current patch: vec <- 1:10 quantile(vec, type = c(1, 2)) quantile(vec, type = 10) quantile(vec, type = "aaa") quantile(vec, type = NA_r