Re: [Rd] Bias in R's random integers?

2018-09-21 Thread Steve Grubb
On Friday, September 21, 2018 5:28:38 PM EDT Ralf Stubner wrote: > On 9/21/18 6:38 PM, Tierney, Luke wrote: > > Not sure what should happen theoretically for the code in vseq.c, but > > I see the same pattern with the R generators I tried (default, > > Super-Duper, and L'Ecuyer) and with with bash

Re: [Rd] Bias in R's random integers?

2018-09-21 Thread Steve Grubb
On Friday, September 21, 2018 12:38:15 PM EDT Tierney, Luke wrote: > Not sure what should happen theoretically for the code in vseq.c, but > I see the same pattern with the R generators I tried (default, > Super-Duper, and L'Ecuyer) and with with bash $RANDOM using > > N <- 1 > X1 <- replicate

Re: [Rd] Bias in R's random integers?

2018-09-21 Thread Steve Grubb
der=T) qplot(X, Y, data=num.csv); Hope this helps sort this out. Best Regards, -Steve On Thursday, September 20, 2018 5:09:23 PM EDT Steve Grubb wrote: > On Thursday, September 20, 2018 11:15:04 AM EDT Duncan Murdoch wrote: > > On 20/09/2018 6:59 AM, Ralf Stubner wrote: > > > On

Re: [Rd] Bias in R's random integers?

2018-09-20 Thread Steve Grubb
Hello, On Thursday, September 20, 2018 11:15:04 AM EDT Duncan Murdoch wrote: > On 20/09/2018 6:59 AM, Ralf Stubner wrote: > > On 9/20/18 1:43 AM, Carl Boettiger wrote: > >> For a well-tested C algorithm, based on my reading of Lemire, the > >> unbiased "algorithm 3" in https://arxiv.org/abs/1805.1

Re: [Rd] Help to create bugzilla account

2017-08-13 Thread Steve Grubb
On Saturday, August 12, 2017 5:36:36 PM EDT Dirk Eddelbuettel wrote: > On 12 August 2017 at 15:10, luke-tier...@uiowa.edu wrote: > | As the Python posts poitns out, it is possible to use alternate malloc > | implementations, either rebuilding R to use them or using LD_PRELOAD. > | On Ubuntu for exa

Re: [Rd] [PATCH] Fix missing break

2017-07-21 Thread Steve Grubb
Hello Martin, On Friday, July 21, 2017 4:21:21 AM EDT Martin Maechler wrote: > I have now created an account for you. Thanks. Is that the preferred method of transferring these patches? > >> In examples like the one below, if you have R code that shows symptoms, > >> it would really help in the

Re: [Rd] [PATCH] Fix bad free in connections

2017-07-21 Thread Steve Grubb
On Friday, July 21, 2017 5:03:09 AM EDT Martin Morgan wrote: > b gets reallocated when > > res = vasprintf(&b, format, ap); > > is successful and res >= 0. usedVasprintf is then set to TRUE, and > free(b) called. > > It seems like the code is correct as written? Yes, I think I see the issu

Re: [Rd] [PATCH] Fix missing break

2017-07-20 Thread Steve Grubb
eople in core so they can see what the lay of the land looks like. R works amazingly good. So much so I decided to dig deeper. I'd recommend to the core developers that they ask to get on Coverity's open source scan list. https://scan.coverity.com/ It's free to open sour

[Rd] [PATCH] Fix status in main

2017-07-20 Thread Steve Grubb
Hello, This is a patch to fix what appears to be a simple typo. The warning says "invalid status assuming 0", but then instead sets runLast to 0. Signed-of-by: Steve Grubb Index: src/main/main.c === --- src/m

[Rd] [PATCH] Fix fscanf specifier in InIntegerAscii

2017-07-20 Thread Steve Grubb
Hello, The SMBUF_SIZED_STRING allows fscanf to read upto 511 bytes. The buffer at line 1382 is only 128 bytes. The fscanf format specifier ought to be resized to prevent a stack overrun. Signed-of-by: Steve Grubb Index: saveload.c

[Rd] [PATCH] Fix memory leak in PicTeXDeviceDriver

2017-07-20 Thread Steve Grubb
Hello, This patch fixes a memory leak due to ptd going out of scope before its assigned to dd. Signed-off-by: Steve Grubb Index: src/library/grDevices/src/devPicTeX.c === --- src/library/grDevices/src/devPicTeX.c (revision

[Rd] [PATCH] Fix bad free in connections

2017-07-20 Thread Steve Grubb
Hello, There are times when b points to buf which is a stack variable. This leads to a bad free. The current test actually guarantees the stack will try to get freed. Simplest to just drop the variable and directly test if b should get freed. Signed-off-by: Steve Grubb Index: src/main

[Rd] [PATCH] Fix missing break

2017-07-20 Thread Steve Grubb
Hello, There appears to be a break missing in the switch/case for the LISTSXP case. If this is supposed to fall through, I'd suggest a comment so that others know its by design. Signed-off-by: Steve Grubb Index: src/main/buil