Re: [Rd] [Bug Fix] Default values not applied to ... arguments

2017-07-07 Thread Sahil Kang
I'm glad I could help, and I look forward to reading your patch so that I can learn more about the R internals. It'd be nice to close this 4 year old bug. Sahil Original Message From: Tomas Kalibera Sent: July 7, 2017 11:10:05 AM PDT To: Sahil Kang Subject: Re:

Re: [Rd] [Bug Fix] Default values not applied to ... arguments

2017-07-07 Thread Sahil Kang
r. Note though that by disabling the JIT you won't disable the > byte-code interpreter, because code also gets compiled when packages > are installed or when the compiler is invoked explicitly. > > Best, > Tomas > > On 07/06/2017 04:40 PM, Sahil Kang wrote: >> Hi Du

[Rd] [Bug Fix] Default values not applied to ... arguments

2017-07-06 Thread Sahil Kang
Hi Duncan, Martin Here's a small patch that fixes bug 15199 reported at: https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=15199 I was able to reproduce the bug as Duncan had outlined just fine, but I did notice that when we debug(f), the problem went away. I later realized that f(1,,3) beha

Re: [Rd] SUGGESTION: Use JIRA for Bug Reporting, Package Development and Project Management

2017-06-08 Thread Sahil Kang
I enjoy the simplicity of a mailing list; I'd prefer not to create a new user account to participate in a software project. Plenty of other software communities utilize mailing lists, and I think you'll also begin to prefer email as you get more involved with software projects. R is also a GNU

Re: [Rd] [PATCH] Ensure correct order of evaluation in macro

2017-05-24 Thread Sahil Kang
Hi Martin, Would you feel comfortable merging my small patch in? I'd like to send additional patches that will improve these types of function macros so I'm hoping to start with this small change. Thanks, Sahil __ R-devel@r-project.org mailing list

Re: [Rd] [PATCH] Ensure correct order of evaluation in macro

2017-05-23 Thread Sahil Kang
Hi Duncan, Would you merge this patch? I'm planning on sending larger patches in the next few days that fix other macros I've seen, but I figured​ it'd be best to start with a smaller patch. Thanks, Sahil __ R-devel@r-project.org mailing list https://

[Rd] [PATCH] Ensure correct order of evaluation in macro

2017-05-22 Thread Sahil Kang
Hello, I'd like to contribute this small patch (attached) that I think will help prevent some future bugs from occurring in paste.c. By wrapping the macro's arguments in parentheses, we can ensure that the correct order of evaluation will take place during preprocessing. To illustrate, we can

Re: [Rd] [PATCH] Improve utf8clen and remove utf8_table4

2017-03-19 Thread Sahil Kang
cs. I feel that the new semantics provide a clearer interface though (the function expects a start byte and should return an error if a start byte is not supplied). In either case, the utf8_table4 array has been removed. Sahil On 03/19/2017 05:38 AM, Duncan Murdoch wrote: On 19/03/2017 2:31 AM,

[Rd] [PATCH] Improve utf8clen and remove utf8_table4

2017-03-19 Thread Sahil Kang
Given a char `c' which should be the start byte of a utf8 character, the utf8clen function returns the byte length of the utf8 character. Before this patch, the utf8clen function would return either: * 1 if `c' was an ascii character or a utf8 continuation byte * An int in the range [2, 6