[Rd] stats/HoltWinters.R inverted logic in seasonal in R and C

2025-01-03 Thread Norbert Kuder
Hello, I have noticed a potentially confusing implementation in the HoltWinters function regarding the seasonal parameter mapping between R and C code: https://github.com/wch/r-source/blob/4a1ed749271c52e60a85e794e6f34b0831efb1ae/src/library/stats/R/HoltWinters.R#L98 The C code interprets a season

[Rd] stats/ar.R issue - else branch never used

2025-01-03 Thread Norbert Kuder
Hello, There is another issue in stats/ar.R: https://github.com/wch/r-source/blob/4a1ed749271c52e60a85e794e6f34b0831efb1ae/src/library/stats/R/ar.R#L142 https://github.com/wch/r-source/blob/4a1ed749271c52e60a85e794e6f34b0831efb1ae/src/library/stats/R/ar.R#L429 https://github.com/wch/r-source/blob

Re: [Rd] Possible issue in stats/arima.R package

2025-01-03 Thread Martin Maechler
> Martin Maechler on Thu, 2 Jan 2025 20:42:58 +0100 writes: > Duncan Murdoch on Thu, 2 Jan 2025 11:28:45 -0500 writes: >> On 2025-01-02 11:20 a.m., Duncan Murdoch wrote: >>> On 2025-01-02 9:04 a.m., Norbert Kuder wrote: Hello all, I am running R versio

Re: [Rd] Possible issue in stats/arima.R package

2025-01-03 Thread Norbert Kuder
Martin, thank you solving this issue. Anyway there is the same bug in arima0.R: https://github.com/wch/r-source/blob/4a1ed749271c52e60a85e794e6f34b0831efb1ae/src/library/stats/R/arma0.R#L79 Best regards, Norbert Kuder czw., 2 sty 2025, 21:53 użytkownik Martin Maechler < maech...@stat.math.ethz.