Re: [Rd] logic tweak needed for as.data.frame. deprecation warning

2023-07-06 Thread Mikael Jagan
Another issue raised in the earlier thread is that as.data.frame.POSIXlt still calls as.data.frame.POSIXct. Hence another path to a false positive deprecation warning would be: > Sys.setenv("_R_CHECK_AS_DATA_FRAME_EXPLICIT_METHOD_" = TRUE) > as.data.frame(as.POSIXlt(.POSIXct(0, "UTC"))) as.POS

Re: [Rd] Warning 'as.data.frame.POSIXct()' is deprecated

2023-07-06 Thread Martin Maechler
> Tim Taylor > on Thu, 6 Jul 2023 15:11:41 +0100 writes: > Ah yes ... and reading the as.data.frame help we see (emphasis mine): > "... Direct calls to as.data.frame.() are still possible (*base > package!*), for 12 atomic base classes, but will deprecated ..." > So

[Rd] logic tweak needed for as.data.frame. deprecation warning

2023-07-06 Thread Mikael Jagan
Continuing the thread started on R-package-devel, here: https://stat.ethz.ch/pipermail/r-package-devel/2023q3/009307.html The logic of the now soft-deprecated as.data.frame., > body(as.data.frame.integer)[[2L]] if ((sys.nframe() <= 1L || sys.call(-1L)[[1L]] != quote(as.data.frame)) && nzchar

Re: [Rd] numeric_version doesn't like numeric versions anymore?

2023-07-06 Thread Sebastian Meyer
Please see for the background. The documentation has always said that the input needs to be a character vector. Implicit conversion of numeric input to character is affected by R options (OutDec and scipen), but it is also error-prone in this c