Re: [Rd] stats::fft produces inconsistent results

2021-10-20 Thread Dipterix Wang
Wow, you guys are amazing! >>> as part of its pipeline, ravetools::mvfftw computes the mean of the >>> input vector **and then centers it to a mean of zero** (intentionally or >>> accidentally?) > >>> because variables are passed to compiled code by reference (someone >>> can feel free to correct

Re: [Rd] Fwd: Using existing envars in Renviron on friendly Windows

2021-10-20 Thread Henrik Bengtsson
Two comments/suggestions: 1. What about recommending to always quote the value in Renviron files, e.g. ABC="Hello world" and DEF="${APPDATA}/R-library"? This should a practice that works on all platforms. 2. What about having readRenviron() escapes strings it imports via environment variables?

[Rd] as.list.factor() should shift input names onto the resulting list

2021-10-20 Thread Davis Vaughan
Hi all, The current implementation of as.list.factor() looks like: as.list.factor #> function (x, ...) #> { #> res <- vector("list", length(x)) #> for (i in seq_along(x)) res[[i]] <- x[i] #> res #> } #> #> I believe this is incorrect, as names of `x` are not shifted onto `res`. Thi

[Rd] BUG?: R CMD check with --as-cran *disables* checks for unused imports otherwise performed

2021-10-20 Thread Henrik Bengtsson
ISSUE: Using 'R CMD check' with --as-cran, set_R_CHECK_PACKAGES_USED_IGNORE_UNUSED_IMPORTS_=TRUE, whereas the default is FALSE, which you get if you don't add --as-cran. I would expect --as-cran to check more things and more be conservative than without. So, is this behavior a mistake? Could it

[Rd] R Contribution Working Group

2021-10-20 Thread Heather Turner
Dear All, The R Contribution Working Group was set up last year with the purpose of encouraging new contributors to R core, especially from currently under-represented groups. More detail here: https://forwards.github.io/rcontribution/working-group. The group has been meeting approximately onc

Re: [Rd] Fwd: Using existing envars in Renviron on friendly Windows

2021-10-20 Thread Michał Bojanowski
Hello Tomas, Yes, that's accurate although rather terse, which is perhaps the reason why I did not realize it applies to my case. How about adding something in the direction of: 1. Continuing the cited paragraph with: In particular, on Windows it may be necessary to quote references to existing

Re: [Rd] Environment setting _R_CHECK_DEPENDS_ONLY_='true'

2021-10-20 Thread Dirk Eddelbuettel
On 20 October 2021 at 09:31, Sebastian Meyer wrote: | If you set the environment variable inside a running R process, it will | only affect that process and child processes, but not an independent R | process launched from a shell like you seem to be doing here: Yes. That is somewhat common, i

Re: [Rd] stats::fft produces inconsistent results

2021-10-20 Thread Martin Maechler
> Martin Maechler > on Wed, 20 Oct 2021 11:26:21 +0200 writes: [] > Thank you, André , that's very good. > Just to state the obvious conclusion: > If Ben's suggestion is correct (and André has explained *how* > that could happen) this would mean a >

Re: [Rd] stats::fft produces inconsistent results

2021-10-20 Thread Martin Maechler
> GILLIBERT, Andre > on Wed, 20 Oct 2021 08:10:00 + writes: > Hello, > That sounds like a good diagnosis! > Indeed, R vectors are passed "by reference" to C code, but the semantic must be "by value", i.e. the C function must NOT change the contents of the vector, exc

Re: [Rd] stats::fft produces inconsistent results

2021-10-20 Thread GILLIBERT, Andre
Hello, That sounds like a good diagnosis! Indeed, R vectors are passed "by reference" to C code, but the semantic must be "by value", i.e. the C function must NOT change the contents of the vector, except in very specific cases. A good program that has to work on a vector, must first duplicate

Re: [Rd] Environment setting _R_CHECK_DEPENDS_ONLY_='true'

2021-10-20 Thread Sebastian Meyer
(this should have been posted to R-package-devel, not R-devel) Am 20.10.21 um 00:17 schrieb John Maindonald via R-devel: Setting Sys,setenv('_R_CHECK_DEPENDS_ONLY_'=‘true’) or Sys,setenv('_R_CHECK_DEPENDS_ONLY_’=TRUE) (either appear to be acceptable) appears to have no effect when I do, e.g.