[Rd] readBin should check that its endian argument is a legal value

2019-11-18 Thread Jennifer Lyon
I think it would be helpful if readBin checked that its endian argument is a legal value. Why? I was reviewing some of our code and noticed that the author had readBin(..., endian="network") and never having heard of "network", I looked at the man page for readBin, and it hadn't heard of "network"

Re: [Rd] Suggestion: Make _R_CHECK_LENGTH_1_LOGIC2_=warn the default for R 3.6.2

2019-11-18 Thread Henrik Bengtsson
On Mon, Nov 18, 2019 at 6:55 AM Tomas Kalibera wrote: > > On 11/18/19 3:44 PM, Henrik Bengtsson wrote: > > .On Mon, Nov 18, 2019 at 12:35 AM Martin Maechler > > wrote: > >>> Henrik Bengtsson > >>> on Sun, 17 Nov 2019 20:42:32 -0800 writes: > >> > Hi, > >> > >> > I'm not sur

Re: [Rd] Suggestion: Make _R_CHECK_LENGTH_1_LOGIC2_=warn the default for R 3.6.2

2019-11-18 Thread Tomas Kalibera
On 11/18/19 3:44 PM, Henrik Bengtsson wrote: .On Mon, Nov 18, 2019 at 12:35 AM Martin Maechler wrote: Henrik Bengtsson on Sun, 17 Nov 2019 20:42:32 -0800 writes: > Hi, > I'm not sure where we are in getting CRAN packages getting their > _R_CHECK_LENGTH_1_LOGIC2_=true bugs

Re: [Rd] Suggestion: Make _R_CHECK_LENGTH_1_LOGIC2_=warn the default for R 3.6.2

2019-11-18 Thread Henrik Bengtsson
.On Mon, Nov 18, 2019 at 12:35 AM Martin Maechler wrote: > > > Henrik Bengtsson > > on Sun, 17 Nov 2019 20:42:32 -0800 writes: > > > Hi, > > > I'm not sure where we are in getting CRAN packages getting their > > _R_CHECK_LENGTH_1_LOGIC2_=true bugs fixed (*), but maybe it'd

Re: [Rd] BUG?: A copy of base::`+` (primitive) is not a clone but a "pointer"

2019-11-18 Thread Tomas Kalibera
On 11/18/19 10:45 AM, Martin Maechler wrote: Tomas Kalibera on Mon, 18 Nov 2019 09:36:14 +0100 writes: > On 11/18/19 9:18 AM, Martin Maechler wrote: >>> Henrik Bengtsson >>> on Sun, 17 Nov 2019 14:31:07 -0800 writes: >> > $ R --vanilla R version 3.6.1 (2019-07-05

Re: [Rd] Inappropriate class(o)[!inherits(o,"AsIs")] in get_all_vars

2019-11-18 Thread Martin Maechler
> Martin Maechler > on Mon, 18 Nov 2019 12:15:38 +0100 writes: > suharto anggono--- via R-devel > on Sun, 17 Nov 2019 10:34:31 + writes: >> SVN revision 77401 changes >> x[isM] <- lapply(x[isM], function(o) `class<-`(o, class(o)[class(o) != "AsIs"])) >>

Re: [Rd] Inappropriate class(o)[!inherits(o,"AsIs")] in get_all_vars

2019-11-18 Thread Martin Maechler
> suharto anggono--- via R-devel > on Sun, 17 Nov 2019 10:34:31 + writes: > SVN revision 77401 changes > x[isM] <- lapply(x[isM], function(o) `class<-`(o, class(o)[class(o) != "AsIs"])) > to > x[isM] <- lapply(x[isM], function(o) `class<-`(o, clas

Re: [Rd] BUG?: A copy of base::`+` (primitive) is not a clone but a "pointer"

2019-11-18 Thread Martin Maechler
> Tomas Kalibera > on Mon, 18 Nov 2019 09:36:14 +0100 writes: > On 11/18/19 9:18 AM, Martin Maechler wrote: >>> Henrik Bengtsson >>> on Sun, 17 Nov 2019 14:31:07 -0800 writes: >> > $ R --vanilla R version 3.6.1 (2019-07-05) -- "Action of >> > the Toes" Copy

Re: [Rd] BUG?: A copy of base::`+` (primitive) is not a clone but a "pointer"

2019-11-18 Thread Tomas Kalibera
On 11/18/19 9:18 AM, Martin Maechler wrote: Henrik Bengtsson on Sun, 17 Nov 2019 14:31:07 -0800 writes: > $ R --vanilla R version 3.6.1 (2019-07-05) -- "Action of > the Toes" Copyright (C) 2019 The R Foundation for > Statistical Computing Platform: x86_64-pc-linux-gnu >

Re: [Rd] Suggestion: Make _R_CHECK_LENGTH_1_LOGIC2_=warn the default for R 3.6.2

2019-11-18 Thread Martin Maechler
> Henrik Bengtsson > on Sun, 17 Nov 2019 20:42:32 -0800 writes: > Hi, > I'm not sure where we are in getting CRAN packages getting their > _R_CHECK_LENGTH_1_LOGIC2_=true bugs fixed (*), but maybe it'd help to > make _R_CHECK_LENGTH_1_LOGIC2_=warn the new default in th

Re: [Rd] BUG?: A copy of base::`+` (primitive) is not a clone but a "pointer"

2019-11-18 Thread Martin Maechler
> Henrik Bengtsson > on Sun, 17 Nov 2019 14:31:07 -0800 writes: > $ R --vanilla R version 3.6.1 (2019-07-05) -- "Action of > the Toes" Copyright (C) 2019 The R Foundation for > Statistical Computing Platform: x86_64-pc-linux-gnu > (64-bit) ... >> str(base::`+`)