Re: [Rd] Change to r-devel warns on #pragma

2017-12-11 Thread Patrick Perry
Dear Mark, Thank you for the reply. I am not questioning the utility of compiler warnings in general. If you look at the code snippet, you can see that I am only disabling one warning ("-Wtype-limits"), in one line of code. This particular warning is spurious, so I want to ignore it, but I want

Re: [Rd] Change to r-devel warns on #pragma

2017-12-11 Thread Mark van der Loo
Hi Patrick, It was recently added as a cran policy (thanks Dirk's cran policy watch: https://twitter.com/markvdloo/status/935810241190617088). It seems to be a general stricter policy on keeping to the C(++) standard. Warnings are there for a reason and should usually not be ignored. I'm not fami

[Rd] document environment passing in parallel::parLapply

2017-12-11 Thread Gabe Newell
The runtime of parallel::parLapply depends on variables unrelated to the parLapply call. However, this is not clearly documented. Therefore I would like to suggest expanding the relevant documentation to explain this behaviour. Consider this example: parallel_demo <- function(random_values_count)

[Rd] Change to r-devel warns on #pragma

2017-12-11 Thread Patrick Perry
A recent change to r-devel causes an R CMD check warning when a C file includes a "#pragma GCC diagnostic ignored" pragma: https://github.com/wch/r-source/commit/b76c8fd355a0f5b23d42aaf44a879cac0fc31fa4 . This causes the CRAN checks for the "corpus" package to emit a warning: https://www.r-pro

Re: [Rd] possible bug in utils::removeSource - NULL argument is silently dropped

2017-12-11 Thread Martin Maechler
> Dénes Tóth > on Mon, 11 Dec 2017 11:39:38 +0100 writes: > Dear R-Core Team, > I found an unexpected behaviour in utils::removeSource (also present in > r-devel as of today). > --- > > # create a function which accepts NULL argument > foo <- function(x, y) { >if (i

[Rd] possible bug in utils::removeSource - NULL argument is silently dropped

2017-12-11 Thread Dénes Tóth
Dear R-Core Team, I found an unexpected behaviour in utils::removeSource (also present in r-devel as of today). --- # create a function which accepts NULL argument foo <- function(x, y) { if (is.null(y)) y <- "default foo" attr(x, "foo") <- y x } # create a function which utilizes 'foo