Re: [Rd] [New Patch] Fix disk corruption when writing

2017-07-07 Thread Duncan Murdoch
I have now committed changes to R-devel (rev 72898) that seem to catch large and small errors. They only give a warning if the error happens when the connection is closed, because that can happen asynchronously: I didn't want to mess up some later unrelated computation that triggered garbage c

[Rd] bug: deparse sometimes omits parentheses for unary operators

2017-07-07 Thread Binder, Martin
When turning a language object into a string (e.g. using dput, deparse, or just printing it), R usually inserts parentheses so that the printed string is an accurate representation of the underlying AST. Example (good): (expr = substitute(a * 10, list(a = quote(if (TRUE) 1 else 0 (if (TRU

Re: [Rd] [Bug Fix] Default values not applied to ... arguments

2017-07-07 Thread Sahil Kang
I'm glad I could help, and I look forward to reading your patch so that I can learn more about the R internals. It'd be nice to close this 4 year old bug. Sahil Original Message From: Tomas Kalibera Sent: July 7, 2017 11:10:05 AM PDT To: Sahil Kang Subject: Re: [Rd] [Bug Fi

Re: [Rd] make check-recommended hanging on up-to-date Rdevel from SVN

2017-07-07 Thread peter dalgaard
> On 6 Jul 2017, at 23:26 , Gabriel Becker wrote: > > Hi all, > > I'm getting an issue with Rdevel where make check-recommended hangs > consistently for me on Mac El Capitan when checking the Matrix package. I > did svn update and tools/rsync_recommended earlier today and it didn't fix > the is

Re: [Rd] italic font on cairo devices in R 3.4

2017-07-07 Thread frederik
On Fri, Jul 07, 2017 at 07:08:52PM +0200, Ilia Kats wrote: > Interesting. I did not have the package installed, but I did at some point > extract Helvetica from some MacOSX font files and R was using that just fine > until 3.3. This is how the plot looks in 3.4 (still using Helvetica): > https://pt

Re: [Rd] italic font on cairo devices in R 3.4

2017-07-07 Thread Ilia Kats
Interesting. I did not have the package installed, but I did at some point extract Helvetica from some MacOSX font files and R was using that just fine until 3.3. This is how the plot looks in 3.4 (still using Helvetica): https://ptpb.pw/HikX.pdf . After removing Helvetica, installing the ttf-m

Re: [Rd] italic font on cairo devices in R 3.4

2017-07-07 Thread frederik
Hi Ilia, I'm running Arch Linux, R 3.4.0. Here's my test.pdf from your minimal example: https://ptpb.pw/HxsA.pdf It doesn't look pixelated to me... Here's a post that I wrote when I solved my last font problem in R, almost 2 years ago: https://stackoverflow.com/a/40940331/5087283 I had to ins

Re: [Rd] [New Patch] Fix disk corruption when writing

2017-07-07 Thread Duncan Murdoch
On 07/07/2017 11:13 AM, Serguei Sokol wrote: Le 07/07/2017 à 16:52, Duncan Murdoch a écrit : On 07/07/2017 9:54 AM, Serguei Sokol wrote: Le 07/07/2017 à 01:09, Duncan Murdoch a écrit : On 06/07/2017 6:44 PM, Sokol Serguei wrote: Duncan Murdoch has written at Thu, 6 Jul 2017 13:58:10 -0400 O

Re: [Rd] [New Patch] Fix disk corruption when writing

2017-07-07 Thread Serguei Sokol
Le 07/07/2017 à 16:52, Duncan Murdoch a écrit : On 07/07/2017 9:54 AM, Serguei Sokol wrote: Le 07/07/2017 à 01:09, Duncan Murdoch a écrit : On 06/07/2017 6:44 PM, Sokol Serguei wrote: Duncan Murdoch has written at Thu, 6 Jul 2017 13:58:10 -0400 On 06/07/2017 5:21 AM, Serguei Sokol wrote: I

Re: [Rd] [New Patch] Fix disk corruption when writing

2017-07-07 Thread Duncan Murdoch
On 07/07/2017 9:54 AM, Serguei Sokol wrote: Le 07/07/2017 à 01:09, Duncan Murdoch a écrit : On 06/07/2017 6:44 PM, Sokol Serguei wrote: Duncan Murdoch has written at Thu, 6 Jul 2017 13:58:10 -0400 On 06/07/2017 5:21 AM, Serguei Sokol wrote: I propose the following patch against the current R

Re: [Rd] [New Patch] Fix disk corruption when writing

2017-07-07 Thread Serguei Sokol
Le 07/07/2017 à 01:09, Duncan Murdoch a écrit : On 06/07/2017 6:44 PM, Sokol Serguei wrote: Duncan Murdoch has written at Thu, 6 Jul 2017 13:58:10 -0400 On 06/07/2017 5:21 AM, Serguei Sokol wrote: I propose the following patch against the current R-devel/src/main/connection.c (cf. attached fi

Re: [Rd] attributes on symbols

2017-07-07 Thread Torsten Hothorn
Here is a simpler example: ex <- as.name("a") attr(ex, "test") <- 1 quote(a) a attr(,"test") [1] 1 Torsten On Thu, 6 Jul 2017, William Dunlap wrote: The multcomp package has code in multcomp:::expression2coef that attaches the 'coef' attribute to symbols.  Since there is only one symbol o

[Rd] italic font on cairo devices in R 3.4

2017-07-07 Thread Ilia Kats
[cross-post from R-help] Hi all, I have the following problem: Since R 3.4.0, italic fonts rendered on Cairo devices appear pixelated. Here's a minimal example: cairo_pdf('test.pdf') plot(1:10, ylab=expression(italic(test))) dev.off() The same problem occurs with bolditalic, but not bold. I a

Re: [Rd] [Bug Fix] Default values not applied to ... arguments

2017-07-07 Thread Sahil Kang
Yes, I see what you mean. My patch only disables JIT compilation for closures. If a user manually compiles a closure, however, the bug pops up again. I think the bug may either lie in how the byte-compiler compiles closures, or how closures with compiled body's are executed by the AST interpre