Re: [Rd] The regular expressions in compareVersion()

2014-04-24 Thread Simon Urbanek
FWIW the link has a long thread that is 90% irrelevant - AFAICS the relevant part is From: Yihui Xie-2 Sep 02, 2013; 4:11pm Re: Sweave: printing an underscore in the output from an R command [...] Now you are good at the regular expression level, but Sweave comes and bites you, and that is due t

Re: [Rd] The regular expressions in compareVersion()

2014-04-24 Thread Yihui Xie
You are right that this is unlikely to cause problems, because users are unlikely to put backslashes in version numbers. Henrik has pointed out the problem. It is not about "making the source code a little cleaner", but "making it correct". Either someone in R core corrects the wrong regular expres

Re: [Rd] palette() can hang and fail due to X11

2014-04-24 Thread Simon Urbanek
Andrew, palette is a property recorded in the graphics device* and therefore R will create a new device (see dev.new()) if only the null device is open. Which device is really up to your settings, so you could adjust your preferred device depending on what you want it to be. The bottom line is

Re: [Rd] palette() can hang and fail due to X11

2014-04-24 Thread Andrew Piskorski
The fundamental problem here seems to be a change (probably a bug) in the behavior of palette(). In R 3.1.0, calling palette() opens a new X window (on Linux)! That seems like a bug, as I can't think of any good reason for it to open a window, and it never did in any of the 2.x versions of R I've

Re: [Rd] The regular expressions in compareVersion()

2014-04-24 Thread Duncan Murdoch
On 24/04/2014, 5:26 PM, Henrik Bengtsson wrote: On Thu, Apr 24, 2014 at 1:42 PM, Duncan Murdoch wrote: On 24/04/2014, 1:11 PM, Yihui Xie wrote: Hi, I guess the backslash should not be used as the separator for strsplit() in compareVersion(), because the period in [.] is no longer a metachara

Re: [Rd] The regular expressions in compareVersion()

2014-04-24 Thread Henrik Bengtsson
On Thu, Apr 24, 2014 at 1:42 PM, Duncan Murdoch wrote: > On 24/04/2014, 1:11 PM, Yihui Xie wrote: >> >> Hi, >> >> I guess the backslash should not be used as the separator for >> strsplit() in compareVersion(), because the period in [.] is no longer >> a metacharacter (no need to "escape" it using

Re: [Rd] The regular expressions in compareVersion()

2014-04-24 Thread Duncan Murdoch
On 24/04/2014, 1:11 PM, Yihui Xie wrote: Hi, I guess the backslash should not be used as the separator for strsplit() in compareVersion(), because the period in [.] is no longer a metacharacter (no need to "escape" it using a backslash): https://github.com/wch/r-source/blob/trunk/src/library/uti

[Rd] palette() can hang and fail due to X11

2014-04-24 Thread Andrew Piskorski
For many years, when my R process starts up I've been automatically setting my preferred default plot colors, basically like so: my.colors <- c("black" ,"red" ,"gold" ,"sky blue" ,"green" ,"blue" ,"orange" ,"grey" ,"hot pink" ,"brown" ,"sea green" ,"cyan" ,"purple" ,"tomato1") requ

[Rd] The regular expressions in compareVersion()

2014-04-24 Thread Yihui Xie
Hi, I guess the backslash should not be used as the separator for strsplit() in compareVersion(), because the period in [.] is no longer a metacharacter (no need to "escape" it using a backslash): https://github.com/wch/r-source/blob/trunk/src/library/utils/R/packages.R#L866-L867 > compareVersion