Re: [PATCH v4] smb daemon get additional command line parameters from env variable

2019-11-02 Thread Samuel Thibault
Jordi Pujol, le sam. 02 nov. 2019 08:41:52 +0100, a ecrit: > @@ -909,6 +910,12 @@ static int slirp_smb(SlirpState* s, cons > CONFIG_SMBD_COMMAND, s->smb_dir, smb_conf); > g_free(smb_conf); > > +options = g_getenv("SMBDOPTIONS"); > +if (options) { > +smb_cmdline =

Re: [PATCH v4] smb daemon get additional command line parameters from env variable

2019-11-02 Thread Jordi Pujol
From: Jordi Pujol Palomer Date: Sat, 2 Nov 2019 08:54:14 +0200 Subject: [PATCH v4] QEMU samba daemon: additional command line options The smbd daemon takes additional command line options from environment variable SMBDOPTIONS. Set the environment variable SMBDOPTIONS before executing qemu. Examp

Re: [PATCH v3] smb daemon get additional command line parameters from env variable

2019-11-01 Thread Samuel Thibault
Jordi Pujol, le ven. 01 nov. 2019 15:38:19 +0100, a ecrit: > +options = g_getenv("SMBDOPTIONS"); > +if (options) { > +smb_cmdline = g_strdup_printf("%s %s", smb_cmdline, options); > +} > +g_free(options); But then do not free it :) Samuel

Re: [PATCH v3] smb daemon get additional command line parameters from env variable

2019-11-01 Thread Jordi Pujol
On Thu, Oct 31, 2019 at 11:50 PM Samuel Thibault wrote: > Why strduping it? you can just use g_getenv. ACK, I have also placed the variable declaration after the others. Here is the v3 of this patch. ** From: Jordi Pujol Palomer Da

Re: [PATCH v2] smb daemon get additional command line parameters from env variable

2019-10-31 Thread Samuel Thibault
Hello, Jordi Pujol, le jeu. 31 oct. 2019 14:33:00 +0100, a ecrit: > The smbd daemon takes additional command line options > from environment variable SMBDOPTIONS. > Set the environment variable SMBDOPTIONS before executing qemu. > > Example: > > export SMBDOPTIONS="--option='server min protocol=

Re: [PATCH v2] smb daemon get additional command line parameters from env variable

2019-10-31 Thread Jordi Pujol
Hello, Many thanks Laurent, This is the version 2 of this patch, has been modified according to the qemu guidelines. ** From: Jordi Pujol Palomer Date: Thu, 31 Oct 2019 14:31:14 +0200 Subject: [PATCH v2] QEMU samba daemon: additional command line

Re: smb daemon get additional command line parameters from env variable

2019-10-31 Thread Laurent Vivier
Hi, On 30/10/2019 08:55, Jordi Pujol wrote: > Hello, > > The new version 4 of Samba disables version 1 SMB protocols, now to > run old Win clients we must modify the temporary configuration of the > samba daemon to enable protocols before starting the samba client. > This patch gets the value of