Re: qemu-sockets: account for trailing \0 byte in unix socket pathname

On Tue, Aug 31, 2021 at 08:47:43PM +0300, Michael Tokarev wrote: > 31.08.2021 20:38, Daniel P. Berrangé wrote: > ... > > > > So it looks like libvirt provides an unnamed socket there, -- > > > > maybe from a socketpair(2)? > > > > > > > > > > Yes > > > > No, libvirt binds to a named socket path

Re: qemu-sockets: account for trailing \0 byte in unix socket pathname

31.08.2021 20:38, Daniel P. Berrangé wrote: ... So it looks like libvirt provides an unnamed socket there, -- maybe from a socketpair(2)? Yes No, libvirt binds to a named socket path and passes in a pre-opened FD for the listener socket. There shouldn't be any socketpair involved. Here's s

Re: qemu-sockets: account for trailing \0 byte in unix socket pathname

On Tue, Aug 31, 2021 at 09:22:01PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Aug 31, 2021 at 9:17 PM Michael Tokarev wrote: > > > 31.08.2021 01:54, Michael Tokarev wrote: > > > Linux kernel can return size of af_unix socket to be > > > one byte larger than sockaddr_un structure - adding >

Re: qemu-sockets: account for trailing \0 byte in unix socket pathname

Hi On Tue, Aug 31, 2021 at 9:17 PM Michael Tokarev wrote: > 31.08.2021 01:54, Michael Tokarev wrote: > > Linux kernel can return size of af_unix socket to be > > one byte larger than sockaddr_un structure - adding > > the trailing zero byte. > > > > Signed-off-by: Michael Tokarev > > Fixes: 4cf

Re: qemu-sockets: account for trailing \0 byte in unix socket pathname

31.08.2021 01:54, Michael Tokarev wrote: Linux kernel can return size of af_unix socket to be one byte larger than sockaddr_un structure - adding the trailing zero byte. Signed-off-by: Michael Tokarev Fixes: 4cfd970ec188558daa6214f26203fe553fb1e01f (first in 6.1.0) Cc: qemu-sta...@nongnu.org d

Re: qemu-sockets: account for trailing \0 byte in unix socket pathname

On Tue, Aug 31, 2021 at 04:32:36PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Aug 31, 2021 at 3:00 AM Michael Tokarev wrote: > > > Linux kernel can return size of af_unix socket to be > > one byte larger than sockaddr_un structure - adding > > the trailing zero byte. > > > > Signed-off-by:

Re: qemu-sockets: account for trailing \0 byte in unix socket pathname

Hi On Tue, Aug 31, 2021 at 3:00 AM Michael Tokarev wrote: > Linux kernel can return size of af_unix socket to be > one byte larger than sockaddr_un structure - adding > the trailing zero byte. > > Signed-off-by: Michael Tokarev > Fixes: 4cfd970ec188558daa6214f26203fe553fb1e01f (first in 6.1.0)

qemu-sockets: account for trailing \0 byte in unix socket pathname

Linux kernel can return size of af_unix socket to be one byte larger than sockaddr_un structure - adding the trailing zero byte. Signed-off-by: Michael Tokarev Fixes: 4cfd970ec188558daa6214f26203fe553fb1e01f (first in 6.1.0) Cc: qemu-sta...@nongnu.org diff --git a/util/qemu-sockets.c b/util/qemu