Re: qemu-binfmt-conf.sh: enforce style consistency

2021-06-22 Thread Laurent Vivier
Le 20/06/2021 à 23:22, Unai Martinez Corral a écrit : > Hi Laurent, > > Well, I'm not sure there is a real consistency with this in the other > scripts... > > > Changes look good, but can someone confirm this is the style we want to > use everywhere? > > Peter?  > > > Please, se

Re: qemu-binfmt-conf.sh: enforce style consistency

2021-06-20 Thread Unai Martinez Corral
Hi Laurent, Well, I'm not sure there is a real consistency with this in the other > scripts... > Changes look good, but can someone confirm this is the style we want to use > everywhere? > > Peter? > Please, see https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg02267.html > Please use y

Re: qemu-binfmt-conf.sh: enforce style consistency

2021-06-20 Thread Laurent Vivier
Le 20/06/2021 à 22:15, umarcor a écrit : > Spaces are removed before '; then', for consistency with other scripts > in the project. Well, I'm not sure there is a real consistency with this in the other scripts... > Signed-off-by: umarcor Please use your real name, not a nickname. Changes look

qemu-binfmt-conf.sh: enforce style consistency

2021-06-20 Thread umarcor
Spaces are removed before '; then', for consistency with other scripts in the project. Signed-off-by: umarcor --- scripts/qemu-binfmt-conf.sh | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binf

Re: [PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency

2020-03-10 Thread Laurent Vivier
Le 09/03/2020 à 20:36, Unai Martinez Corral a écrit : > 2020/3/9 20:30, Eric Blake: > > On 3/9/20 2:18 PM, Unai Martinez-Corral wrote: > > Spaces are removed before '; then', for consistency with other scripts > > in the project. > > > > Signed-off-by: Unai Martinez-Corral >

Re: [PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency

2020-03-09 Thread Unai Martinez Corral
2020/3/9 20:30, Eric Blake: > On 3/9/20 2:18 PM, Unai Martinez-Corral wrote: > > Spaces are removed before '; then', for consistency with other scripts > > in the project. > > > > Signed-off-by: Unai Martinez-Corral > > Reviewed-by: Laurent Vivier > > Technically, since this change is different

Re: [PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency

2020-03-09 Thread Eric Blake
On 3/9/20 2:18 PM, Unai Martinez-Corral wrote: Spaces are removed before '; then', for consistency with other scripts in the project. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier Technically, since this change is different than what Laurent previously reviewed, it might h

[PATCH v10 01/10] qemu-binfmt-conf.sh: enforce style consistency

2020-03-09 Thread Unai Martinez-Corral
Spaces are removed before '; then', for consistency with other scripts in the project. Signed-off-by: Unai Martinez-Corral Reviewed-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/scripts