Re: plugins: Missing Store Exclusive Memory Accesses

2021-10-22 Thread Alex Bennée
Aaron Lindsay writes: > On Oct 21 13:28, Alex Bennée wrote: >> It's a bit clearer if you use the contrib/execlog plugin: >> >> ./qemu-aarch64 -plugin contrib/plugins/libexeclog.so -d plugin >> ./tests/tcg/aarch64-linux-user/stxp >> >> 0, 0x400910, 0xf9800011, "prfm pstl1strm, [x0] >>

Re: plugins: Missing Store Exclusive Memory Accesses

2021-10-21 Thread Aaron Lindsay via
On Oct 21 13:28, Alex Bennée wrote: > It's a bit clearer if you use the contrib/execlog plugin: > > ./qemu-aarch64 -plugin contrib/plugins/libexeclog.so -d plugin > ./tests/tcg/aarch64-linux-user/stxp > > 0, 0x400910, 0xf9800011, "prfm pstl1strm, [x0] > 0, 0x400914, 0xc87f4410, "ldxp x16,

Re: plugins: Missing Store Exclusive Memory Accesses

2021-10-21 Thread Alex Bennée
Aaron Lindsay writes: > On Oct 20 18:54, Alex Bennée wrote: >> Have you got a test case you are using so I can try and replicate the >> failure you are seeing? So far by inspection everything looks OK to me. > > I took some time today to put together a minimal(ish) reproducer using > usermode.

Re: plugins: Missing Store Exclusive Memory Accesses

2021-10-20 Thread Aaron Lindsay via
On Oct 20 18:54, Alex Bennée wrote: > Have you got a test case you are using so I can try and replicate the > failure you are seeing? So far by inspection everything looks OK to me. I took some time today to put together a minimal(ish) reproducer using usermode. The source files used are below, I

Re: plugins: Missing Store Exclusive Memory Accesses

2021-10-20 Thread Alex Bennée
Aaron Lindsay writes: > On Sep 22 16:22, Aaron Lindsay wrote: >> On Sep 21 16:28, Aaron Lindsay wrote: >> > On Sep 17 12:05, Alex Bennée wrote: >> > > Aaron Lindsay writes: >> > > > I recently noticed that the plugin interface does not appear to be >> > > > emitting callbacks to functions regi

Re: plugins: Missing Store Exclusive Memory Accesses

2021-10-20 Thread Aaron Lindsay via
On Sep 22 16:22, Aaron Lindsay wrote: > On Sep 21 16:28, Aaron Lindsay wrote: > > On Sep 17 12:05, Alex Bennée wrote: > > > Aaron Lindsay writes: > > > > I recently noticed that the plugin interface does not appear to be > > > > emitting callbacks to functions registered via > > > > `qemu_plugin_r

Re: plugins: Missing Store Exclusive Memory Accesses

2021-09-22 Thread Aaron Lindsay via
On Sep 21 16:28, Aaron Lindsay wrote: > On Sep 17 12:05, Alex Bennée wrote: > > Aaron Lindsay writes: > > > I recently noticed that the plugin interface does not appear to be > > > emitting callbacks to functions registered via > > > `qemu_plugin_register_vcpu_mem_cb` for AArch64 store exclusives.

Re: plugins: Missing Store Exclusive Memory Accesses

2021-09-21 Thread Aaron Lindsay via
On Sep 17 12:05, Alex Bennée wrote: > Aaron Lindsay writes: > > I recently noticed that the plugin interface does not appear to be > > emitting callbacks to functions registered via > > `qemu_plugin_register_vcpu_mem_cb` for AArch64 store exclusives. This > > would include instructions like `stxp

Re: plugins: Missing Store Exclusive Memory Accesses

2021-09-17 Thread Aaron Lindsay via
On Sep 17 12:05, Alex Bennée wrote: > Aaron Lindsay writes: > > In looking at QEMU's source, I *think* this is because the > > `gen_store_exclusive` function in translate-a64.c is not making the same > > calls to `plugin_gen_mem_callbacks` & company that are being made by > > "normal" stores handl

Re: plugins: Missing Store Exclusive Memory Accesses

2021-09-17 Thread Alex Bennée
Aaron Lindsay writes: > Hello, > > I recently noticed that the plugin interface does not appear to be > emitting callbacks to functions registered via > `qemu_plugin_register_vcpu_mem_cb` for AArch64 store exclusives. This > would include instructions like `stxp w16, x2, x3, [x4]` (encoding: >

plugins: Missing Store Exclusive Memory Accesses

2021-09-16 Thread Aaron Lindsay
Hello, I recently noticed that the plugin interface does not appear to be emitting callbacks to functions registered via `qemu_plugin_register_vcpu_mem_cb` for AArch64 store exclusives. This would include instructions like `stxp w16, x2, x3, [x4]` (encoding: 0xc8300c82). Seeing as how I'm only ru