Re: iotests and python dependencies

2022-05-10 Thread John Snow
On Thu, May 5, 2022 at 5:28 AM Paolo Bonzini wrote: > > On 5/5/22 10:51, Kevin Wolf wrote: > > If not, I guess it would be enough if iotests just checks that the venv > > exists and all of the dependencies are there in the right version and > > error out if not, telling the user to run 'make check

Re: iotests and python dependencies

2022-05-08 Thread Paolo Bonzini
If we want to provide an installable rpm in Fedora then yes; but we can leave distribution to pypi and use a bundled copy in the virtual environment that is used to run tests. Paolo Il 5 maggio 2022 17:57:24 CEST, "Daniel P. Berrangé" ha scritto: >On Thu, May 05, 2022 at 05:50:00PM +0200, Pao

Re: iotests and python dependencies

2022-05-05 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 05:50:00PM +0200, Paolo Bonzini wrote: > On 5/5/22 16:13, John Snow wrote: > > > > I would rather keep python/qemu/qmp as a submodule for a longer time, > > and still go through a virtual environment that installs it together > > with its pip dependencies. > >

Re: iotests and python dependencies

2022-05-05 Thread Paolo Bonzini
On 5/5/22 16:13, John Snow wrote: I would rather keep python/qemu/qmp as a submodule for a longer time, and still go through a virtual environment that installs it together with its pip dependencies. A small headache relating fixes to both locations, but if you'd like to see it to

Re: iotests and python dependencies

2022-05-05 Thread John Snow
On Thu, May 5, 2022, 9:16 AM Paolo Bonzini wrote: > On 5/5/22 15:10, John Snow wrote: > > > > > Hm, do we need iotests during an rpm build? Is it because of > > "make check"? > > > > Yes, and this is good, because it prevents us from outputting an > > RPM build that has a broken

Re: iotests and python dependencies

2022-05-05 Thread Paolo Bonzini
On 5/5/22 15:10, John Snow wrote: > Hm, do we need iotests during an rpm build? Is it because of "make check"? Yes, and this is good, because it prevents us from outputting an RPM build that has a broken QEMU in it. Guess this means I need to make a Fedora package too, though.

Re: iotests and python dependencies

2022-05-05 Thread John Snow
On Thu, May 5, 2022, 8:33 AM Daniel P. Berrangé wrote: > On Thu, May 05, 2022 at 08:08:42AM -0400, John Snow wrote: > > On Thu, May 5, 2022, 4:09 AM Daniel P. Berrangé > wrote: > > > > > On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote: > > > > Howdy! > > > > > > > > So, I want to final

Re: iotests and python dependencies

2022-05-05 Thread Daniel P . Berrangé
On Thu, May 05, 2022 at 08:08:42AM -0400, John Snow wrote: > On Thu, May 5, 2022, 4:09 AM Daniel P. Berrangé wrote: > > > On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote: > > > Howdy! > > > > > > So, I want to finally delete python/qemu/qmp from qemu.git, and this > > > creates a small

Re: iotests and python dependencies

2022-05-05 Thread Kevin Wolf
Am 05.05.2022 um 14:24 hat Paolo Bonzini geschrieben: > On 5/5/22 12:59, Kevin Wolf wrote: > > Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben: > > > > Or actually, it could just unconditionally run 'make check-venv' by > > > > itself, which is probably easier to implement than checking the >

Re: iotests and python dependencies

2022-05-05 Thread Paolo Bonzini
On 5/5/22 12:59, Kevin Wolf wrote: Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben: Or actually, it could just unconditionally run 'make check-venv' by itself, which is probably easier to implement than checking the dependencies and more convenient for the user, too. One small complicatio

Re: iotests and python dependencies

2022-05-05 Thread John Snow
On Thu, May 5, 2022, 4:09 AM Daniel P. Berrangé wrote: > On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote: > > Howdy! > > > > So, I want to finally delete python/qemu/qmp from qemu.git, and this > > creates a small problem -- namely, iotests needs access to it in order > > to run the pyt

Re: iotests and python dependencies

2022-05-05 Thread John Snow
On Thu, May 5, 2022, 4:51 AM Kevin Wolf wrote: > Am 04.05.2022 um 21:38 hat John Snow geschrieben: > > Howdy! > > > > So, I want to finally delete python/qemu/qmp from qemu.git, and this > > creates a small problem -- namely, iotests needs access to it in order > > to run the python-based tests.

Re: iotests and python dependencies

2022-05-05 Thread Kevin Wolf
Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben: > On 5/5/22 10:51, Kevin Wolf wrote: > > If not, I guess it would be enough if iotests just checks that the venv > > exists and all of the dependencies are there in the right version and > > error out if not, telling the user to run 'make check-

Re: iotests and python dependencies

2022-05-05 Thread Paolo Bonzini
On 5/5/22 10:51, Kevin Wolf wrote: If not, I guess it would be enough if iotests just checks that the venv exists and all of the dependencies are there in the right version and error out if not, telling the user to run 'make check-venv'. Or actually, it could just unconditionally run 'make check

Re: iotests and python dependencies

2022-05-05 Thread Kevin Wolf
Am 04.05.2022 um 21:38 hat John Snow geschrieben: > Howdy! > > So, I want to finally delete python/qemu/qmp from qemu.git, and this > creates a small problem -- namely, iotests needs access to it in order > to run the python-based tests. > > What I think needs to happen is that we create a virtua

Re: iotests and python dependencies

2022-05-05 Thread Daniel P . Berrangé
On Wed, May 04, 2022 at 03:38:45PM -0400, John Snow wrote: > Howdy! > > So, I want to finally delete python/qemu/qmp from qemu.git, and this > creates a small problem -- namely, iotests needs access to it in order > to run the python-based tests. > > What I think needs to happen is that we create

iotests and python dependencies

2022-05-04 Thread John Snow
Howdy! So, I want to finally delete python/qemu/qmp from qemu.git, and this creates a small problem -- namely, iotests needs access to it in order to run the python-based tests. What I think needs to happen is that we create a virtual environment that installs python/qemu/. The reason this cannot