Re: hw/net/rocker: Dubious code in tx_consume()

2020-02-15 Thread Jiri Pirko
Sat, Feb 15, 2020 at 02:15:22PM CET, phi...@redhat.com wrote: >Hi Jiri, > >I am trying to understand this code Scott Feldman added in commit >dc488f88806: > > 157 static int tx_consume(Rocker *r, DescInfo *info) > 158 { > ... > 212 if (tlvs[ROCKER_TLV_TX_TSO_MSS]) { > 213 tx_tso_mss = r

hw/net/rocker: Dubious code in tx_consume()

2020-02-15 Thread Philippe Mathieu-Daudé
Hi Jiri, I am trying to understand this code Scott Feldman added in commit dc488f88806: 157 static int tx_consume(Rocker *r, DescInfo *info) 158 { ... 212 if (tlvs[ROCKER_TLV_TX_TSO_MSS]) { 213 tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]); 214 } ... 252