Re: [PATCH 4/7] scripts/device-crash-test: Remove legacy '-machine foo,accel=bar'

2024-12-03 Thread Daniel P . Berrangé
On Tue, Dec 03, 2024 at 10:21:50AM +0100, Philippe Mathieu-Daudé wrote: > Since commit 6f6e1698a68 ("vl: configure accelerators from -accel > options") we prefer the '-accel bar' command line option. > > Replace '-machine foo,accel=bar' -> '-

[PATCH 4/7] scripts/device-crash-test: Remove legacy '-machine foo, accel=bar'

2024-12-03 Thread Philippe Mathieu-Daudé
Since commit 6f6e1698a68 ("vl: configure accelerators from -accel options") we prefer the '-accel bar' command line option. Replace '-machine foo,accel=bar' -> '-machine foo -accel bar' in the device-crash-test script. Signed-off-by: Philippe Mathie

[Stable-7.2.4 01/43] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs

2023-06-26 Thread Michael Tokarev
by disabling the up-to-date check via NINJA=":". Fixes: 1d8cf47e5b ("tests: run 'device-crash-test' from tests/venv") Signed-off-by: Thomas Huth Message-Id: <20230414145845.456145-2-th...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20230424092249

[Stable-7.2.4 02/43] scripts/device-crash-test: Add a parameter to run with TCG only

2023-06-26 Thread Michael Tokarev
From: Thomas Huth We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an option to the script that allows to run it

[Stable-8.0.3 01/54] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs

2023-06-26 Thread Michael Tokarev
by disabling the up-to-date check via NINJA=":". Fixes: 1d8cf47e5b ("tests: run 'device-crash-test' from tests/venv") Signed-off-by: Thomas Huth Message-Id: <20230414145845.456145-2-th...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20230424092249

[Stable-8.0.3 02/54] scripts/device-crash-test: Add a parameter to run with TCG only

2023-06-26 Thread Michael Tokarev
From: Thomas Huth We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an option to the script that allows to run it

[PULL 05/18] scripts/device-crash-test: Add a parameter to run with TCG only

2023-04-27 Thread Alex Bennée
From: Thomas Huth We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an option to the script that allows to run it

[PULL 04/18] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs

2023-04-27 Thread Alex Bennée
by disabling the up-to-date check via NINJA=":". Fixes: 1d8cf47e5b ("tests: run 'device-crash-test' from tests/venv") Signed-off-by: Thomas Huth Message-Id: <20230414145845.456145-2-th...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20230424092249

[PATCH 04/18] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs

2023-04-24 Thread Alex Bennée
by disabling the up-to-date check via NINJA=":". Fixes: 1d8cf47e5b ("tests: run 'device-crash-test' from tests/venv") Signed-off-by: Thomas Huth Message-Id: <20230414145845.456145-2-th...@redhat.com> Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.ym

[PATCH 05/18] scripts/device-crash-test: Add a parameter to run with TCG only

2023-04-24 Thread Alex Bennée
From: Thomas Huth We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an option to the script that allows to run it

Re: [PATCH v4 5/6] scripts/device-crash-test: Add a parameter to run with TCG only

2023-04-20 Thread Philippe Mathieu-Daudé
On 17/4/23 15:43, Alex Bennée wrote: From: Thomas Huth We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an opti

[PATCH v4 4/6] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs

2023-04-17 Thread Alex Bennée
by disabling the up-to-date check via NINJA=":". Fixes: 1d8cf47e5b ("tests: run 'device-crash-test' from tests/venv") Signed-off-by: Thomas Huth Message-Id: <20230414145845.456145-2-th...@redhat.com> Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.ym

[PATCH v4 5/6] scripts/device-crash-test: Add a parameter to run with TCG only

2023-04-17 Thread Alex Bennée
From: Thomas Huth We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an option to the script that allows to run it

Re: [PATCH 0/2] Improvements for the device-crash-test jobs

2023-04-17 Thread Alex Bennée
Thomas Huth writes: > Improve the runtime of the device-crash-test jobs by avoiding > to run "configure" again and by forcing to test with TCG only > (instead of testing twice, with TCG and KVM). Queued to testing/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 1/2] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs

2023-04-14 Thread Thomas Huth
up-to-date check via NINJA=":". Fixes: 1d8cf47e5b ("tests: run 'device-crash-test' from tests/venv") Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitl

[PATCH 0/2] Improvements for the device-crash-test jobs

2023-04-14 Thread Thomas Huth
Improve the runtime of the device-crash-test jobs by avoiding to run "configure" again and by forcing to test with TCG only (instead of testing twice, with TCG and KVM). Thomas Huth (2): gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs scripts/devi

[PATCH 2/2] scripts/device-crash-test: Add a parameter to run with TCG only

2023-04-14 Thread Thomas Huth
We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an option to the script that allows to run it with TCG only. Report

[PULL 26/29] tests: run 'device-crash-test' from tests/venv

2022-06-06 Thread Paolo Bonzini
From: John Snow Remove the sys.path hacking from device-crash-test, and add in a little user-friendly message for anyone who was used to running this script directly from the source tree. Modify the GitLab job recipes to create the tests/venv first, then run device-crash-test from that venv

Re: [PATCH 9/9] tests: run 'device-crash-test' from tests/venv

2022-05-26 Thread John Snow
On Thu, May 26, 2022, 8:14 AM Paolo Bonzini wrote: > On 5/26/22 02:09, John Snow wrote: > > Remove the sys.path hacking from device-crash-test, and add in a little > > user-friendly message for anyone who was used to running this script > > directly from the source tre

Re: [PATCH 9/9] tests: run 'device-crash-test' from tests/venv

2022-05-26 Thread Paolo Bonzini
On 5/26/22 02:09, John Snow wrote: Remove the sys.path hacking from device-crash-test, and add in a little user-friendly message for anyone who was used to running this script directly from the source tree. Modify the GitLab job recipes to create the tests/venv first, then run device-crash-test

[PATCH 9/9] tests: run 'device-crash-test' from tests/venv

2022-05-25 Thread John Snow
Remove the sys.path hacking from device-crash-test, and add in a little user-friendly message for anyone who was used to running this script directly from the source tree. Modify the GitLab job recipes to create the tests/venv first, then run device-crash-test from that venv. Signed-off-by: John

[PATCH v5 43/43] scripts/device-crash-test: Add exception for pxb-cxl

2022-02-02 Thread Jonathan Cameron via
scripts/device-crash-test | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 7fbd99158b..52bd3d8f71 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -93,6 +93,7 @@ ERROR_RULE_LIST = [ {'device':&

[PULL 10/16] gitlab-ci.d/buildtest: Add jobs that run the device-crash-test

2021-12-14 Thread Thomas Huth
The device-crash-test script has been quite neglected in the past, so that it bit-rot quite often. Let's add CI jobs that run this script for at least some targets, so that this script does not regress that easily anymore. Message-Id: <20211126162724.1162049-1-th...@redhat.com>

Re: [PATCH] gitlab-ci.d/buildtest: Add jobs that run the device-crash-test

2021-12-01 Thread Thomas Huth
On 29/11/2021 11.07, Daniel P. Berrangé wrote: On Fri, Nov 26, 2021 at 05:27:24PM +0100, Thomas Huth wrote: The device-crash-test script has been quite neglected in the past, so that it bit-rot quite often. Let's add CI jobs that run this script for at least some targets, so that this s

Re: [PATCH] gitlab-ci.d/buildtest: Add jobs that run the device-crash-test

2021-11-29 Thread Daniel P . Berrangé
On Fri, Nov 26, 2021 at 05:27:24PM +0100, Thomas Huth wrote: > The device-crash-test script has been quite neglected in the past, > so that it bit-rot quite often. Let's add CI jobs that run this > script for at least some targets, so that this script does not > regress th

Re: [PATCH] gitlab-ci.d/buildtest: Add jobs that run the device-crash-test

2021-11-26 Thread Philippe Mathieu-Daudé
On 11/26/21 17:27, Thomas Huth wrote: > The device-crash-test script has been quite neglected in the past, > so that it bit-rot quite often. Let's add CI jobs that run this > script for at least some targets, so that this script does not > regress that easily anymore. > >

[PATCH] gitlab-ci.d/buildtest: Add jobs that run the device-crash-test

2021-11-26 Thread Thomas Huth
The device-crash-test script has been quite neglected in the past, so that it bit-rot quite often. Let's add CI jobs that run this script for at least some targets, so that this script does not regress that easily anymore. Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml

[PULL 6/7] scripts/device-crash-test: Use a QMP timeout

2021-11-22 Thread John Snow
Despite all the previous fixes, it's still possible for device-crash-test to wedge itself in the case that QEMU terminates *so quickly* that it doesn't even begin a connection attempt to our QMP client. Python will just joyfully wait ad infinitum for a connection that will now never ar

[PATCH 6/7] scripts/device-crash-test: Use a QMP timeout

2021-11-18 Thread John Snow
Despite all the previous fixes, it's still possible for device-crash-test to wedge itself in the case that QEMU terminates *so quickly* that it doesn't even begin a connection attempt to our QMP client. Python will just joyfully wait ad infinitum for a connection that will now never ar

Re: device-crash-test

2021-11-18 Thread John Snow
On Thu, Nov 18, 2021 at 1:31 PM Philippe Mathieu-Daudé wrote: > On 11/18/21 18:55, John Snow wrote: > > I finally squashed all of the bugs and got a clean run of > > device-crash-test with a full build of QEMU, over 182,000 individual > > test cases. > > > > Here

Re: device-crash-test

2021-11-18 Thread Philippe Mathieu-Daudé
On 11/18/21 18:55, John Snow wrote: > I finally squashed all of the bugs and got a clean run of > device-crash-test with a full build of QEMU, over 182,000 individual > test cases. > > Here's all of the legitimate failures I saw: > > CRITICAL: failed: binary=./qe

device-crash-test

2021-11-18 Thread John Snow
I finally squashed all of the bugs and got a clean run of device-crash-test with a full build of QEMU, over 182,000 individual test cases. Here's all of the legitimate failures I saw: CRITICAL: failed: binary=./qemu-system-x86_64 accel=kvm machine=none device=sgx-epc CRITICAL: cmdline: .

[PULL 5/5] scripts/device-crash-test: hide tracebacks for QMP connect errors

2021-11-16 Thread John Snow
: 2021143719.2162525-6-js...@redhat.com Signed-off-by: John Snow --- scripts/device-crash-test | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 49bcd61b4f..3db0ffe5b8 100755 --- a/scripts/device-crash-test +++ b

[PULL 4/5] scripts/device-crash-test: don't emit AQMP connection errors to stdout

2021-11-16 Thread John Snow
uth Message-id: 2021143719.2162525-5-js...@redhat.com Signed-off-by: John Snow --- scripts/device-crash-test | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index d91e8616ef..49bcd61b4f 100755 --- a/scripts/device-crash-test +++ b/scripts/de

[PULL 3/5] scripts/device-crash-test: simplify Exception handling

2021-11-16 Thread John Snow
ruptError and a few other important ones are BaseExceptions, so this does the same thing with less code. Signed-off-by: John Snow Reported-by: Thomas Huth Tested-by: Thomas Huth Message-id: 2021143719.2162525-4-js...@redhat.com Signed-off-by: John Snow --- scripts/device-crash-test | 8 +

[PATCH] Revert "device-crash-test: Ignore errors about a bus not being available"

2021-11-11 Thread Thomas Huth
spit out the 'No bus found' messages in their backtrace), but these other problems have now fortunately been tackled by John Snow, so we certainly don't need this duplicated entry here anymore. Signed-off-by: Thomas Huth --- scripts/device-crash-test | 1 - 1 file changed, 1 de

Re: [PATCH 0/5] python/aqmp: improve support for device-crash-test

2021-11-11 Thread Thomas Huth
On 11/11/2021 15.37, John Snow wrote: When I switched machine.py over to using AQMP, I caused a regression in device-crash-test that caused many spurious errors to be printed during the test, obscuring real test failure cases. This series fixes the vast majority of false positives, though there

[PATCH 0/5] python/aqmp: improve support for device-crash-test

2021-11-11 Thread John Snow
When I switched machine.py over to using AQMP, I caused a regression in device-crash-test that caused many spurious errors to be printed during the test, obscuring real test failure cases. This series fixes the vast majority of false positives, though there is one remaining bug in machine.py

[PATCH 4/5] scripts/device-crash-test: don't emit AQMP connection errors to stdout

2021-11-11 Thread John Snow
These errors are expected, so they shouldn't clog up terminal output. In the event that they're *not* expected, we'll be seeing an awful lot more output concerning the nature of the failure. Reported-by: Thomas Huth Signed-off-by: John Snow --- scripts/device-crash-test | 6

[PATCH 3/5] scripts/device-crash-test: simplify Exception handling

2021-11-11 Thread John Snow
ruptError and a few other important ones are BaseExceptions, so this does the same thing with less code. Signed-off-by: John Snow --- scripts/device-crash-test | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test i

[PATCH 5/5] scripts/device-crash-test: hide tracebacks for QMP connect errors

2021-11-11 Thread John Snow
Generally, the traceback for a connection failure is uninteresting and all we need to know is that the connection attempt failed. Reduce the verbosity in these cases, except when debugging. Signed-off-by: John Snow --- scripts/device-crash-test | 21 ++--- 1 file changed, 18

[PULL 13/13] device-crash-test: Ignore errors about a bus not being available

2021-04-01 Thread Thomas Huth
Recent QEMU versions now sometimes exit cleanly with an error message that a bus is not available for a specified device. Don't flag those as an error in the device-crash-test script. Message-Id: <20210323164718.1393792-1-th...@redhat.com> Acked-by: John Snow Signed-off-by:

Re: [PATCH] device-crash-test: Ignore errors about a bus not being available

2021-03-24 Thread John Snow
On 3/23/21 12:47 PM, Thomas Huth wrote: Recent QEMU versions now sometimes exit cleanly with an error message that a bus is not available for a specified device. Don't flag those as an error in the device-crash-test script. Signed-off-by: Thomas Huth --- scripts/device-crash-test | 1

[PATCH] device-crash-test: Ignore errors about a bus not being available

2021-03-23 Thread Thomas Huth
Recent QEMU versions now sometimes exit cleanly with an error message that a bus is not available for a specified device. Don't flag those as an error in the device-crash-test script. Signed-off-by: Thomas Huth --- scripts/device-crash-test | 1 + 1 file changed, 1 insertion(+) diff --

Re: [PATCH v2 4/8] scripts/device-crash-test: Replace the word 'whitelist'

2021-03-03 Thread Philippe Mathieu-Daudé
t; >> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md >> >> Reviewed-by: Daniel P. Berrangé >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> scripts/device-crash-test | 30 +++--- >> 1 file changed, 15 in

Re: [PATCH v2 4/8] scripts/device-crash-test: Replace the word 'whitelist'

2021-03-03 Thread Alex Bennée
main/faq.md > > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/device-crash-test | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/scripts/device-crash-test b/scripts/device

[PULL 2/3] device-crash-test: Remove problematic language

2021-02-18 Thread Eduardo Habkost
Replace "whitelist" in the device-crash-test script with "rule list". I'm using "rule list" instead of "allow list" or "pass list" because the list is not used only for expected/allowed errors. It also contain rules specifying which errors s

[PATCH v2 4/8] scripts/device-crash-test: Replace the word 'whitelist'

2021-02-05 Thread Philippe Mathieu-Daudé
by: Philippe Mathieu-Daudé --- scripts/device-crash-test | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 04118669ba7..6812de42f8c 100755 --- a/scripts/device-crash-test +++ b/scrip

Re: [PATCH 07/12] scripts/device-crash-test: Replace the word 'whitelist'

2021-02-03 Thread Daniel P . Berrangé
/conscious-lang/conscious-lang-docs/blob/main/faq.md > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/device-crash-test | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https

Re: [PATCH 07/12] scripts/device-crash-test: Replace the word 'whitelist'

2021-02-03 Thread Philippe Mathieu-Daudé
onscious-lang-docs/blob/main/faq.md > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/device-crash-test | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) Eduardo already sent a clever patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg778534.html

Re: [PATCH] device-crash-test: Remove problematic language

2021-02-02 Thread Thomas Huth
On 02/02/2021 20.12, Eduardo Habkost wrote: Replace "whitelist" in the device-crash-test script with "rule list". I'm using "rule list" instead of "allow list" or "pass list" because the list is not used only for expected/allowed errors.

[PATCH 07/12] scripts/device-crash-test: Replace the word 'whitelist'

2021-02-02 Thread Philippe Mathieu-Daudé
scripts/device-crash-test | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 04118669ba7..6812de42f8c 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -41

Re: [PATCH] device-crash-test: Remove problematic language

2021-02-02 Thread John Snow
On 2/2/21 2:12 PM, Eduardo Habkost wrote: Replace "whitelist" in the device-crash-test script with "rule list". I'm using "rule list" instead of "allow list" or "pass list" because the list is not used only for expected/allowed errors. It

[PATCH] device-crash-test: Remove problematic language

2021-02-02 Thread Eduardo Habkost
Replace "whitelist" in the device-crash-test script with "rule list". I'm using "rule list" instead of "allow list" or "pass list" because the list is not used only for expected/allowed errors. It also contain rules specifying which errors s

[PULL 03/19] device-crash-test: Check if path is actually an executable file

2020-11-10 Thread Thomas Huth
From: Eduardo Habkost After the transition to Meson, the build directory now have subdirectories named "qemu-system-*.p", and device-crash-test will try to execute them as if they were binaries. This results in errors like: PermissionError: [Errno 13] Permission denied: './qem

Re: [PATCH] device-crash-test: Check if path is actually an executable file

2020-10-26 Thread Philippe Mathieu-Daudé
On 10/26/20 1:52 PM, Eduardo Habkost wrote: After the transition to Meson, the build directory now have subdirectories named "qemu-system-*.p", and device-crash-test will try to execute them as if they were binaries. This results in errors like: PermissionError: [Errno 13] Permiss

Re: [PATCH] device-crash-test: Check if path is actually an executable file

2020-10-26 Thread Thomas Huth
On 26/10/2020 13.52, Eduardo Habkost wrote: > After the transition to Meson, the build directory now have > subdirectories named "qemu-system-*.p", and device-crash-test > will try to execute them as if they were binaries. This results > in errors like: > >

[PATCH] device-crash-test: Check if path is actually an executable file

2020-10-26 Thread Eduardo Habkost
After the transition to Meson, the build directory now have subdirectories named "qemu-system-*.p", and device-crash-test will try to execute them as if they were binaries. This results in errors like: PermissionError: [Errno 13] Permission denied: './qemu-system-or1k.p'

Re: [Qemu-devel] [PATCH] device-crash-test: Convert to Python 3

2019-01-30 Thread Nisarg Shah
Thanks for the review. On 1/24/19 12:20 AM, Eduardo Habkost wrote: This breaks Python 2 support: $ python2 scripts/device-crash-test File "scripts/device-crash-test", line 534 print("No QEMU binary found", file=sys.stderr) ^

[Qemu-devel] [PULL 1/2] device-crash-test: Python 3 compatibility fix

2019-01-25 Thread Eduardo Habkost
hunks from patch] [ehabkost: edited commit message] Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 483dafb2fc..2a13fa4f84 100755 --- a/scripts/device-

Re: [Qemu-devel] [PATCH] device-crash-test: Convert to Python 3

2019-01-23 Thread Eduardo Habkost
On Thu, Jan 17, 2019 at 12:03:58AM +0530, Nisarg Shah wrote: > Apply 2to3 tool to scripts/device-crash-test. > Restrict whitelist entry stats in debug mode to be sorted only by "count", > since Python 3 does > not implicitly support comparing dictionaries. Thanks for the

[Qemu-devel] [PULL 1/9] scripts/device-crash-test: Remove known crashes

2019-01-17 Thread Eduardo Habkost
Message-Id: <1541510826-21031-1-git-send-email-th...@redhat.com> Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 15 --- 1 file changed, 15 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index e93a7c0c84..549162a547 100755 --- a/scri

[Qemu-devel] [PATCH] device-crash-test: Convert to Python 3

2019-01-16 Thread Nisarg Shah
Apply 2to3 tool to scripts/device-crash-test. Restrict whitelist entry stats in debug mode to be sorted only by "count", since Python 3 does not implicitly support comparing dictionaries. Signed-off-by: Nisarg Shah --- scripts/device-crash-test | 7 --- 1 file changed, 4 insert

Re: [Qemu-devel] [PATCH] scripts/device-crash-test: Remove known crashes

2018-11-07 Thread Eduardo Habkost
On Tue, Nov 06, 2018 at 02:27:06PM +0100, Thomas Huth wrote: > Looks like we've fixed them all already in the past months, e.g. with: > > f7d6bfcdc0fe49040aac3ac131a319cb5427957e > spapr_pci: fail gracefully with non-pseries machine types > > 2363d5ee231bf047479422d56d3b85b7d37a7c23 > hw/ppc/

[Qemu-devel] [PATCH] scripts/device-crash-test: Remove known crashes

2018-11-06 Thread Thomas Huth
ot able to reproduce these crashes with the script anymore... but please double-check whether I'm right. scripts/device-crash-test | 15 --- 1 file changed, 15 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index e93a7c0..549162a 100755 --- a

[Qemu-devel] [PULL 01/15] scripts/device-crash-test: Remove devices that are not user_creatable anymore

2018-10-30 Thread Eduardo Habkost
From: Thomas Huth Devices that are derived from TYPE_SYS_BUS_DEVICE are not user_creatable anymore by default, and some others have been marked as non-user_creatable manually, so we can remove these devices from the "ignore"-list in the device-crash-test script. Signed-off-by: T

Re: [Qemu-devel] [PATCH] scripts/device-crash-test: Remove devices that are not user_creatable anymore

2018-10-05 Thread Eduardo Habkost
ist in the > device-crash-test script. > > Signed-off-by: Thomas Huth Thanks, queued on python-next. -- Eduardo

[Qemu-devel] [PATCH] scripts/device-crash-test: Remove devices that are not user_creatable anymore

2018-10-05 Thread Thomas Huth
Devices that are derived from TYPE_SYS_BUS_DEVICE are not user_creatable anymore by default, and some others have been marked as non-user_creatable manually, so we can remove these devices from the "ignore"-list in the device-crash-test script. Signed-off-by: Thomas Huth --- scri

[Qemu-devel] [PULL 4/4] scripts/device-crash-test: Remove entries for serial devices

2018-10-03 Thread Eduardo Habkost
From: Thomas Huth The problem with the various serial devices has been fixed a while ago in commit 47c4f85a0c27888e12af827471cfef87deb49821 ("hw/char/serial: Allow disconnected chardevs") already, so we can remove these entries from the "ignore" list in the device-crash-test

[Qemu-devel] [PULL 1/4] device-crash-test: No need for sys.path hack

2018-10-03 Thread Eduardo Habkost
The device-crash-test script is already inside the 'scripts' directory, there's no need to add the directory manually to sys.path. Signed-off-by: Eduardo Habkost Message-Id: <20180618225131.13113-2-ehabk...@redhat.com> Reviewed-by: Daniel P. Berrangé Reviewed-by: Stefan Ha

Re: [Qemu-devel] [PATCH] scripts/device-crash-test: Remove entries for serial devices

2018-10-01 Thread Eduardo Habkost
> from the "ignore" list in the device-crash-test script now. > > Signed-off-by: Thomas Huth Thanks, queued on python-next. -- Eduardo

[Qemu-devel] [PATCH] scripts/device-crash-test: Remove entries for serial devices

2018-10-01 Thread Thomas Huth
The problem with the various serial devices has been fixed a while ago in commit 47c4f85a0c27888e12af827471cfef87deb49821 ("hw/char/serial: Allow disconnected chardevs") already, so we can remove these entries from the "ignore" list in the device-crash-test script now. Signed

Re: [Qemu-devel] [PATCH 1/3] device-crash-test: No need for sys.path hack

2018-06-19 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 07:51:29PM -0300, Eduardo Habkost wrote: > The device-crash-test script is already inside the 'scripts' > directory, there's no need to add the directory manually to > sys.path. > > Signed-off-by: Eduardo Habkost > --- > scripts/devic

[Qemu-devel] [PATCH 1/3] device-crash-test: No need for sys.path hack

2018-06-18 Thread Eduardo Habkost
The device-crash-test script is already inside the 'scripts' directory, there's no need to add the directory manually to sys.path. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/device-crash-test b/scrip

[Qemu-devel] [PULL 12/12] scripts/device-crash-test: Removed fixed CAN entries

2018-05-07 Thread Eduardo Habkost
off-by: Eduardo Habkost --- scripts/device-crash-test | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 5d17dc68dd..b3ce72069f 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -218,9 +218,6 @@ ERROR_WHI

Re: [Qemu-devel] [PATCH] scripts/device-crash-test: Removed fixed CAN entries

2018-04-16 Thread Eduardo Habkost
On Mon, Apr 16, 2018 at 07:41:29PM +0200, Thomas Huth wrote: > The CAN device crashes have been fixed with the commit > 089eac81e1d34d202471c0a023284f47f4c5f00e already. > > Signed-off-by: Thomas Huth Queued, thanks. -- Eduardo

[Qemu-devel] [PATCH] scripts/device-crash-test: Removed fixed CAN entries

2018-04-16 Thread Thomas Huth
The CAN device crashes have been fixed with the commit 089eac81e1d34d202471c0a023284f47f4c5f00e already. Signed-off-by: Thomas Huth --- scripts/device-crash-test | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 5d17dc6..b3ce720

[Qemu-devel] [PULL 17/20] device-crash-test: Remove fixed isa-fdc entry

2018-04-06 Thread Paolo Bonzini
From: Thomas Huth Fixed by commit b3da551 ("fdc: Exit if ISA controller does not support DMA", 2018-03-16). Signed-off-by: Thomas Huth Signed-off-by: Paolo Bonzini --- scripts/device-crash-test | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/device-crash-test b/scri

[Qemu-devel] [PULL 08/16] scripts/device-crash-test: Remove fixed isapc-with-iommu entry

2018-03-26 Thread Paolo Bonzini
From: Thomas Huth Fixed in a0c167a18470831e359f0538c3cf67907808f13e ("x86_iommu: check if machine has PCI bus"). Signed-off-by: Thomas Huth Message-Id: <1521193892-15552-5-git-send-email-th...@redhat.com> Signed-off-by: Paolo Bonzini --- scripts/device-crash-test | 1 - 1

[Qemu-devel] [PATCH 4/4] scripts/device-crash-test: Remove fixed isapc-with-iommu entry

2018-03-16 Thread Thomas Huth
Fixed in a0c167a18470831e359f0538c3cf67907808f13e ("x86_iommu: check if machine has PCI bus"). Signed-off-by: Thomas Huth --- scripts/device-crash-test | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 8ad3f44..b3ce720 10

[Qemu-devel] [PULL 4/4] device-crash-test: Use 'python' binary

2018-03-12 Thread Eduardo Habkost
Now the script works with Python 3, so we can use the 'python' binary provided by the system. Signed-off-by: Eduardo Habkost Message-Id: <20180312185503.5746-4-ehabk...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Eduardo Habkost --- scripts/device-crash-tes

[Qemu-devel] [PULL 1/4] device-crash-test: New known crashes

2018-03-12 Thread Eduardo Habkost
We are not running the script on "make check" yet, and additional bugs were introduced recently in the tree. Whitelist the new crashes while we investigate, to allow us to run device-crash-test on "make check" as soon as possible to prevent new bugs. Cc: Pavel Pisa Cc: John

Re: [Qemu-devel] [PATCH 3/3] device-crash-test: Use 'python' binary

2018-03-12 Thread Daniel P . Berrangé
On Mon, Mar 12, 2018 at 03:55:03PM -0300, Eduardo Habkost wrote: > Now the script works with Python 3, so we can use the 'python' > binary provided by the system. > > Signed-off-by: Eduardo Habkost > --- > scripts/device-crash-test | 2 +- > 1 file chan

[Qemu-devel] [PATCH 3/3] device-crash-test: Use 'python' binary

2018-03-12 Thread Eduardo Habkost
Now the script works with Python 3, so we can use the 'python' binary provided by the system. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index

Re: [Qemu-devel] [PATCH 8/8] tests: Run device-crash-test on "make check"

2018-03-12 Thread Eduardo Habkost
On Fri, Mar 09, 2018 at 05:28:27PM -0300, Eduardo Habkost wrote: > Run a subset of tests using device-crash-test on "make check", to > help us catch device crashes earlier. > > This also add a "check-device-crash-test-full" rule, that will > check all machine/d

Re: [Qemu-devel] [PATCH 0/8] tests: Run device-crash-test on "make check"

2018-03-09 Thread Eduardo Habkost
On Fri, Mar 09, 2018 at 12:48:42PM -0800, no-re...@patchew.org wrote: [...] > /tmp/qemu-test/src/scripts/device-crash-test -q -t machine=DEFAULT accel=tcg > -- x86_64-softmmu/qemu-system-x86_64 aarch64-softmmu/qemu-system-aarch64 > /usr/bin/env: python2.7: No such file or directo

Re: [Qemu-devel] [PATCH 0/8] tests: Run device-crash-test on "make check"

2018-03-09 Thread no-reply
device-crash-test on "make check" === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=8 time make docker-test-quick@centos6 === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44b

[Qemu-devel] [PATCH 8/8] tests: Run device-crash-test on "make check"

2018-03-09 Thread Eduardo Habkost
Run a subset of tests using device-crash-test on "make check", to help us catch device crashes earlier. This also add a "check-device-crash-test-full" rule, that will check all machine/device combinations. Signed-off-by: Eduardo Habkost --- tests/Makefile.include | 13 +

[Qemu-devel] [PATCH 6/8] device-crash-test: Use WARN for known crashes

2018-03-09 Thread Eduardo Habkost
We're going to run device-crash-test on "make check", so it's better to make the script less noisy on known errors. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 44 ++-- 1 file changed, 22 insertions(+), 22 deleti

[Qemu-devel] [PATCH 3/8] device-crash-test: Accept machine=DEFAULT to test the default machine

2018-03-09 Thread Eduardo Habkost
This will be useful for running a smaller test set on "make check", instead of testing every single machine-type/device combination. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) di

[Qemu-devel] [PATCH 5/8] device-crash-test: Remove runnable-machine check

2018-03-09 Thread Eduardo Habkost
This optimization to skip tests if the machine is not runnable is unreliable and makes the script ignore actual QEMU crashes, so we're safer simply removing it. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 31 +-- 1 file changed, 1 insertion(+

[Qemu-devel] [PATCH 7/8] device-crash-test: Don't print warnings in quiet mode

2018-03-09 Thread Eduardo Habkost
This will be useful for hiding known crashes on "make check". Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index ed9a552fa1..36194e4347 100755 ---

[Qemu-devel] [PATCH 2/8] device-crash-test: Add examples to script documentation

2018-03-09 Thread Eduardo Habkost
Add simple examples for common use cases. Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 19 +++ 1 file changed, 19 insertions(+) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index c6a7875357..364c779cdb 100755 --- a/scripts/device-crash

[Qemu-devel] [PATCH 4/8] device-crash-test: New known crashes

2018-03-09 Thread Eduardo Habkost
We are not running the script on "make check" yet, and additional bugs were introduced recently in the tree. Whitelist the new crashes while we investigate, to allow us to run device-crash-test on "make check" as soon as possible to prevent new bugs. Cc: Pavel Pisa Cc: John

[Qemu-devel] [PATCH 0/8] tests: Run device-crash-test on "make check"

2018-03-09 Thread Eduardo Habkost
So, we're back to that time when we need to add new known crashes to device-crash-test, because we haven't been running it in a while and new bugs were introduced. To help prevent this from happening again, this series adds new rules to validate devices against the default machine-typ

[Qemu-devel] [PATCH 1/8] device-crash-test: Refactor loglevel configuration code

2018-03-09 Thread Eduardo Habkost
Use action='store_const', dest='loglevel' to represent the effect of each option more clearly. This will also make the last option in the command-line override the previous ones (e.g.: "-d -q"). Signed-off-by: Eduardo Habkost --- scripts/device-crash-test | 22

[Qemu-devel] [PULL v2 14/19] scripts: Remove fixed entries from the device-crash-test

2018-01-19 Thread Eduardo Habkost
From: Thomas Huth These are crashes / errors which have been fixed already in the past months. We can remove these from the device-crash-test script now. Signed-off-by: Thomas Huth Message-Id: <1513613438-11017-1-git-send-email-th...@redhat.com> Signed-off-by: Eduardo Habkost --- s

[Qemu-devel] [PULL 14/19] scripts: Remove fixed entries from the device-crash-test

2018-01-17 Thread Eduardo Habkost
From: Thomas Huth These are crashes / errors which have been fixed already in the past months. We can remove these from the device-crash-test script now. Signed-off-by: Thomas Huth Message-Id: <1513613438-11017-1-git-send-email-th...@redhat.com> Signed-off-by: Eduardo Habkost --- s

Re: [Qemu-devel] [PATCH] scripts: Remove fixed entries from the device-crash-test

2018-01-09 Thread Eduardo Habkost
On Mon, Dec 18, 2017 at 05:10:38PM +0100, Thomas Huth wrote: > These are crashes / errors which have been fixed already in the past > months. We can remove these from the device-crash-test script now. > > Signed-off-by: Thomas Huth Queued on machine-next. Sorry for the long delay. -- Eduardo

[Qemu-devel] [PATCH] scripts: Remove fixed entries from the device-crash-test

2017-12-18 Thread Thomas Huth
These are crashes / errors which have been fixed already in the past months. We can remove these from the device-crash-test script now. Signed-off-by: Thomas Huth --- scripts/device-crash-test | 8 1 file changed, 8 deletions(-) diff --git a/scripts/device-crash-test b/scripts/device

  1   2   >