Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michal Suchánek
On Wed, Sep 28, 2022 at 05:07:48PM -0400, Michael S. Tsirkin wrote: > On Wed, Sep 28, 2022 at 10:48:03PM +0200, Michal Suchánek wrote: > > Hello, > > > > On Tue, Jun 28, 2022 at 07:00:59AM -0400, Michael S. Tsirkin wrote: > > > > > > > > git submodules are awkward basically because they are an a

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 10:48:03PM +0200, Michal Suchánek wrote: > Hello, > > On Tue, Jun 28, 2022 at 07:00:59AM -0400, Michael S. Tsirkin wrote: > > > > > git submodules are awkward basically because they are an automated wget. > > I don't think an explicit wget is much better ... but > > looks

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michal Suchánek
Hello, On Tue, Jun 28, 2022 at 07:00:59AM -0400, Michael S. Tsirkin wrote: > > git submodules are awkward basically because they are an automated wget. > I don't think an explicit wget is much better ... but > looks like I'm alone in this. Oh well. > So it will be a weird dance of wget a tarball

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 04:07:40PM +0100, Peter Maydell wrote: > On Wed, 28 Sept 2022 at 15:29, Michael S. Tsirkin wrote: > > > > On Wed, Sep 28, 2022 at 11:18:18AM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 28, 2022 at 06:13:45AM -0400, Michael S. Tsirkin wrote: > > > > On Wed, Sep 28, 20

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Peter Maydell
On Wed, 28 Sept 2022 at 15:29, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2022 at 11:18:18AM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 28, 2022 at 06:13:45AM -0400, Michael S. Tsirkin wrote: > > > On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > > > > There's also th

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 07:15:53AM -0600, Warner Losh wrote: > > > On Wed, Sep 28, 2022 at 7:09 AM Daniel P. Berrangé > wrote: > > On Wed, Sep 28, 2022 at 05:53:17AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > > > On We

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Warner Losh
On Wed, Sep 28, 2022 at 7:09 AM Daniel P. Berrangé wrote: > On Wed, Sep 28, 2022 at 05:53:17AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 28, 2022 at 05:26:42AM -0400, Michael S. Tsirkin wrote: > > > > On Tue, Jun 28,

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 11:18:18AM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 28, 2022 at 06:13:45AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > > > There's also the perenial problem that developers frequently send > > > patches tha

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Warner Losh
On Wed, Sep 28, 2022 at 6:44 AM Michael S. Tsirkin wrote: > On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > > There's also the perenial problem that developers frequently send > > patches that mistakenly include submodule changes, which is related to > the > > way that 'git

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 10:57:47AM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 28, 2022 at 05:53:17AM -0400, Michael S. Tsirkin wrote: > > On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > > > On Wed, Sep 28, 2022 at 05:26:42AM -0400, Michael S. Tsirkin wrote: > > > > On Tue,

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 28, 2022 at 05:26:42AM -0400, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > > > On 28/06/2022 12.03, Michael S. Tsirkin wrote: > > > [...] > > > > For biosbits if we are

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Daniel P . Berrangé
On Wed, Sep 28, 2022 at 05:53:17AM -0400, Michael S. Tsirkin wrote: > On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 28, 2022 at 05:26:42AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > > > > On 28/06/2022

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 11:33:52AM +0200, Thomas Huth wrote: > On 28/09/2022 11.26, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > > > On 28/06/2022 12.03, Michael S. Tsirkin wrote: > > > [...] > > > > For biosbits if we are going this route then I feel

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Thomas Huth
On 28/09/2022 11.26, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: On 28/06/2022 12.03, Michael S. Tsirkin wrote: [...] For biosbits if we are going this route then I feel a submodule is much better. It records which version exactly each qemu version wa

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Daniel P . Berrangé
On Wed, Sep 28, 2022 at 06:13:45AM -0400, Michael S. Tsirkin wrote: > On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > > There's also the perenial problem that developers frequently send > > patches that mistakenly include submodule changes, which is related to the > > way that

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Wed, Sep 28, 2022 at 10:37:14AM +0100, Daniel P. Berrangé wrote: > There's also the perenial problem that developers frequently send > patches that mistakenly include submodule changes, which is related to the > way that 'git checkout' doesn't sync submodule state when switching branches. Do yo

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > On 28/06/2022 12.03, Michael S. Tsirkin wrote: > [...] > > For biosbits if we are going this route then I feel a submodule is much > > better. It records which version exactly each qemu version wants. > > As far as I know, you can als

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Thomas Huth
On 28/09/2022 11.47, Michael S. Tsirkin wrote: On Wed, Sep 28, 2022 at 11:33:52AM +0200, Thomas Huth wrote: On 28/09/2022 11.26, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: On 28/06/2022 12.03, Michael S. Tsirkin wrote: [...] For biosbits if we are g

Re: Why we should avoid new submodules if possible

2022-09-28 Thread Daniel P . Berrangé
On Wed, Sep 28, 2022 at 05:26:42AM -0400, Michael S. Tsirkin wrote: > On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > > On 28/06/2022 12.03, Michael S. Tsirkin wrote: > > [...] > > > For biosbits if we are going this route then I feel a submodule is much > > > better. It records whi

Re: Why we should avoid new submodules if possible

2022-07-01 Thread Philippe Mathieu-Daudé via
On Fri, Jul 1, 2022 at 5:37 AM Thomas Huth wrote: > On 29/06/2022 08.28, Ani Sinha wrote: > > On Tue, Jun 28, 2022 at 11:30 PM Michael S. Tsirkin wrote: > >> On Tue, Jun 28, 2022 at 05:15:05PM +0100, Daniel P. Berrangé wrote: > >>> FYI, the reason much of this is intentionally NOT under the /qemu

Re: Why we should avoid new submodules if possible

2022-06-30 Thread Thomas Huth
On 29/06/2022 08.28, Ani Sinha wrote: On Tue, Jun 28, 2022 at 11:30 PM Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 05:15:05PM +0100, Daniel P. Berrangé wrote: FYI, the reason much of this is intentionally NOT under the /qemu-project gitlab namespace is that we did not want to be respons

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 11:30 PM Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 05:15:05PM +0100, Daniel P. Berrangé wrote: > > FYI, the reason much of this is intentionally NOT under the /qemu-project > > gitlab namespace is that we did not want to be responsible for distributing > > arbit

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 05:15:05PM +0100, Daniel P. Berrangé wrote: > FYI, the reason much of this is intentionally NOT under the /qemu-project > gitlab namespace is that we did not want to be responsible for distributing > arbitrary binary blobs/images. That in turn makes the QEMU project responsi

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Daniel P . Berrangé
On Tue, Jun 28, 2022 at 09:24:34PM +0530, Ani Sinha wrote: > On Tue, Jun 28, 2022 at 6:09 PM Thomas Huth wrote: > > > > On 28/06/2022 13.14, Michael S. Tsirkin wrote: > > > On Tue, Jun 28, 2022 at 12:50:06PM +0200, Thomas Huth wrote: > > [...] > > >>> Come on, this is just a test. We *really* don'

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Ani Sinha
On Tue, Jun 28, 2022 at 6:09 PM Thomas Huth wrote: > > On 28/06/2022 13.14, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:50:06PM +0200, Thomas Huth wrote: > [...] > >>> Come on, this is just a test. We *really* don't care if an ISO > >>> we use to test ACPI is using an exploitable vers

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Warner Losh
On Tue, Jun 28, 2022 at 5:10 AM Michael S. Tsirkin wrote: > git submodules are awkward basically because they are an automated wget. > I don't think an explicit wget is much better ... but > looks like I'm alone in this. Oh well. > submodules are 90% of the hassles I have in upstreaming and upd

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 02:39:31PM +0200, Thomas Huth wrote: > On 28/06/2022 13.14, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:50:06PM +0200, Thomas Huth wrote: > [...] > > > > Come on, this is just a test. We *really* don't care if an ISO > > > > we use to test ACPI is using an explo

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Thomas Huth
On 28/06/2022 13.14, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 12:50:06PM +0200, Thomas Huth wrote: [...] Come on, this is just a test. We *really* don't care if an ISO we use to test ACPI is using an exploitable version of grub. Wait, I thought we were only talking about tappy here?

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 12:50:06PM +0200, Thomas Huth wrote: > On 28/06/2022 12.30, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > > > On 28/06/2022 12.03, Michael S. Tsirkin wrote: > > > [...] > > > > For biosbits if we are going this route then I feel

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 11:43:58AM +0100, Peter Maydell wrote: > On Tue, 28 Jun 2022 at 11:38, Michael S. Tsirkin wrote: > > On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > > > - we include the submodule content in our release tarballs, so people get > > > the impression that hte su

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Thomas Huth
On 28/06/2022 12.30, Michael S. Tsirkin wrote: On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: On 28/06/2022 12.03, Michael S. Tsirkin wrote: [...] For biosbits if we are going this route then I feel a submodule is much better. It records which version exactly each qemu version wa

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Peter Maydell
On Tue, 28 Jun 2022 at 11:38, Michael S. Tsirkin wrote: > On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > > - we include the submodule content in our release tarballs, so people get > > the impression that hte submodule content is part of the QEMU sources. This > > has two disadvant

Re: Why we should avoid new submodules if possible

2022-06-28 Thread Michael S. Tsirkin
On Tue, Jun 28, 2022 at 12:21:39PM +0200, Thomas Huth wrote: > On 28/06/2022 12.03, Michael S. Tsirkin wrote: > [...] > > For biosbits if we are going this route then I feel a submodule is much > > better. It records which version exactly each qemu version wants. > > As far as I know, you can als

Why we should avoid new submodules if possible

2022-06-28 Thread Thomas Huth
On 28/06/2022 12.03, Michael S. Tsirkin wrote: [...] For biosbits if we are going this route then I feel a submodule is much better. It records which version exactly each qemu version wants. As far as I know, you can also specify the version when using pip, can't you? So that's not really an