Re: Regressions in build process introduced since August

2020-11-23 Thread Stefan Weil
Am 23.11.20 um 17:20 schrieb Paolo Bonzini: On 23/11/20 16:41, Daniel P. Berrangé wrote: Relying on pkg-config should be our strong preference. I expect we're doing the old fashioned library check just for historical reasons, but even RHEL-7 supports pkg-config for libjpeg. So I think we're sa

Re: Regressions in build process introduced since August

2020-11-23 Thread Paolo Bonzini
On 23/11/20 16:41, Daniel P. Berrangé wrote: On Mon, Nov 23, 2020 at 03:28:39PM +, Daniel P. Berrangé wrote: On Mon, Nov 23, 2020 at 03:40:48PM +0100, Stefan Weil wrote: Am 23.11.20 um 14:55 schrieb Paolo Bonzini: On 21/11/20 12:09, Stefan Weil wrote: --- a/meson.build +++ b/meson.build

Re: Regressions in build process introduced since August

2020-11-23 Thread Daniel P . Berrangé
On Mon, Nov 23, 2020 at 03:28:39PM +, Daniel P. Berrangé wrote: > On Mon, Nov 23, 2020 at 03:40:48PM +0100, Stefan Weil wrote: > > Am 23.11.20 um 14:55 schrieb Paolo Bonzini: > > > > > On 21/11/20 12:09, Stefan Weil wrote: > > > > --- a/meson.build > > > > +++ b/meson.build > > > > @@ -649,9 +

Re: Regressions in build process introduced since August

2020-11-23 Thread Daniel P . Berrangé
On Mon, Nov 23, 2020 at 03:40:48PM +0100, Stefan Weil wrote: > Am 23.11.20 um 14:55 schrieb Paolo Bonzini: > > > On 21/11/20 12:09, Stefan Weil wrote: > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -649,9 +649,8 @@ if get_option('vnc').enabled() > > >     vnc = declare_dependency() # dum

Re: Regressions in build process introduced since August

2020-11-23 Thread Paolo Bonzini
On 23/11/20 15:40, Stefan Weil wrote: The Meson checks obviously don't use those flags. Indeed they don't. For 0.56 however something like this should be doable: diff --git a/meson.build b/meson.build index 5062407c70..25940f8de7 100644 --- a/meson.build +++ b/meson.build @@ -107,6 +107,22 @@

Re: Regressions in build process introduced since August

2020-11-23 Thread Stefan Weil
Am 23.11.20 um 14:55 schrieb Paolo Bonzini: On 21/11/20 12:09, Stefan Weil wrote: --- a/meson.build +++ b/meson.build @@ -649,9 +649,8 @@ if get_option('vnc').enabled()     vnc = declare_dependency() # dummy dependency     png = dependency('libpng', required: get_option('vnc_png'),

Re: Regressions in build process introduced since August

2020-11-23 Thread Paolo Bonzini
On 21/11/20 12:09, Stefan Weil wrote: --- a/meson.build +++ b/meson.build @@ -649,9 +649,8 @@ if get_option('vnc').enabled()    vnc = declare_dependency() # dummy dependency    png = dependency('libpng', required: get_option('vnc_png'),     method: 'pkg-config', static: enable_

Re: Regressions in build process introduced since August

2020-11-21 Thread Paolo Bonzini
Il sab 21 nov 2020, 12:26 Stefan Weil ha scritto: > One more regression: a lot of build targets are no longer supported with > the new meson based build. > > Personally I am missing `make install-doc` and found no good replacement > up to now. > Just use DESTDIR to install in a staging area, and

Re: Regressions in build process introduced since August

2020-11-21 Thread Stefan Weil
One more regression: a lot of build targets are no longer supported with the new meson based build. Personally I am missing `make install-doc` and found no good replacement up to now. Regards, Stefan

Re: Regressions in build process introduced since August

2020-11-21 Thread Stefan Weil
Am 21.11.20 um 11:25 schrieb Stefan Weil: Hi, I just noticed another regression: A cross build targeting Windows no longer detects VNC JPEG support. Using pkg-config like in the patch below would fix that (and also works for native builds on Debian GNU Linux). Maybe the current find_librar

Re: Regressions in build process introduced since August

2020-11-21 Thread Stefan Weil
Hi, I just noticed another regression: A cross build targeting Windows no longer detects VNC JPEG support. Using pkg-config like in the patch below would fix that (and also works for native builds on Debian GNU Linux). Maybe the current find_library ignores --extra-cflags and --extra-ldflag

Re: Regressions in build process introduced since August

2020-11-18 Thread Stefan Weil
Am 18.11.20 um 16:34 schrieb Daniel P. Berrangé: On Sun, Nov 15, 2020 at 11:57:25AM +0100, Stefan Weil wrote: *** Setting INSTALLER no longer handled meson.build sets a hard name for the Windows installer executable: installer = 'qemu-setup-' + meson.project_version() + '.exe'. Previously the

Re: Regressions in build process introduced since August

2020-11-18 Thread Daniel P . Berrangé
On Sun, Nov 15, 2020 at 11:57:25AM +0100, Stefan Weil wrote: > *** Setting INSTALLER no longer handled > > meson.build sets a hard name for the Windows installer executable: installer > = 'qemu-setup-' + meson.project_version() + '.exe'. > > Previously the installer name could be changed by runni

Re: Regressions in build process introduced since August

2020-11-17 Thread Stefan Weil
Am 17.11.20 um 19:01 schrieb Paolo Bonzini: On 17/11/20 18:50, Stefano Garzarella wrote: Running `configure [...] --extra-cflags="-I /xyz"` results in compiler flags `-I [...] /xyz`, so the `-I` and `/xyz` are separated by other compiler flags which obviously cannot work as expected. I could wo

Re: Regressions in build process introduced since August

2020-11-17 Thread Paolo Bonzini
On 17/11/20 18:50, Stefano Garzarella wrote: Running `configure [...] --extra-cflags="-I /xyz"` results in compiler flags `-I [...] /xyz`, so the `-I` and `/xyz` are separated by other compiler flags which obviously cannot work as expected. I could work around that by removing the space and using

Re: Regressions in build process introduced since August

2020-11-17 Thread Stefano Garzarella
CCing Paolo and Marc-André who worked on meson integrations. On Sun, Nov 15, 2020 at 11:57:25AM +0100, Stefan Weil wrote: Dear all, yesterday I tried to build new QEMU installers for Windows and noticed two regressions which break my build process: *** Change in handling of --extra-cflags

Regressions in build process introduced since August

2020-11-15 Thread Stefan Weil
Dear all, yesterday I tried to build new QEMU installers for Windows and noticed two regressions which break my build process: *** Change in handling of --extra-cflags Running `configure [...] --extra-cflags="-I /xyz"` results in compiler flags `-I [...] /xyz`, so the `-I` and `/xyz` are sep