Re: [PULL 0/6] Mostly target/i386 patches for QEMU 10.1 hard freeze

2025-07-20 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH RFC v3 04/13] virtio: serialize extended features state

2025-07-20 Thread Akihiko Odaki
On 2025/07/18 17:52, Paolo Abeni wrote: If the driver uses any of the extended features (i.e. 64 or above), store the extended features range (64-127 bits). At load time, let legacy features initialize the full features range and pass it to the set helper; sub-states loading will have filled-up

Re: [PATCH RFC v3 03/13] virtio: introduce extended features type

2025-07-20 Thread Akihiko Odaki
On 2025/07/18 17:52, Paolo Abeni wrote: The virtio specifications allows for up to 128 bits for the device features. Soon we are going to use some of the 'extended' bits features (bit 64 and above) for the virtio net driver. Represent the virtio features bitmask with a fixes size array, and intr

Re: [PATCH RFC v3 01/13] net: bundle all offloads in a single struct

2025-07-20 Thread Akihiko Odaki
On 2025/07/18 17:52, Paolo Abeni wrote: The set_offload() argument list is already pretty long and we are going to introduce soon a bunch of additional offloads. Replace the offload arguments with a single struct and update all the relevant call-sites. No functional changes intended. Signed-of

Re: [PATCH 6/6] net/vhost-user: Remove unused "err" from chr_closed_bh() (CID 1612365)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:50, Laurent Vivier wrote: > > The "err" variable was declared but never used within the > chr_closed_bh() function. This resulted in a dead code > warning (CID 1612365) from Coverity. > > Remove the unused variable and the associated error block > to resolve the issue. >

Re: [PATCH 5/6] net/passt: Initialize "error" variable in net_passt_send() (CID 1612368)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:51, Laurent Vivier wrote: > > This was flagged by Coverity as a memory illegal access. > > Initialize the pointer to NULL at declaration. > > Signed-off-by: Laurent Vivier > --- > net/passt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/p

Re: [PATCH 3/6] net/passt: Remove dead code in passt_vhost_user_start error path (CID 1612371)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:50, Laurent Vivier wrote: > > In passt_vhost_user_start(), if vhost_net_init() fails, the "net" > variable is NULL and execution jumps to the "err:" label. > > The cleanup code within this label is conditioned on "if (net)", > which can never be true in this error case. T

Re: [PATCH 1/6] net/passt: Remove unused "err" from passt_vhost_user_event() (CID 1612375)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:43, Laurent Vivier wrote: > > The "err" variable was declared but never used within the > passt_vhost_user_event() function. This resulted in a dead code > warning (CID 1612375) from Coverity. > > Remove the unused variable and the associated error block > to resolve the

Re: [PATCH 2/6] net/vhost-user: Remove unused "err" from net_vhost_user_event() (CID 1612372)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:52, Laurent Vivier wrote: > > The "err" variable was declared but never used within the > net_vhost_user_event() function. This resulted in a dead code > warning (CID 1612372) from Coverity. > > Remove the unused variable and the associated error block > to resolve the is

Re: [PATCH 4/6] net/passt: Check return value of g_remove() in net_passt_cleanup() (CID 1612369)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:44, Laurent Vivier wrote: > > If g_remove() fails, use warn_report() to log an error. > > Signed-off-by: Laurent Vivier > --- > net/passt.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 2/2] tests/functional/test_aarch64_rme: update image

2025-07-19 Thread Pierrick Bouvier
On 7/19/25 3:57 AM, Manos Pitsidianakis wrote: On Sat, Jul 19, 2025 at 7:00 AM Pierrick Bouvier wrote: TF-A needs to be patched to enable support for FEAT_TCR2 and FEAT_SCTLR2. This new image contains updated firmware. Signed-off-by: Pierrick Bouvier --- tests/functional/test_aarch64_rme_s

Re: [PATCH for-10.1] tcg/optimize: Don't fold INDEX_op_and_vec to extract

2025-07-19 Thread Peter Maydell
On Fri, 18 Jul 2025 at 18:46, Richard Henderson wrote: > > There is no such thing as vector extract. > > Fixes: 932522a9ddc1 ("tcg/optimize: Fold and to extract during optimize") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3036 > Signed-off-by: Richard Henderson > --- > tcg/optimiz

Re: [PATCH v2 2/2] tests/functional/test_aarch64_rme: update image

2025-07-19 Thread Manos Pitsidianakis
On Sat, Jul 19, 2025 at 7:00 AM Pierrick Bouvier wrote: > > TF-A needs to be patched to enable support for FEAT_TCR2 and > FEAT_SCTLR2. This new image contains updated firmware. > > Signed-off-by: Pierrick Bouvier > --- > tests/functional/test_aarch64_rme_sbsaref.py | 64 --- > tests

Re: [PATCH RFC v3 08/13] qmp: update virtio features map to support extended features

2025-07-19 Thread Markus Armbruster
Paolo Abeni writes: > Extend the VirtioDeviceFeatures struct with an additional u64 > to track unknown features in the 64-127 bit range and decode > the full virtio features spaces for vhost and virtio devices. > > Also add entries for the soon-to-be-supported virtio net GSO over > UDP features.

Re: [PATCH] util: win32: Write hex value when can't get error message

2025-07-19 Thread Markus Armbruster
Kostiantyn Kostiuk writes: > g_win32_error_message - translate a Win32 error code > (as returned by GetLastError()) into the corresponding message. > > In the same time, we call error_setg_win32_internal with > error codes from different Windows componets like VSS or > Performance monitor that pr

Re: [PATCH 0/2] aarch64: update test images with new trusted firmware

2025-07-18 Thread Pierrick Bouvier
On 7/15/25 2:23 PM, Pierrick Bouvier wrote: The FEAT_MEC series [1] introduces FEAT_TCR2 and FEAT_SCTLR2. TF-A needs to be aware of that change to allow accesses to those registers, and thus must be patched [2] to enable this for QEMU platforms. Concerned test images need to be updated to allow

Re: [PATCH v2 0/2] aarch64: update test images with new trusted firmware

2025-07-18 Thread Pierrick Bouvier
Hi Richard, On 7/18/25 8:58 PM, Pierrick Bouvier wrote: The FEAT_MEC series [1] introduces FEAT_TCR2 and FEAT_SCTLR2. TF-A needs to be aware of that change to allow accesses to those registers, and thus must be patched [2] to enable this for QEMU platforms. Concerned test images need to be upda

Re: [PATCH for-10.1 10/10] target/arm: Make LD1Q decode and trans fn agree about a->u

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: For the LD1Q instruction (gather load of quadwords) we use the LD1_zprz pattern with MO_128 elements. At this element size there is no signed vs unsigned distinction, and we only set the 'u' bit in the arg_LD1_zprz struct because we share the code and decod

Re: [PATCH for-10.1 09/10] target/arm: Honour FPCR.AH=1 default NaN value in FMAXNMQV, FMINNMQV

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: The FMAXNMQV and FMINNMQV insns use the default NaN as their identity value for inactive source vector elements. We open-coded this in sve_helper.c, hoping to avoid a function call. However, this fails to account for FPCR.AH=1 changing the default NaN value

Re: [PATCH for-10.1 08/10] target/arm: Don't nest H() macro calls in SVE DO_REDUCE

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: In the part of the SVE DO_REDUCE macro used by the SVE2p1 FMAXQV, FMINQV, etc insns, we incorrectly applied the H() macro twice when calculating an offset to add to the vn pointer. This has no effect on little-endian hosts but on big-endian hosts the two in

Re: [PATCH for-10.1 07/10] target/arm: Correct sense of FPCR.AH test for FMAXQV and FMINQV

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: When we implemented the FMAXQV and FMINQV insns we accidentally inverted the sense of the FPCR.AH test, so we gave the AH=1 behaviour when FPCR.AH was zero, and vice-versa. (The difference is limited to hadling of negative zero and NaN inputs.) Fixes: 1de7

Re: [PATCH for-10.1 06/10] target/arm: Add BFMLA, BFMLS (indexed)

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: FEAT_SVE_B16B16 adds bfloat16 versions of the FMLA and FMLS insns in the SVE floating-point multiply-add (indexed) insn group. Implement these. Fixes: 7b1613a1020d2942 ("target/arm: Enable FEAT_SME2p1 on -cpu max") Signed-off-by: Peter Maydell --- target

Re: [PATCH for-10.1 05/10] target/arm: Add BFMLA, BFMLS (vectors)

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: FEAT_SVE_B16B16 adds bfloat16 versions of the FMLA and FMLS insns in the "SVE floating-point multiply-accumulate writing addend" group, encoded as sz=0b00. Fixes: 7b1613a1020d2942 ("target/arm: Enable FEAT_SME2p1 on -cpu max") Signed-off-by: Peter Maydell -

Re: [PATCH for-10.1 03/10] target/arm: Add BFMIN, BFMAX (predicated)

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: FEAT_SVE_B16B16 adds bfloat16 versions of the SVE floating point (predicated) instructions, which are encoded via sz=0b00. Add the BFMAX and BFMIN insns. These have separate behaviour for AH=1 and AH=0; we have already implemented the AH=1 helper for the S

Re: [PATCH for-10.1 04/10] target/arm: Add BFMUL (indexed)

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: FEAT_SVE_B16B16 adds a bfloat16 version of the FMUL insn in the floating-point multiply (indexed) instruction group. The encoding is slightly bespoke; in our implementation we use MO_8 to indicate bfloat16, as with the other B16B16 insns. Fixes: 7b1613a1020

Re: [PATCH for-10.1 02/10] target/arm: Add BFADD, BFSUB, BFMUL, BFMAXNM, BFMINNM (predicated)

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: FEAT_SVE_B16B16 adds bfloat16 versions of the SVE floating point (predicated) instructions, which are encoded via sz=0b00. Add BFADD, BFSUB, BFMUL, BFMAXNM, BFMINNM; these are all the insns in this group which do not change behaviour for AH=1. We will deal

Re: [PATCH for-10.1 01/10] target/arm: Add BFADD, BFSUB, BFMUL (unpredicated)

2025-07-18 Thread Richard Henderson
On 7/18/25 10:30, Peter Maydell wrote: FEAT_SVE_B16B16 adds bfloat16 versions of the SVE floating point (unpredicated) instructions, which are encoded via sz==0b00. Fixes: 7b1613a1020d2942 ("target/arm: Enable FEAT_SME2p1 on -cpu max") Signed-off-by: Peter Maydell --- target/arm/tcg/helper.h

Re: [PATCH for-10.1] tcg/optimize: Don't fold INDEX_op_and_vec to extract

2025-07-18 Thread Richard Henderson
On 7/18/25 12:11, Peter Maydell wrote: On Fri, 18 Jul 2025 at 18:46, Richard Henderson wrote: There is no such thing as vector extract. Fixes: 932522a9ddc1 ("tcg/optimize: Fold and to extract during optimize") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3036 Signed-off-by: Richard

Re: [PULL 2/3] vfio: Move the TYPE_* to hw/vfio/types.h

2025-07-18 Thread Cédric Le Goater
On 7/18/25 21:43, Gerd Hoffmann wrote: From: Shaoqin Huang Move the TYPE_* to a new file hw/vfio/types.h because the TYPE_VFIO_PCI will be used in later patch, but directly include the hw/vfio/pci.h can cause some compilation error when cross build the windows version. The hw/vfio/types.h can

Re: [PATCH for-10.1] tcg/optimize: Don't fold INDEX_op_and_vec to extract

2025-07-18 Thread Pierrick Bouvier
On 7/18/25 10:38 AM, Richard Henderson wrote: There is no such thing as vector extract. Fixes: 932522a9ddc1 ("tcg/optimize: Fold and to extract during optimize") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3036 Signed-off-by: Richard Henderson --- tcg/optimize.c | 2 +- 1 file ch

Re: [PATCH for-10.1] tcg/optimize: Don't fold INDEX_op_and_vec to extract

2025-07-18 Thread Peter Maydell
On Fri, 18 Jul 2025 at 18:46, Richard Henderson wrote: > > There is no such thing as vector extract. > > Fixes: 932522a9ddc1 ("tcg/optimize: Fold and to extract during optimize") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3036 > Signed-off-by: Richard Henderson > --- > tcg/optimiz

Re: [PATCH V2 2/2] vfio/pci: preserve pending interrupts

2025-07-18 Thread Steven Sistare
the kernel vfio_msihandler, which writes to QEMU's kvm_interrupt eventfd. CPR already preserves that eventfd. When the route is re-established in new QEMU, the kernel tests the eventfd and injects an interrupt to KVM if necessary. With this patch, producer is detached from the kvm consume

Re: [RFC V2 0/8] Live update: tap and vhost

2025-07-18 Thread Steven Sistare
On 7/18/2025 4:48 AM, Lei Yang wrote: Hi Steve I tested your patch which hit a problem under enable/disable nic mq state(The full test scenario is live migration vm at local under enable/disable vm nic mq state): Run command: /qemu-img info /home/images/vm1.qcow2 --output=json Error info: qemu-i

Re: [PATCH v5 02/23] migration: push Error **errp into vmstate_load_state()

2025-07-18 Thread Arun Menon
Hi Daniel, Thank you so much for the review. On Thu, Jul 17, 2025 at 05:32:14PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 17, 2025 at 06:07:25AM +0530, Arun Menon wrote: > > This is an incremental step in converting vmstate loading > > code to report error via Error objects instead of direct

Re: [PATCH RFC v3 04/13] virtio: serialize extended features state

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 10:52:30AM +0200, Paolo Abeni wrote: If the driver uses any of the extended features (i.e. 64 or above), store the extended features range (64-127 bits). At load time, let legacy features initialize the full features range and pass it to the set helper; sub-states loading

Re: [PATCH 19/22] vfio/igd.c: use QOM casts where appropriate

2025-07-18 Thread Tomita Moeko
On 7/15/2025 5:25 PM, Mark Cave-Ayland wrote: > Use QOM casts to convert between VFIOPCIDevice and PCIDevice instead of > accessing pdev directly. > > Signed-off-by: Mark Cave-Ayland > --- > hw/vfio/igd.c | 38 +- > 1 file changed, 21 insertions(+), 17 deletio

Re: [PATCH RFC v3 13/13] net: implement UDP tunnel features offloading

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 10:52:39AM +0200, Paolo Abeni wrote: When any host or guest GSO over UDP tunnel offload is enabled the virtio net header includes the additional tunnel-related fields, update the size accordingly. Push the GSO over UDP tunnel offloads all the way down to the tap device ex

Re: [PATCH] net/passt: Fix build failure due to missing GIO dependency

2025-07-18 Thread Thomas Huth
On 18/07/2025 15.31, Laurent Vivier wrote: The passt networking backend uses functions from the GIO library, such as g_subprocess_launcher_new(), to manage its daemon process. So, building with passt enabled requires GIO to be available. If we enable passt and disable gio the build fails during

Re: [PATCH RFC v3 07/13] vhost: add support for negotiating extended features

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 10:52:33AM +0200, Paolo Abeni wrote: Similar to virtio infra, vhost core maintains the features status in the full extended format and allows the devices to implement extended version of the getter/setter. Note that 'protocol_features' are not extended: they are only used

Re: [PATCH 2/2] watchdog: generic name for i6300esb

2025-07-18 Thread Yan Vugenfirer
On Thu, Jul 17, 2025 at 9:14 PM Cornelia Huck wrote: > > On Tue, Jul 15 2025, Daniel P. Berrangé wrote: > > > On Tue, Jul 15, 2025 at 09:16:24AM -0700, Andrea Bolognani wrote: > >> On Tue, Jul 15, 2025 at 05:02:54PM +0100, Daniel P. Berrangé wrote: > >> > On Tue, Jul 15, 2025 at 05:44:25PM +0200,

Re: [PATCH RFC v3 10/13] vhost-net: implement extended features support

2025-07-18 Thread Paolo Abeni
On 7/18/25 3:01 PM, Stefano Garzarella wrote: > On Fri, Jul 18, 2025 at 10:52:36AM +0200, Paolo Abeni wrote: >> @@ -234,7 +234,8 @@ struct vhost_net *vhost_net_init(VhostNetOptions >> *options) >> int r; >> bool backend_kernel = options->backend_type == VHOST_BACKEND_TYPE_KERNEL; >> st

Re: [PATCH 0/7] hw/i386/amd_iommu: Cleanups and fixes

2025-07-18 Thread Alejandro Jimenez
On 7/18/25 9:28 AM, Vasant Hegde wrote: Alejandro, Sairaj, On 7/17/2025 7:18 PM, Alejandro Jimenez wrote: On 7/17/25 2:07 AM, Michael S. Tsirkin wrote: On Thu, Jul 17, 2025 at 11:17:05AM +0530, Sairaj Kodilkar wrote: On 7/16/2025 6:59 PM, Michael S. Tsirkin wrote: On Wed, Jul 16, 202

Re: [PATCH RFC v3 13/13] net: implement UDP tunnel features offloading

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 03:44:20PM +0200, Paolo Abeni wrote: On 7/18/25 3:22 PM, Stefano Garzarella wrote: On Fri, Jul 18, 2025 at 10:52:39AM +0200, Paolo Abeni wrote: diff --git a/net/tap.c b/net/tap.c index 23c6c118e7..2dfa843547 100644 --- a/net/tap.c +++ b/net/tap.c @@ -62,6 +62,8 @@ static

Re: [PATCH] net/passt: Fix build failure due to missing GIO dependency

2025-07-18 Thread Daniel P . Berrangé
On Fri, Jul 18, 2025 at 03:31:10PM +0200, Laurent Vivier wrote: > The passt networking backend uses functions from the GIO library, > such as g_subprocess_launcher_new(), to manage its daemon process. > So, building with passt enabled requires GIO to be available. > > If we enable passt and disabl

Re: [PATCH RFC v3 13/13] net: implement UDP tunnel features offloading

2025-07-18 Thread Paolo Abeni
On 7/18/25 3:22 PM, Stefano Garzarella wrote: > On Fri, Jul 18, 2025 at 10:52:39AM +0200, Paolo Abeni wrote: >> diff --git a/net/tap.c b/net/tap.c >> index 23c6c118e7..2dfa843547 100644 >> --- a/net/tap.c >> +++ b/net/tap.c >> @@ -62,6 +62,8 @@ static const int kernel_feature_bits[] = { >> VIRT

Re: [PATCH 0/7] hw/i386/amd_iommu: Cleanups and fixes

2025-07-18 Thread Vasant Hegde
Alejandro, Sairaj, On 7/17/2025 7:18 PM, Alejandro Jimenez wrote: > > > On 7/17/25 2:07 AM, Michael S. Tsirkin wrote: >> On Thu, Jul 17, 2025 at 11:17:05AM +0530, Sairaj Kodilkar wrote: >>> >>> >>> On 7/16/2025 6:59 PM, Michael S. Tsirkin wrote: On Wed, Jul 16, 2025 at 06:26:37PM +0530, Sa

Re: [PATCH RFC v3 13/13] net: implement UDP tunnel features offloading

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 10:52:39AM +0200, Paolo Abeni wrote: When any host or guest GSO over UDP tunnel offload is enabled the virtio net header includes the additional tunnel-related fields, update the size accordingly. Push the GSO over UDP tunnel offloads all the way down to the tap device ex

Re: [PATCH] xen/passthrough: add missing error-report include

2025-07-18 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Jul 18, 2025 at 07:59:50AM +0200, Markus Armbruster wrote: >> Markus Armbruster writes: >> >> > Adam Williamson writes: >> > >> >> In cfcacba an `error_report` was added to this file, but the >> >> corresponding include of `qemu/error-report.h` was missed.

Re: [PATCH RFC v3 10/13] vhost-net: implement extended features support

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 10:52:36AM +0200, Paolo Abeni wrote: Provide extended version of the features manipulation helpers, and let the device initialization deal with the full features space, adjusting the relevant format strings accordingly. Signed-off-by: Paolo Abeni --- v2 -> v3: - use vir

Re: [PATCH RFC v3 12/13] net: implement tunnel probing

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 10:52:38AM +0200, Paolo Abeni wrote: Tap devices support GSO over UDP tunnel offload. Probe for such feature in a similar manner to other offloads. GSO over UDP tunnel needs to be enabled in addition to a "plain" offload (TSO or USO). No need to check separately for the

Re: [PATCH RFC v3 08/13] qmp: update virtio features map to support extended features

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 12:23:21PM +0200, Paolo Abeni wrote: On 7/18/25 12:18 PM, Stefano Garzarella wrote: On Fri, Jul 18, 2025 at 10:52:34AM +0200, Paolo Abeni wrote: diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c index 3b6377cf0d..03c6163cf4 100644 --- a/hw/virtio/virtio-qmp.c

Re: [PATCH RFC v3 08/13] qmp: update virtio features map to support extended features

2025-07-18 Thread Paolo Abeni
On 7/18/25 12:18 PM, Stefano Garzarella wrote: > On Fri, Jul 18, 2025 at 10:52:34AM +0200, Paolo Abeni wrote: >> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c >> index 3b6377cf0d..03c6163cf4 100644 >> --- a/hw/virtio/virtio-qmp.c >> +++ b/hw/virtio/virtio-qmp.c >> @@ -325,6 +325,20 @

Re: [PATCH RFC v3 08/13] qmp: update virtio features map to support extended features

2025-07-18 Thread Stefano Garzarella
On Fri, Jul 18, 2025 at 10:52:34AM +0200, Paolo Abeni wrote: Extend the VirtioDeviceFeatures struct with an additional u64 to track unknown features in the 64-127 bit range and decode the full virtio features spaces for vhost and virtio devices. Also add entries for the soon-to-be-supported virt

Re: [PATCH 3/3] tests/functional: add -k TEST_NAME_PATTERN CLI arg

2025-07-18 Thread Manos Pitsidianakis
On Fri, Jul 18, 2025 at 12:37 PM Paolo Bonzini wrote: > > On 7/18/25 11:12, Manos Pitsidianakis wrote: > > Add a CLI argument that takes fnmatch(3)-style patterns as value and can > > be specified many times. Only tests that match the pattern will be > > executed. This argument is passed to unitte

Re: [PATCH 3/3] tests/functional: add -k TEST_NAME_PATTERN CLI arg

2025-07-18 Thread Paolo Bonzini
On 7/18/25 11:12, Manos Pitsidianakis wrote: Add a CLI argument that takes fnmatch(3)-style patterns as value and can be specified many times. Only tests that match the pattern will be executed. This argument is passed to unittest.main which takes the same argument. Signed-off-by: Manos Pitsidia

Re: [PATCH] target/i386: do not expose ARCH_CAPABILITIES on AMD CPU

2025-07-18 Thread Zhao Liu
QEMU versions, therefore this is not a problematic breakage. > > If a future AMD machine does include the MSR, that would re-expose the > Windows guest bug; but it would not be KVM/QEMU's problem at that > point, as we'd be following a genuine physical CPU impl. Make sense.

Re: [PATCH v2] tests/functional: add --debug CLI arg

2025-07-18 Thread Manos Pitsidianakis
On Fri, Jul 18, 2025 at 12:20 PM Daniel P. Berrangé wrote: > > On Thu, Jul 17, 2025 at 01:34:13PM +0300, Manos Pitsidianakis wrote: > > Add argument parsing to functional tests to improve developer experience > > when running individual tests. All logs are printed to stdout > > interspersed with T

Re: [PATCH v2] tests/functional: add --debug CLI arg

2025-07-18 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 01:34:13PM +0300, Manos Pitsidianakis wrote: > Add argument parsing to functional tests to improve developer experience > when running individual tests. All logs are printed to stdout > interspersed with TAP output. > > Example usage, assuming current build directory with q

Re: [RFC V2 0/8] Live update: tap and vhost

2025-07-18 Thread Lei Yang
Hi Steve I tested your patch which hit a problem under enable/disable nic mq state(The full test scenario is live migration vm at local under enable/disable vm nic mq state): Run command: /qemu-img info /home/images/vm1.qcow2 --output=json Error info: qemu-img: Could not open '/home/images/vm1.qco

Re: [PATCH] xen/passthrough: add missing error-report include

2025-07-18 Thread Daniel P . Berrangé
On Fri, Jul 18, 2025 at 07:59:50AM +0200, Markus Armbruster wrote: > Markus Armbruster writes: > > > Adam Williamson writes: > > > >> In cfcacba an `error_report` was added to this file, but the > >> corresponding include of `qemu/error-report.h` was missed. This > >> only becomes apparent when

Re: [PATCH] ui/spice: Destroy the temporary egl fb after the blit is submitted

2025-07-18 Thread Peter Maydell
On Fri, 18 Jul 2025 at 07:29, Vivek Kasireddy wrote: > > The temporary egl fb scanout_tex_fb is only needed to facilitate the > blit to the display surface's texture (ssd->ds->texture). Therefore, > destroy it after the blit is submitted. And, also make sure that it > is empty initialized before i

Re: [PATCH v2] net/tap: drop too small packets

2025-07-18 Thread Lei Yang
Tested this patch v2 again,everything works fine. Tested-by: Lei Yang On Wed, Jul 16, 2025 at 3:29 PM Vladimir Sementsov-Ogievskiy < vsement...@yandex-team.ru> wrote: > Theoretically tap_read_packet() may return size less than > s->host_vnet_hdr_len, and next, we'll work with negative size > (i

Re: [PATCH v8 08/12] hw/arm/virt: Allow user-creatable SMMUv3 dev instantiation

2025-07-18 Thread Nicolin Chen
On Fri, Jul 18, 2025 at 08:22:09AM +, Shameerali Kolothum Thodi wrote: > > So, my question was: where do we set the number of 4 to the sbdev? > > As platform_bus_get_irqn() returned very correctly with 0, 4, 8, > > and so on.. > > See smmu_realize() --> smmu_init_irq() > > And then in virt_ma

RE: [PATCH v8 08/12] hw/arm/virt: Allow user-creatable SMMUv3 dev instantiation

2025-07-18 Thread Shameerali Kolothum Thodi via
...@redhat.com; imamm...@redhat.com; > nath...@nvidia.com; mo...@nvidia.com; smost...@google.com; > gustavo.rom...@linaro.org; m...@redhat.com; > marcel.apfelb...@gmail.com; Linuxarm ; > Wangzhou (B) ; jiangkunkun > ; Jonathan Cameron > ; zhangfei@linaro.org > Subject: Re: [PATCH v

Re: [PATCH v8 08/12] hw/arm/virt: Allow user-creatable SMMUv3 dev instantiation

2025-07-18 Thread Nicolin Chen
On Fri, Jul 18, 2025 at 08:01:22AM +, Shameerali Kolothum Thodi wrote: > > > +int irq = platform_bus_get_irqn(pbus, sbdev, 0); > > > +hwaddr base = platform_bus_get_mmio_addr(pbus, sbdev, 0); > > > +MachineState *ms = MACHINE(vms); > > > + > > > +if (!(vms->bootinfo.firmware_loa

Re: [PULL 1/6] target/i386: do not expose ARCH_CAPABILITIES on AMD CPU

2025-07-18 Thread Paolo Bonzini
guests is only possible between identical host kernel and QEMU versions, therefore this is not a problematic breakage. If a future AMD machine does include the MSR, that would re-expose the Windows guest bug; but it would not be KVM/QEMU's problem at that point, as we'd be following a

Re: [PATCH] rust/pl011: merge device_class.rs into device.rs

2025-07-18 Thread Paolo Bonzini
Queued, thanks. But for 10.2 maybe we could alternate in preparing pull requests? We'll see. Paolo

RE: [PATCH v8 08/12] hw/arm/virt: Allow user-creatable SMMUv3 dev instantiation

2025-07-18 Thread Shameerali Kolothum Thodi via
...@redhat.com; imamm...@redhat.com; > nath...@nvidia.com; mo...@nvidia.com; smost...@google.com; > gustavo.rom...@linaro.org; m...@redhat.com; > marcel.apfelb...@gmail.com; Linuxarm ; > Wangzhou (B) ; jiangkunkun > ; Jonathan Cameron > ; zhangfei@linaro.org > Subject: Re: [PATCH v

Re: [PULL 1/6] target/i386: do not expose ARCH_CAPABILITIES on AMD CPU

2025-07-18 Thread Michael Tokarev
kernel and QEMU versions, therefore this is not a problematic breakage. If a future AMD machine does include the MSR, that would re-expose the Windows guest bug; but it would not be KVM/QEMU's problem at that point, as we'd be following a genuine physical CPU impl. Reported-by: Alexan

Re: [PATCH] xen/passthrough: add missing error-report include

2025-07-17 Thread Philippe Mathieu-Daudé
On 18/7/25 08:05, Philippe Mathieu-Daudé wrote: On 18/7/25 07:11, Markus Armbruster wrote: Adam Williamson writes: In cfcacba an `error_report` was added to this file, but the    In commit cfcacbab38e ("xen/passthrough: use gsi to map pirq when    dom0 is PVH") an `error_report` was added

Re: [PATCH-for-10.1] hw/arm/smmu-common: Avoid using inlined functions with external linkage

2025-07-17 Thread Philippe Mathieu-Daudé
Hi, (sorry for previously missing this patch) (cc'ing Google folks for https://lore.kernel.org/qemu-devel/20250717205735.2345674-1-r...@google.com/) On 14/2/25 08:20, JianChunfu wrote: Similarly to commit 9de9fa5c ("hw/arm/smmu-common: Avoid using inlined functions with external linkage"):

Re: [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1`

2025-07-17 Thread Philippe Mathieu-Daudé
On 17/7/25 22:57, Roman Kiryanov wrote: this function is declared in smmu-common.h without `inline`. It is also used outside of this file which causes linking errors because the non-inline version is not generated. Signed-off-by: Will Hollins Signed-off-by: Roman Kiryanov --- hw/arm/smmu-com

Re: [PATCH] xen/passthrough: add missing error-report include

2025-07-17 Thread Philippe Mathieu-Daudé
On 18/7/25 07:11, Markus Armbruster wrote: Adam Williamson writes: In cfcacba an `error_report` was added to this file, but the In commit cfcacbab38e ("xen/passthrough: use gsi to map pirq when dom0 is PVH") an `error_report` was added to this file, but the corresponding include of `

Re: [PATCH] xen/passthrough: add missing error-report include

2025-07-17 Thread Markus Armbruster
Markus Armbruster writes: > Adam Williamson writes: > >> In cfcacba an `error_report` was added to this file, but the >> corresponding include of `qemu/error-report.h` was missed. This >> only becomes apparent when building against Xen 4.20+. >> >> Signed-off-by: Adam Williamson >> --- >> hw/x

Re: [RFC PATCH RESEND 37/42] accel/hvf: Emulate HVC at EL2

2025-07-17 Thread Philippe Mathieu-Daudé
On 22/6/25 05:28, Richard Henderson wrote: On 6/20/25 10:27, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé ---   target/arm/hvf/hvf.c | 6 ++   1 file changed, 6 insertions(+) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 3907ea8791e..a4f823f834d 10064

Re: [PATCH v1] PCIE-Host Support 64Bit resource for DesignwarePCIEHost

2025-07-17 Thread zhangzhijie
Hi 在 2025/7/17 18:24, Bernhard Beschow 写道: Nice. Is there a datasheet (standalone or for the riscv SoC using this IP block) which you could provide? The QEMU emulation has some bugs which I'd like to fix. I not got designedware datasheet. I read Linux kernel code and found this feature. I

Re: [PATCH] xen/passthrough: add missing error-report include

2025-07-17 Thread Markus Armbruster
Adam Williamson writes: > In cfcacba an `error_report` was added to this file, but the > corresponding include of `qemu/error-report.h` was missed. This > only becomes apparent when building against Xen 4.20+. > > Signed-off-by: Adam Williamson > --- > hw/xen/xen_pt.c | 1 + > 1 file changed, 1

Re: [PATCH RFC v2 12/13] net: implement tunnel probing

2025-07-17 Thread Akihiko Odaki
On 2025/07/16 0:49, Paolo Abeni wrote: On 7/15/25 10:05 AM, Akihiko Odaki wrote: On 2025/07/11 22:02, Paolo Abeni wrote: diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 86b6edee94..e7de0672f4 100644 --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -217,6 +217,11 @@ int tap_probe_has_uso(int fd)

Re: [PATCH] docs: Fix Aspeed title

2025-07-17 Thread Cédric Le Goater
On 7/17/25 19:01, Peter Maydell wrote: On Tue, 15 Jul 2025 at 07:19, Cédric Le Goater wrote: commit ad8e0e8a0088 removed the "==" underlining the file title which broke documentation rendering. Add it back. Fixes: ad8e0e8a0088 ("docs: add support for gb200-bmc") Cc: Ed Tanous Reported-by

Re: [PATCH v5 09/23] migration: push Error **errp into ram_postcopy_incoming_init()

2025-07-17 Thread Akihiko Odaki
On 2025/07/18 2:02, Daniel P. Berrangé wrote: On Thu, Jul 17, 2025 at 12:34:21PM +0900, Akihiko Odaki wrote: On 2025/07/17 9:37, Arun Menon wrote: This is an incremental step in converting vmstate loading code to report error via Error objects instead of directly printing it to console/monitor.

Re: [PATCH v8 08/12] hw/arm/virt: Allow user-creatable SMMUv3 dev instantiation

2025-07-17 Thread Nicolin Chen
Hi Shameer, On Fri, Jul 11, 2025 at 09:47:45AM +0100, Shameer Kolothum wrote: > +static void create_smmuv3_dev_dtb(VirtMachineState *vms, > + DeviceState *dev, PCIBus *bus) > +{ > +PlatformBusDevice *pbus = PLATFORM_BUS_DEVICE(vms->platform_bus_dev); > +Sy

Re: [PATCH v8 00/12] hw/arm/virt: Add support for user creatable SMMUv3 device

2025-07-17 Thread Nicolin Chen
On Fri, Jul 11, 2025 at 09:47:37AM +0100, Shameer Kolothum wrote: > Changes from v7: > > 1. Rebased to latest target-arm.next(I have included patch#1 >as I can't find that after a git pull of latest) > 2. Addressed comments from Nicolin and added R-by tags. Thanks! I've tested this series usi

Re: [PATCH] hw/arm: remove `inline` from `smmu_iotlb_inv_vmid_s1`

2025-07-17 Thread Richard Henderson
On 7/17/25 13:57, Roman Kiryanov wrote: this function is declared in smmu-common.h without `inline`. It is also used outside of this file which causes linking errors because the non-inline version is not generated. Signed-off-by: Will Hollins Signed-off-by: Roman Kiryanov --- hw/arm/smmu-com

Re: [PULL 0/6] QAPI patches patches for 2025-07-16

2025-07-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/2] 9p queue 2025-07-16

2025-07-17 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] docs/devel/submitting-a-patch.rst: add b4 section

2025-07-17 Thread Manos Pitsidianakis
On Thu, Jul 17, 2025 at 9:48 PM Gustavo Romero wrote: > > Hi Manos, > > Nice, I use a lot b4 and I think many QEMU devs use it as well :) > > On 7/17/25 10:53, Manos Pitsidianakis wrote: > > Add a section about b4, an actively maintained and widely packaged CLI > > tool for contributing to patch-b

Re: [PATCH] docs/devel/submitting-a-patch.rst: add b4 section

2025-07-17 Thread Gustavo Romero
Hi Manos, Nice, I use a lot b4 and I think many QEMU devs use it as well :) On 7/17/25 10:53, Manos Pitsidianakis wrote: Add a section about b4, an actively maintained and widely packaged CLI tool for contributing to patch-based development projects. Signed-off-by: Manos Pitsidianakis --- d

RE: [PULL v2 09/13] ui/spice: Blit the scanout texture if its memory layout is not linear

2025-07-17 Thread Kasireddy, Vivek
Hi Peter, Marc-Andre, > Subject: Re: [PULL v2 09/13] ui/spice: Blit the scanout texture if its memory > layout is not linear > > On Tue, 15 Jul 2025 at 07:43, wrote: > > > > From: Vivek Kasireddy > > > > In cases where the scanout buffer is provided as a

Re: [PATCH v5 20/23] migration: push Error **errp into qemu_load_device_state()

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:43AM +0530, Arun Menon wrote: > This is an incremental step in converting vmstate loading > code to report error via Error objects instead of directly > printing it to console/monitor. > It is ensured that qemu_load_device_state() must report an error > in errp, in cas

Re: [PATCH v5 23/23] backends/tpm: Propagate vTPM error on migration failure

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:46AM +0530, Arun Menon wrote: > - When migration of a VM with encrypted vTPM fails on the > destination host, (e.g., due to a mismatch in secret values), > the error message displayed on the source host is generic and unhelpful. > - For example, a typical error loo

Re: [PATCH v5 22/23] migration: Add error-parameterized function variants in VMSD struct

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:45AM +0530, Arun Menon wrote: > - We need to have good error reporting in the callbacks in > VMStateDescription struct. Specifically pre_save, post_save, > pre_load and post_load callbacks. > - It is not possible to change these functions everywhere in one > patc

Re: [PATCH v5 19/23] migration: push Error **errp into qemu_loadvm_state()

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:42AM +0530, Arun Menon wrote: > This is an incremental step in converting vmstate loading > code to report error via Error objects instead of directly > printing it to console/monitor. > It is ensured that qemu_loadvm_state() must report an error > in errp, in case of

Re: [PATCH] target/arm: Provide always-false kvm_arm_*_supported() stubs for usermode

2025-07-17 Thread Pierrick Bouvier
On 7/17/25 10:12 AM, Peter Maydell wrote: On Thu, 17 Jul 2025 at 18:05, Pierrick Bouvier wrote: On 7/17/25 9:56 AM, Peter Maydell wrote: I'm not really a fan of relying on the compiler to fold stuff away -- it's fragile and there's no guarantee the compiler will actually do it. In this example

Re: [PATCH v5 21/23] migration: Capture error in postcopy_ram_listen_thread()

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:44AM +0530, Arun Menon wrote: > This is an incremental step in converting vmstate loading > code to report error via Error objects instead of directly > printing it to console/monitor. > postcopy_ram_listen_thread() calls qemu_loadvm_state_main() > to load the vm, and

Re: [PATCH v5 18/23] migration: push Error **errp into qemu_loadvm_state_main()

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:41AM +0530, Arun Menon wrote: > This is an incremental step in converting vmstate loading > code to report error via Error objects instead of directly > printing it to console/monitor. > It is ensured that qemu_loadvm_state_main() must report an error > in errp, in cas

Re: [PATCH v5 17/23] migration: push Error **errp into loadvm_postcopy_handle_switchover_start()

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:40AM +0530, Arun Menon wrote: > This is an incremental step in converting vmstate loading code to report > error via Error objects instead of directly printing it to console/monitor. > It is ensured that loadvm_postcopy_handle_switchover_start() must report > an error

Re: [PATCH v5 11/23] migration: push Error **errp into loadvm_postcopy_handle_listen()

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:34AM +0530, Arun Menon wrote: > This is an incremental step in converting vmstate loading > code to report error via Error objects instead of directly > printing it to console/monitor. > It is ensured that loadvm_postcopy_handle_listen() must report an error > in errp,

Re: [PATCH v5 07/23] migration: push Error **errp into loadvm_process_command()

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 05:54:41PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 17, 2025 at 06:07:30AM +0530, Arun Menon wrote: > > This is an incremental step in converting vmstate loading > > code to report error via Error objects instead of directly > > printing it to console/monitor. > > It i

Re: [PATCH v5 15/23] migration: push Error **errp into loadvm_handle_recv_bitmap()

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:38AM +0530, Arun Menon wrote: > This is an incremental step in converting vmstate loading > code to report error via Error objects instead of directly > printing it to console/monitor. > It is ensured that loadvm_handle_recv_bitmap() must report an error > in errp, in

Re: [PATCH v5 14/23] migration: make loadvm_postcopy_handle_resume() void

2025-07-17 Thread Daniel P . Berrangé
On Thu, Jul 17, 2025 at 06:07:37AM +0530, Arun Menon wrote: > This is an incremental step in converting vmstate loading > code to report error via Error objects instead of directly > printing it to console/monitor. > > Signed-off-by: Arun Menon > --- > migration/savevm.c | 14 -- > 1

  1   2   3   4   5   6   7   8   9   10   >