Re: RFC: Implementation of QMP documentation retrieval command

2021-06-23 Thread Stefan Hajnoczi
On Wed, Jun 23, 2021 at 12:27:55AM +0530, Niteesh G. S. wrote: > Hi Stefan, > On Tue, Jun 22, 2021 at 3:05 PM Stefan Hajnoczi wrote: > > > On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > > > TLDR: The goal of this mail wasn't to review the dummy command I had > > posted > > > but

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-22 Thread Niteesh G. S.
Hi Stefan, On Tue, Jun 22, 2021 at 3:05 PM Stefan Hajnoczi wrote: > On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > > TLDR: The goal of this mail wasn't to review the dummy command I had > posted > > but > > rather start a discussion regarding the implementation of the QMP > > do

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
22.06.2021 13:26, Daniel P. Berrangé wrote: There's a more fundamental question about structure here too. The documentation is not a arbitrary block of text. It contains specific data items for individual parameters, and return type, along with version number annotation too. If we're returning a

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 10:35:47AM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > > TLDR: The goal of this mail wasn't to review the dummy command I had posted > > but > > rather start a discussion regarding the implementation of the QMP > > documen

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-22 Thread Stefan Hajnoczi
On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > TLDR: The goal of this mail wasn't to review the dummy command I had posted > but > rather start a discussion regarding the implementation of the QMP > documentation > retrieval command for the TUI. It's not clear to me what exactly

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-21 Thread Niteesh G. S.
Hello Philippe, On Mon, Jun 21, 2021 at 8:28 PM Philippe Mathieu-Daudé wrote: > Hi Niteesh, > > On 6/16/21 5:48 PM, Niteesh G. S. wrote: > > Hello, > > > > We now have a reasonably working prototype that is capable of > > sending/receiving > > commands/responses, syntax highlighting, and a simpl

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-21 Thread Philippe Mathieu-Daudé
Hi Niteesh, On 6/16/21 5:48 PM, Niteesh G. S. wrote: > Hello, > > We now have a reasonably working prototype that is capable of > sending/receiving > commands/responses, syntax highlighting, and a simple notification > system. The > prototype can be found here > https://gitlab.com/niteesh.gs/qemu

RFC: Implementation of QMP documentation retrieval command

2021-06-16 Thread Niteesh G. S.
Hello, We now have a reasonably working prototype that is capable of sending/receiving commands/responses, syntax highlighting, and a simple notification system. The prototype can be found here https://gitlab.com/niteesh.gs/qemu/-/tree/aqmp-tui-prototype Working on this prototype gives us a lot of