RE: [Qemu-devel] Re: Audio output for CS4231, patch/RFC

2006-09-24 Thread malc
On Sun, 24 Sep 2006, Blue Swirl wrote: After having a cursory look at it only one thing really caught my attention: in the audio callback you set s->audio_free to the provided value, but then in you never use it. If i'm reading everything correctly this would lead to reading N bytes from DMA in

RE: [Qemu-devel] Re: Audio output for CS4231, patch/RFC

2006-09-23 Thread Blue Swirl
After having a cursory look at it only one thing really caught my attention: in the audio callback you set s->audio_free to the provided value, but then in you never use it. If i'm reading everything correctly this would lead to reading N bytes from DMA in write_audio, succeeding in writing only