RE: [PATCH v3] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-13 Thread Chenqun (kuhn)
>-Original Message- >From: Peter Maydell [mailto:peter.mayd...@linaro.org] >Sent: Friday, March 13, 2020 7:31 PM >To: Chenqun (kuhn) >Cc: QEMU Developers ; QEMU Trivial triv...@nongnu.org>; Zhanghailiang ; >Euler Robot ; Jason Wang >; Peter Chubb >Subject: Re

Re: [PATCH v3] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write()

2020-03-13 Thread Peter Maydell
On Fri, 13 Mar 2020 at 03:23, Chen Qun wrote: > > The current code causes clang static code analyzer generate warning: > hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read > value = value & 0x000f; > ^ ~~ > hw/net/imx_fec.c:864:9: warni