RE: [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c

> > +/* gdbstub.c */ > > +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *ppc); > > +gchar *ppc_gdb_arch_name(CPUState *cs); > > These should probably go into internal.h and not cpu.h. > These do not need to be exposed outside of target/ppc/. Makes sense, I can do that. Is such a small change wor

Re: [PATCH v2] target/ppc: code motion from translate_init.c.inc to gdbstub.c

On 4/13/21 7:54 AM, Bruno Larsen (billionai) wrote: +/* gdbstub.c */ +void ppc_gdb_init(CPUState *cs, PowerPCCPUClass *ppc); +gchar *ppc_gdb_arch_name(CPUState *cs); These should probably go into internal.h and not cpu.h. These do not need to be exposed outside of target/ppc/. +#include "exec