Re: [PATCH] include: Don't include qemu/osdep.h

2022-12-12 Thread Alistair Francis
On Mon, Dec 12, 2022 at 5:05 PM Markus Armbruster wrote: > > docs/devel/style.rst mandates: > > The "qemu/osdep.h" header contains preprocessor macros that affect > the behavior of core system headers like . It must be > the first include so that core system headers included by extern

Re: [PATCH] include: Don't include qemu/osdep.h

2022-12-12 Thread Daniel P . Berrangé
On Mon, Dec 12, 2022 at 04:55:55PM +, Taylor Simpson wrote: > > > > -Original Message- > > From: Markus Armbruster > > Sent: Monday, December 12, 2022 1:05 AM > > To: qemu-devel@nongnu.org > > Cc: i...@bsdimp.com; kev...@freebsd.org; berra...@redhat.com; > > jonathan.came...@huawei.c

RE: [PATCH] include: Don't include qemu/osdep.h

2022-12-12 Thread Taylor Simpson
> -Original Message- > From: Markus Armbruster > Sent: Monday, December 12, 2022 1:05 AM > To: qemu-devel@nongnu.org > Cc: i...@bsdimp.com; kev...@freebsd.org; berra...@redhat.com; > jonathan.came...@huawei.com; kbast...@mail.uni-paderborn.de; > jasow...@redhat.com; michael.r...@amd.com

Re: [PATCH] include: Don't include qemu/osdep.h

2022-12-12 Thread Bin Meng
On Mon, Dec 12, 2022 at 3:05 PM Markus Armbruster wrote: > > docs/devel/style.rst mandates: > > The "qemu/osdep.h" header contains preprocessor macros that affect > the behavior of core system headers like . It must be > the first include so that core system headers included by extern

Re: [PATCH] include: Don't include qemu/osdep.h

2022-12-11 Thread Philippe Mathieu-Daudé
On 12/12/22 08:04, Markus Armbruster wrote: docs/devel/style.rst mandates: The "qemu/osdep.h" header contains preprocessor macros that affect the behavior of core system headers like . It must be the first include so that core system headers included by external libraries ge