[PULL 05/30] include: rename qemu-common.h qemu/help-texts.h

2022-04-21 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Peter Maydell Signed-off-by: Marc-André Lureau Reviewed-by: Warner Losh Message-Id: <20220420132624.2439741-7-marcandre.lur...@redhat.com> --- include/{qemu-common.h => qemu/help-texts.h} | 0 bsd-user/main.c | 2

Qemu Help

2020-05-29 Thread Hakan GÜRBÜZ
Is it possible to run the .elf file produced from non-Linux operating system kernel in Qemu? I could not find a solution anywhere, please I am waiting for your help. The information you provide is very valuable for me.

[Qemu-devel] [PULL 02/10] doc: add -drive rerror=, werror= to qemu --help output

2014-04-25 Thread Stefan Hajnoczi
These options are already documented on the man page but missing from qemu --help. Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf --- qemu-options.hx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 6457034..98b4002 100644

Re: [Qemu-devel] [PATCH v2] doc: add -drive rerror=, werror= to qemu --help output

2014-04-24 Thread Stefan Hajnoczi
On Wed, Apr 23, 2014 at 01:55:37PM +0200, Stefan Hajnoczi wrote: > These options are already documented on the man page but missing from > qemu --help. > > Signed-off-by: Stefan Hajnoczi > --- > qemu-options.hx | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) App

Re: [Qemu-devel] [PATCH v2] doc: add -drive rerror=, werror= to qemu --help output

2014-04-23 Thread Kevin Wolf
Am 23.04.2014 um 13:55 hat Stefan Hajnoczi geschrieben: > These options are already documented on the man page but missing from > qemu --help. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf

[Qemu-devel] [PATCH v2] doc: add -drive rerror=, werror= to qemu --help output

2014-04-23 Thread Stefan Hajnoczi
These options are already documented on the man page but missing from qemu --help. Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 2d33815..a1333c2 100644 --- a/qemu-options.hx +++ b

Re: [Qemu-devel] [PATCH] doc: add -drive rerror=, werror= to qemu --help output

2014-04-23 Thread Kevin Wolf
Am 23.04.2014 um 09:36 hat Stefan Hajnoczi geschrieben: > These options are already documented on the man page but missing from > qemu --help. > > Signed-off-by: Stefan Hajnoczi > --- > qemu-options.hx | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > dif

[Qemu-devel] [PATCH] doc: add -drive rerror=, werror= to qemu --help output

2014-04-23 Thread Stefan Hajnoczi
These options are already documented on the man page but missing from qemu --help. Signed-off-by: Stefan Hajnoczi --- qemu-options.hx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 2d33815..664ad87 100644 --- a/qemu-options.hx +++ b

Re: [Qemu-devel] [PATCH 1/2] Mostly revert "qemu-help: Sort devices by logical functionality"

2013-10-10 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Thu, 2013-10-10 at 15:00 +0200, arm...@redhat.com wrote: >> From: Markus Armbruster >> >> This reverts most of commit 3d1237fb2ab4edb926c717767bb5e31d6053a7c5. >> >> The commit claims to sort the output of "-device help" "by >> functionality rather than alphabetic

Re: [Qemu-devel] [PATCH 1/2] Mostly revert "qemu-help: Sort devices by logical functionality"

2013-10-10 Thread Marcel Apfelbaum
On Thu, 2013-10-10 at 15:00 +0200, arm...@redhat.com wrote: > From: Markus Armbruster > > This reverts most of commit 3d1237fb2ab4edb926c717767bb5e31d6053a7c5. > > The commit claims to sort the output of "-device help" "by > functionality rather than alphabetical". Issues: > > * The output was

[Qemu-devel] [PATCH 1/2] Mostly revert "qemu-help: Sort devices by logical functionality"

2013-10-10 Thread armbru
From: Markus Armbruster This reverts most of commit 3d1237fb2ab4edb926c717767bb5e31d6053a7c5. The commit claims to sort the output of "-device help" "by functionality rather than alphabetical". Issues: * The output was unsorted before, not alphabetically sorted. Misleading, but harmless enou

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-28 Thread Marcel Apfelbaum
On Thu, 2013-08-22 at 15:48 +0300, Marcel Apfelbaum wrote: > This patch follows Markus Armbruster suggestion: > > A possibly better way to group help by category: instead of adding > categories to each line, add category headlines, like this: > > Controller/Bridge/Hub devices: > name "NAM

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-22 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Thu, 2013-08-22 at 09:34 -0600, Eric Blake wrote: >> On 08/22/2013 08:13 AM, Markus Armbruster wrote: >> >> >>> +++ b/qdev-monitor.c >> >>> @@ -156,6 +156,8 @@ static void >> >>> qdev_print_category_devices(DeviceCategory category) >> >>> DeviceClass *dc; >> >>

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-22 Thread Marcel Apfelbaum
On Thu, 2013-08-22 at 09:34 -0600, Eric Blake wrote: > On 08/22/2013 08:13 AM, Markus Armbruster wrote: > > >>> +++ b/qdev-monitor.c > >>> @@ -156,6 +156,8 @@ static void > >>> qdev_print_category_devices(DeviceCategory category) > >>> DeviceClass *dc; > >>> GSList *list, *curr; > >>>

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-22 Thread Eric Blake
On 08/22/2013 08:13 AM, Markus Armbruster wrote: >>> +++ b/qdev-monitor.c >>> @@ -156,6 +156,8 @@ static void qdev_print_category_devices(DeviceCategory >>> category) >>> DeviceClass *dc; >>> GSList *list, *curr; >>> >>> +error_printf("%s devices:\n", qdev_category_get_name(catego

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-22 Thread Markus Armbruster
Andreas Färber writes: > Am 22.08.2013 14:48, schrieb Marcel Apfelbaum: >> This patch follows Markus Armbruster suggestion: >> >> A possibly better way to group help by category: instead of adding >> categories to each line, add category headlines, like this: >> >> Controller/Bridge/Hub dev

Re: [Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-22 Thread Andreas Färber
Am 22.08.2013 14:48, schrieb Marcel Apfelbaum: > This patch follows Markus Armbruster suggestion: > > A possibly better way to group help by category: instead of adding > categories to each line, add category headlines, like this: > > Controller/Bridge/Hub devices: > name "NAME", bus "BUS

[Qemu-devel] [PATCH ] qemu-help: add category headlines

2013-08-22 Thread Marcel Apfelbaum
This patch follows Markus Armbruster suggestion: A possibly better way to group help by category: instead of adding categories to each line, add category headlines, like this: Controller/Bridge/Hub devices: name "NAME", bus "BUS"... ... USB devices: name "NAME", bus "BUS"...

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Michael S. Tsirkin
On Wed, Aug 21, 2013 at 01:42:58PM +0300, Marcel Apfelbaum wrote: > On Wed, 2013-08-21 at 11:23 +0200, Markus Armbruster wrote: > > Marcel Apfelbaum writes: > > > > > On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: > > >> This isn't patch review, just a couple of observations and ques

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Marcel Apfelbaum
On Wed, 2013-08-21 at 11:23 +0200, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: > >> This isn't patch review, just a couple of observations and questions. > >> > >> Current use of categories, please correct misunderstanding

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Markus Armbruster
Marcel Apfelbaum writes: > On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: >> This isn't patch review, just a couple of observations and questions. >> >> Current use of categories, please correct misunderstandings: >> >> * A device can have multiple categories. Most (all?) devices

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-21 Thread Marcel Apfelbaum
On Tue, 2013-08-13 at 11:57 +0200, Markus Armbruster wrote: > This isn't patch review, just a couple of observations and questions. > > Current use of categories, please correct misunderstandings: > > * A device can have multiple categories. Most (all?) devices currently > have exactly one. Al

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-13 Thread Eric Blake
On 08/13/2013 03:57 AM, Markus Armbruster wrote: > This isn't patch review, just a couple of observations and questions. > > > Should we require devices to have at least one category? If they can be enabled from the command line, yes. (Consider '-device pvpanic, which was NOT available in qemu

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-13 Thread Michael S. Tsirkin
On Tue, Aug 13, 2013 at 11:57:39AM +0200, Markus Armbruster wrote: > This isn't patch review, just a couple of observations and questions. > > Current use of categories, please correct misunderstandings: > > * A device can have multiple categories. Most (all?) devices currently > have exactly

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-08-13 Thread Markus Armbruster
This isn't patch review, just a couple of observations and questions. Current use of categories, please correct misunderstandings: * A device can have multiple categories. Most (all?) devices currently have exactly one. * -device help shows categories, like this: name "NAME", bus "BUS"

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-29 Thread Eric Blake
On 07/29/2013 02:24 PM, Anthony Liguori wrote: > Applied. Thanks. Script botch-up? This series has a title of RFC (which means it should not be applied as-is), and there have been later revisions that dropped the RFC in response to comments; did the correct version get applied? -- Eric Blake

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-29 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-29 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v4 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2013 at 05:17:44PM +0300, Marcel Apfelbaum wrote: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > The sort is done by functionality rather than alphabetical. > >

Re: [Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Michael S. Tsirkin
> Moved category names into the header file > > Changes from RFC patch: > Made category a bitmap to support multifunction PCI devices. > Assigned all devices to their category. > > Marcel Apfelbaum (3): > hw: import bitmap operations in qdev-core header > qemu-help:

[Qemu-devel] [PATCH v4 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. The sort is done by functionality rather than alphabetical. Signed-off-by: Marcel Apfelbaum --- Changes from v3: - fixed a memory leak

[Qemu-devel] [PATCH v4 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Marcel Apfelbaum
. Tsirkin review: Used bitmap operations on categories Moved category names into the header file Changes from RFC patch: Made category a bitmap to support multifunction PCI devices. Assigned all devices to their category. Marcel Apfelbaum (3): hw: import bitmap operations in qdev-core header

Re: [Qemu-devel] [PATCH v3 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 15:42 +0300, Michael S. Tsirkin wrote: > On Mon, Jul 29, 2013 at 03:36:24PM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-07-29 at 15:28 +0300, Michael S. Tsirkin wrote: > > > On Mon, Jul 29, 2013 at 03:11:42PM +0300, Marcel Apfelbaum wrote: > > > > Categorize devices that a

Re: [Qemu-devel] [PATCH v3 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2013 at 03:36:24PM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-07-29 at 15:28 +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2013 at 03:11:42PM +0300, Marcel Apfelbaum wrote: > > > Categorize devices that appear as output to "-device ?" command > > > by logical functionality

Re: [Qemu-devel] [PATCH v3 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 15:28 +0300, Michael S. Tsirkin wrote: > On Mon, Jul 29, 2013 at 03:11:42PM +0300, Marcel Apfelbaum wrote: > > Categorize devices that appear as output to "-device ?" command > > by logical functionality. Sort the devices by logical categories > > before showing them to user.

Re: [Qemu-devel] [PATCH v3 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Paolo Bonzini
Il 29/07/2013 14:11, Marcel Apfelbaum ha scritto: > Running qemu with "-device ?" option returns ~145 lines. > It is hard to manage understanding the output. > > Theses patches aim to partially solve the problem by dividing the devices > into logical categories like "Network/Display/..." and sorti

Re: [Qemu-devel] [PATCH v3 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 14:32 +0200, Paolo Bonzini wrote: > Il 29/07/2013 14:11, Marcel Apfelbaum ha scritto: > > Running qemu with "-device ?" option returns ~145 lines. > > It is hard to manage understanding the output. > > > > Theses patches aim to partially solve the problem by dividing the devi

Re: [Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 13:27 +0200, Paolo Bonzini wrote: > Il 29/07/2013 10:00, Marcel Apfelbaum ha scritto: > > On Mon, 2013-07-29 at 09:36 +0200, Paolo Bonzini wrote: > >> Il 28/07/2013 11:14, Marcel Apfelbaum ha scritto: > >>> Categories: > >>> Assembly - hosts/hubs/... > >> > >> A lot of these

Re: [Qemu-devel] [PATCH v3 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 15:11 +0300, Marcel Apfelbaum wrote: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > The sort is done by functionality rather than alphabetical. > > Signed

Re: [Qemu-devel] [PATCH v3 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2013 at 03:11:42PM +0300, Marcel Apfelbaum wrote: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > The sort is done by functionality rather than alphabetical. > >

[Qemu-devel] [PATCH v3 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. The sort is done by functionality rather than alphabetical. Signed-off-by: Marcel Apfelbaum --- Changes from v2: Addressed Michael Tsi

[Qemu-devel] [PATCH v3 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Marcel Apfelbaum
lbaum (3): hw: import bitmap operations in qdev-core header qemu-help: Sort devices by logical functionality devices: Associate devices to their logical category hw/9pfs/virtio-9p-device.c | 1 + hw/audio/ac97.c| 1 + hw/audio/adlib.c | 1 + hw/audio/

Re: [Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help

2013-07-29 Thread Paolo Bonzini
Il 29/07/2013 10:00, Marcel Apfelbaum ha scritto: > On Mon, 2013-07-29 at 09:36 +0200, Paolo Bonzini wrote: >> Il 28/07/2013 11:14, Marcel Apfelbaum ha scritto: >>> Categories: >>> Assembly - hosts/hubs/... >> >> A lot of these seem to fit in a "bridge" category. > I wanted to group in a category

Re: [Qemu-devel] [PATCH v2 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 12:22 +0300, Michael S. Tsirkin wrote: > On Mon, Jul 29, 2013 at 12:09:45PM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-07-29 at 11:20 +0300, Michael S. Tsirkin wrote: > > > On Mon, Jul 29, 2013 at 11:14:11AM +0300, Marcel Apfelbaum wrote: > > > > On Mon, 2013-07-29 at 11:

Re: [Qemu-devel] [PATCH v2 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2013 at 12:09:45PM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-07-29 at 11:20 +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2013 at 11:14:11AM +0300, Marcel Apfelbaum wrote: > > > On Mon, 2013-07-29 at 11:04 +0300, Michael S. Tsirkin wrote: > > > > On Mon, Jul 29, 2013 at 1

Re: [Qemu-devel] [PATCH v2 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 11:20 +0300, Michael S. Tsirkin wrote: > On Mon, Jul 29, 2013 at 11:14:11AM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-07-29 at 11:04 +0300, Michael S. Tsirkin wrote: > > > On Mon, Jul 29, 2013 at 10:07:34AM +0300, Marcel Apfelbaum wrote: > > > > Categorize devices that a

Re: [Qemu-devel] [PATCH v2 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2013 at 11:14:11AM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-07-29 at 11:04 +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 29, 2013 at 10:07:34AM +0300, Marcel Apfelbaum wrote: > > > Categorize devices that appear as output to "-device ?" command > > > by logical functionality

Re: [Qemu-devel] [PATCH v2 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 11:04 +0300, Michael S. Tsirkin wrote: > On Mon, Jul 29, 2013 at 10:07:34AM +0300, Marcel Apfelbaum wrote: > > Categorize devices that appear as output to "-device ?" command > > by logical functionality. Sort the devices by logical categories > > before showing them to user.

Re: [Qemu-devel] [PATCH v2 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Michael S. Tsirkin
On Mon, Jul 29, 2013 at 10:07:34AM +0300, Marcel Apfelbaum wrote: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > The sort is done by functionality rather than alphabetical. > >

Re: [Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help

2013-07-29 Thread Marcel Apfelbaum
On Mon, 2013-07-29 at 09:36 +0200, Paolo Bonzini wrote: > Il 28/07/2013 11:14, Marcel Apfelbaum ha scritto: > > Categories: > > Assembly - hosts/hubs/... > > A lot of these seem to fit in a "bridge" category. I wanted to group in a category as much as possible having in mind the user shall "grep

Re: [Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help

2013-07-29 Thread Paolo Bonzini
Il 28/07/2013 11:14, Marcel Apfelbaum ha scritto: > Categories: > Assembly - hosts/hubs/... A lot of these seem to fit in a "bridge" category. I'm not sure why usbhost is in the assembly category though. Also, why is this the default category for isa and i2c devices? > Management - controller

[Qemu-devel] [PATCH v2 2/3] qemu-help: Sort devices by logical functionality

2013-07-29 Thread Marcel Apfelbaum
Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. The sort is done by functionality rather than alphabetical. Signed-off-by: Marcel Apfelbaum --- Changes from v1: Addressed Michael Tsirkin

[Qemu-devel] [PATCH v2 0/3] qemu-help: improve -device command line help

2013-07-29 Thread Marcel Apfelbaum
Assigned all devices to their category. Marcel Apfelbaum (3): hw: import bitmap operations in qdev-core header qemu-help: Sort devices by logical functionality devices: Associate devices to their logical category hw/9pfs/virtio-9p-device.c | 1 + hw/audio/ac97.c

Re: [Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help

2013-07-28 Thread Michael S. Tsirkin
FC patch: > Made category a bitmap to support multifunction PCI devices. > Assigned all devices to their category. > > Marcel Apfelbaum (2): > qemu-help: Sort devices by logical functionality > devices: Associate devices to their logical category > > hw/9pfs/virtio-

Re: [Qemu-devel] [PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-28 Thread Michael S. Tsirkin
On Sun, Jul 28, 2013 at 12:14:53PM +0300, Marcel Apfelbaum wrote: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > The sort is done by functionality rather than alphabetical. > >

[Qemu-devel] [PATCH 0/2] qemu-help: improve -device command line help

2013-07-28 Thread Marcel Apfelbaum
embly - hosts/hubs/... Management - controllers ... (All others are self explanatory) Changes from RFC patch: Made category a bitmap to support multifunction PCI devices. Assigned all devices to their category. Marcel Apfelbaum (2): qemu-help: Sort devices by logical functionality devices: Associ

[Qemu-devel] [PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-28 Thread Marcel Apfelbaum
Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. The sort is done by functionality rather than alphabetical. Signed-off-by: Marcel Apfelbaum --- Changes from RFC Made category a bitmap to

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-21 Thread Ronen Hod
On 07/18/2013 05:28 PM, Anthony Liguori wrote: Marcel Apfelbaum writes: Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum Reviewed-by: Kevin Wolf ---

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-21 Thread Michael S. Tsirkin
tches aim to partially solve the problem by dividing the devices > > into logical categories like "Network/Display/..." and sorting them by it. > > > > Marcel Apfelbaum (2): > > qemu-help: Sort devices by logical functionality > > devices: Associate device

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-21 Thread Andreas Färber
"Network/Display/..." and sorting them by it. > > Marcel Apfelbaum (2): > qemu-help: Sort devices by logical functionality > devices: Associate devices to their logical category Sorry to jump on this discussion. I think the idea to structure devices better does make sense

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-21 Thread Michael S. Tsirkin
On Thu, Jul 18, 2013 at 09:58:59AM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: > >> On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: > >>> Marcel Apfelbaum writes: > >>> > Categorize devices that appear as output to

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 17:23, Marcel Apfelbaum ha scritto: Antony, thanks for your review! The whole point was to find a way to differentiate them by functionality so they can be sorted... Is it possible that a multifunction pci card will be used for more then one category mentioned

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
On Thu, 2013-07-18 at 09:58 -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: > >> On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: > >>> Marcel Apfelbaum writes: > >>> > Categorize devices that appear as output to "-devic

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Eric Blake
On 07/18/2013 07:56 AM, Paolo Bonzini wrote: > Il 18/07/2013 10:27, Marcel Apfelbaum ha scritto: >> Running qemu with "-device ?" option returns ~145 lines. >> It is hard to manage understanding the output. >> >> Theses patches aim to partially solve the problem by dividing the devices >> into logi

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Anthony Liguori
Paolo Bonzini writes: > Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: >> On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: >>> Marcel Apfelbaum writes: >>> Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: > On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: >> Marcel Apfelbaum writes: >> >>> Categorize devices that appear as output to "-device ?" command >>> by logical functionality. Sort the devices by logical categories >>> before showing t

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: > Marcel Apfelbaum writes: > > > Categorize devices that appear as output to "-device ?" command > > by logical functionality. Sort the devices by logical categories > > before showing them to user. > > > > Signed-off-by: Marcel Apfelbaum

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Anthony Liguori
Marcel Apfelbaum writes: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Kevin Wolf > --- > include/hw/qdev-core.h | 7 +++

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2013 at 11:27:42AM +0300, Marcel Apfelbaum wrote: > Categorize devices that appear as output to "-device ?" command > by logical functionality. Sort the devices by logical categories > before showing them to user. > > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Kevin Wolf > --

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Marcel Apfelbaum
should not break it. Me too :) > > Paolo > > > Marcel Apfelbaum (2): > > qemu-help: Sort devices by logical functionality > > devices: Associate devices to their logical category > > > > hw/audio/ac97.c | 1 + > > hw/display/cirrus_vga.c |

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Paolo Bonzini
"Network/Display/..." and sorting them by it. Nice! :) An unexpected benefit of moving all the hw/ files to separate per-type directory. I checked libvirt and this should not break it. Paolo > Marcel Apfelbaum (2): > qemu-help: Sort devices by logical functionality > devices:

[Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum Reviewed-by: Kevin Wolf --- include/hw/qdev-core.h | 7 +++ qdev-monitor.c | 23

[Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Marcel Apfelbaum
Running qemu with "-device ?" option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical categories like "Network/Display/..." and sorting them by it. Marcel Apfelbaum (2

[Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
Categorize devices that appear as output to "-device ?" command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum Reviewed-by: Kevin Wolf --- include/hw/qdev-core.h | 7 +++ qdev-monitor.c | 23

[Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Marcel Apfelbaum
Running qemu with "-device ?" option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical categories like "Network/Display/..." and sorting them by it. Marcel Apfelbaum (2

[Qemu-devel] [PATCH 07/14] spice: increase the verbosity of spice section in "qemu --help"

2012-09-06 Thread Gerd Hoffmann
From: Yonit Halperin Added all spice options to the help string. This can be used by libvirt to determine which spice related features are supported by qemu. Signed-off-by: Yonit Halperin Signed-off-by: Gerd Hoffmann --- qemu-options.hx | 18 +- 1 files changed, 17 insertion

Re: [Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-27 Thread Eric Blake
On 08/26/2012 12:38 AM, Yonit Halperin wrote: > On 08/21/2012 03:31 PM, Eric Blake wrote: >> On 08/21/2012 04:54 AM, Yonit Halperin wrote: >>> Added all spice options to the help string. This can be used by libvirt >>> to determine which spice related features are supported by qemu. >> >> For older

Re: [Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-25 Thread Yonit Halperin
On 08/21/2012 03:31 PM, Eric Blake wrote: On 08/21/2012 04:54 AM, Yonit Halperin wrote: Added all spice options to the help string. This can be used by libvirt to determine which spice related features are supported by qemu. For older released, this is true; but for future versions of qemu, li

Re: [Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-21 Thread Eric Blake
On 08/21/2012 04:54 AM, Yonit Halperin wrote: > Added all spice options to the help string. This can be used by libvirt > to determine which spice related features are supported by qemu. For older released, this is true; but for future versions of qemu, libvirt would much rather learn this informa

Re: [Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-21 Thread Gerd Hoffmann
On 08/21/12 12:54, Yonit Halperin wrote: > Added all spice options to the help string. This can be used by libvirt > to determine which spice related features are supported by qemu. Patch added to spice patch queue. thanks, Gerd

[Qemu-devel] [PATCH] spice: increase the verbosity of spice section in "qemu --help"

2012-08-21 Thread Yonit Halperin
Added all spice options to the help string. This can be used by libvirt to determine which spice related features are supported by qemu. Signed-off-by: Yonit Halperin --- qemu-options.hx | 18 +- 1 files changed, 17 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/