Re: QMP introspecting device props common to a bus type

2021-04-09 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Apr 09, 2021 at 11:18:42AM +0200, Markus Armbruster wrote: >> Gerd Hoffmann writes: [...] >> >> Gerd, you changed device-list-properties from object_class_by_name() to >> >> module_object_class_by_name() in commit 7ab6e7fcce. Should >> >> qom-list-properties

Re: QMP introspecting device props common to a bus type

2021-04-09 Thread Daniel P . Berrangé
On Fri, Apr 09, 2021 at 11:18:42AM +0200, Markus Armbruster wrote: > Gerd Hoffmann writes: > > > Hi, > > > >> device-list-properties uses module_object_class_by_name(), requires the > >> result to be a concrete device type, iterates over QOM properties with > >> object_property_iter_init() / ob

Re: QMP introspecting device props common to a bus type

2021-04-09 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> device-list-properties uses module_object_class_by_name(), requires the >> result to be a concrete device type, iterates over QOM properties with >> object_property_iter_init() / object_property_iter_next(), skipping >> properties named "type", "realized", "hotp

Re: QMP introspecting device props common to a bus type

2021-04-08 Thread Gerd Hoffmann
Hi, > device-list-properties uses module_object_class_by_name(), requires the > result to be a concrete device type, iterates over QOM properties with > object_property_iter_init() / object_property_iter_next(), skipping > properties named "type", "realized", "hotpluggable", "hotplugged", > "par

Re: QMP introspecting device props common to a bus type

2021-04-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Apr 08, 2021 at 01:56:28PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > When introspecting properties for devices, libvirt issues a sequence of >> > QMP 'device-list-properties' commands, one for each device type we >> > need info f

Re: QMP introspecting device props common to a bus type

2021-04-08 Thread Daniel P . Berrangé
On Thu, Apr 08, 2021 at 01:56:28PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > When introspecting properties for devices, libvirt issues a sequence of > > QMP 'device-list-properties' commands, one for each device type we > > need info for. The result of this command tell

Re: QMP introspecting device props common to a bus type

2021-04-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > When introspecting properties for devices, libvirt issues a sequence of > QMP 'device-list-properties' commands, one for each device type we > need info for. The result of this command tells us about all properties > possible on that specific device, which is genera

QMP introspecting device props common to a bus type

2021-04-07 Thread Daniel P . Berrangé
When introspecting properties for devices, libvirt issues a sequence of QMP 'device-list-properties' commands, one for each device type we need info for. The result of this command tells us about all properties possible on that specific device, which is generally just fine. Every now and then th