Re: Missing Null check

Thanks for the fix! Best, Mansour On Wed, Mar 18, 2020 at 4:14 AM Philippe Mathieu-Daudé wrote: > On 3/17/20 9:40 PM, Mansour Ahmadi wrote: > > Is a NULL check on 'drv1->format_name' missing here? > > > https://github.com/qemu/qemu/blob/cc818a2148c5f321bdeb8e5564bdb2914e824600/block.c#L400-L40

Re: Missing Null check

On 3/17/20 9:40 PM, Mansour Ahmadi wrote: Is a NULL check on 'drv1->format_name' missing here? https://github.com/qemu/qemu/blob/cc818a2148c5f321bdeb8e5564bdb2914e824600/block.c#L400-L403 if(!strcmp(drv1->format_name, format_name)) { This could be NULL indeed. I'd rather assertions in the entr

Missing Null check

Is a NULL check on 'drv1->format_name' missing here? https://github.com/qemu/qemu/blob/cc818a2148c5f321bdeb8e5564bdb2914e824600/block.c#L400-L403 if (!strcmp(drv1->format_name, format_name)) { While it is checked in similar case: https://github.com/qemu/qemu/blob/cc818a2148c5f321bdeb8e5564bdb2914

[PULL 4/5] virtiofsd: do_read missing NULL check

From: "Dr. David Alan Gilbert" Missing a NULL check if the argument fetch fails. Fixes: Coverity CID 1413119 Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi --- tools/virtiofsd/fuse_lowlevel.c | 4 1 file changed, 4 insertions(+) d

Re: [PATCH 4/4] virtiofsd: do_read missing NULL check

On 2/4/20 12:05 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Missing a NULL check if the argument fetch fails. Surprisingly all other calls to fuse_mbuf_iter_advance() do the check. Reviewed-by: Philippe Mathieu-Daudé Fixes: Coverity CID 1413119 Signed-off-by: D

[PATCH 4/4] virtiofsd: do_read missing NULL check

From: "Dr. David Alan Gilbert" Missing a NULL check if the argument fetch fails. Fixes: Coverity CID 1413119 Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_lowlevel.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_

[Qemu-devel] [PULL 32/32] qapi: Add missing null check to opts_start_struct()

From: Markus Armbruster Argument is null when visiting an unboxed struct. I can't see such a visit in the current code. Fix it anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qapi/opts-visitor.c | 4 +++- 1 file changed, 3 insertions(+),

[Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start_struct()

Argument is null when visiting an unboxed struct. I can't see such a visit in the current code. Fix it anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/opts-visitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/opts-visitor.c b/qapi/opt

Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 10/02/2014 16:28, Eric Blake ha scritto: | On 02/10/2014 07:20 AM, Markus Armbruster wrote: |> Argument is null when visiting an unboxed struct. I can't see |> such a visit in the current code. Fix it anyway. | | Is this a sign of missing testsui

Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct()

On 02/10/2014 07:20 AM, Markus Armbruster wrote: > Argument is null when visiting an unboxed struct. I can't see such a > visit in the current code. Fix it anyway. Is this a sign of missing testsuite coverage? > > Signed-off-by: Markus Armbruster > --- > qapi/opts-visitor.c | 4 +++- > 1 fil

[Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct()

Argument is null when visiting an unboxed struct. I can't see such a visit in the current code. Fix it anyway. Signed-off-by: Markus Armbruster --- qapi/opts-visitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 96ed858