Re: Hot unplug disabling on pci-pci bridge

2020-04-17 Thread Ani Sinha
Hi Igor: > On Mar 24, 2020, at 7:47 PM, Igor Mammedov wrote: > > if you are interested in hacking ACPI PCI hotplug more, look at how > build_append_pci_bus_devices() works I am trying to disable hot unplug of a device on PCI-PCI bridge without removing the capability to hot plug. Will it be e

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Ani Sinha
> On Mar 24, 2020, at 7:39 PM, Igor Mammedov wrote: > > disable acpi pci hotplug globally for VM This sounds like a good idea for our needs. A

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Ani Sinha
> On Mar 24, 2020, at 7:47 PM, Igor Mammedov wrote: > > if you are interested in hacking ACPI PCI hotplug more, look at how > build_append_pci_bus_devices() works Cool. Will keep digging while stuck at home :-) A

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Igor Mammedov
On Tue, 24 Mar 2020 13:29:10 + Ani Sinha wrote: > On Mar 24, 2020, at 4:47 PM, Igor Mammedov > mailto:imamm...@redhat.com>> wrote: > > you probably have APCI hotplug for bridges enabled (which applies to > all cold-plugged bridges). > You can disable it by setting following property > -glo

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Igor Mammedov
On Tue, 24 Mar 2020 11:49:53 + Ani Sinha wrote: > > On Mar 24, 2020, at 4:38 PM, Igor Mammedov wrote: > > > > question is do you need to disable only unplug side both > > (plug+unplug) operations (like we did with PCIE)? > > I need to disable the unplug side only. I don't know about SH

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Ani Sinha
> On Mar 24, 2020, at 4:38 PM, Igor Mammedov wrote: > > question is do you need to disable only unplug side both > (plug+unplug) operations (like we did with PCIE)? I need to disable the unplug side only. Ani

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Igor Mammedov
On Tue, 24 Mar 2020 10:06:00 + Ani Sinha wrote: [...] > > To that end, I have been experimenting with Qemu using the patch I attach > below. I have attached the virtio balloon driver with bus 1 which is attached > to the pci bridge. Following is the libvirt 4.5 xml snippet which I am using:

Re: Hot unplug disabling on pci-pci bridge

2020-03-24 Thread Igor Mammedov
On Tue, 24 Mar 2020 10:06:00 + Ani Sinha wrote: > Hi All : > > I have been playing with Qemu trying to disable hot-unplug capability for > conventional PCI. I have discussed this briefly on IRC and the plan is to > have an option on the pci-pci bridge that would disable SHPC and ACPI hotpl